[libav-devel] [PATCH] swscale: Properly load alpha for planar rgb

2016-10-14 Thread Vittorio Giovara
From: Michael Niedermayer Signed-off-by: Vittorio Giovara --- This should fix ppc and sun fate tests. Vittorio libswscale/input.c | 37 + tests/ref/fate/filter-pixfmts-scale | 4 ++-- 2 files

Re: [libav-devel] [PATCH] swscale: Properly load alpha for planar rgb

2016-10-14 Thread Luca Barbato
On 14/10/2016 23:25, Vittorio Giovara wrote: > From: Michael Niedermayer > > Signed-off-by: Vittorio Giovara > --- > This should fix ppc and sun fate tests. > Vittorio Patch Ok. lu ___ libav-devel

Re: [libav-devel] [PATCH 1/2] build: checkasm: Drop duplicate yasm recipe

2016-10-14 Thread Luca Barbato
The set looks nice, ok if it works. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 2/2] checkasm: Add a test for HEVC add_residual

2016-10-14 Thread Luca Barbato
On 14/10/2016 01:06, Diego Biurrun wrote: > Also, 12-bit, 14-bit, and 16-bit SIMD also does not exist, why not > start testing it as well right now? After all, the code might appear > in the future... The term checkasm is misleading. The whole thing is a unit-test for some specific dsp functions.

Re: [libav-devel] [PATCH 2/7] build: Generalize yasm/nasm-related variable names

2016-10-14 Thread Martin Storsjö
On Fri, 14 Oct 2016, Diego Biurrun wrote: None of them are specific to the YASM assembler. --- This could probably mention that out of the two, nasm is the actively developed one now. diff --git a/configure b/configure index cdd27db..5497c6d 100755 --- a/configure +++ b/configure @@

Re: [libav-devel] [PATCH 2/2] build: Add VSX-OBJS to SUBDIR_VARS

2016-10-14 Thread Luca Barbato
On 13/10/2016 22:19, Diego Biurrun wrote: > The variable needs to be reset for each subdir. > --- > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index 4e026b0..aff7e23 100644 > --- a/Makefile > +++ b/Makefile > @@ -125,7 +125,7 @@

Re: [libav-devel] [PATCH 1/7] emms: Give apriv_emms_yasm() a more general name

2016-10-14 Thread Martin Storsjö
On Fri, 14 Oct 2016, Diego Biurrun wrote: --- libavutil/x86/emms.asm | 4 ++-- libavutil/x86/emms.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/libavutil/x86/emms.asm b/libavutil/x86/emms.asm index 341f127..b0faec2 100644 --- a/libavutil/x86/emms.asm +++

Re: [libav-devel] [PATCH 4/7] build: Make standalone assembler command-line-selectable

2016-10-14 Thread Martin Storsjö
On Fri, 14 Oct 2016, Diego Biurrun wrote: --- configure | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/configure b/configure index d03707e..4d5dcf3 100755 --- a/configure +++ b/configure @@ -261,7 +261,8 @@ Toolchain options: --toolchain=NAME set

Re: [libav-devel] [RFC] assembly-related toolchain refactoring(s)

2016-10-14 Thread Martin Storsjö
On Fri, 14 Oct 2016, Diego Biurrun wrote: I decided to clean up an old crufty branch on the plane over the atlantic.. This generalizes the assembler program selection so that it works more like the compiler selection. After this set, the assembler is properly probed for and can be selected on

[libav-devel] [PATCH 4/5] rtmpproto: Don't include the libavformat version as "clientid"

2016-10-14 Thread Martin Storsjö
When acting as server, the server can include a "clientid" property in some status messages. But this should be a unique number identifying the client session, not identifying the server itself. In practice, omitting it works just as well as including this incorrect field. ---

[libav-devel] [PATCH 3/5] rtmpproto: Send chunk size on the network channel

2016-10-14 Thread Martin Storsjö
This makes sure that e.g. Adobe FME actually reacts to it. As long as the value we've been sending is the default one (128), the bug hasn't been noticed. --- libavformat/rtmpproto.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/rtmpproto.c

Re: [libav-devel] [PATCH 2/2] checkasm: Add a test for HEVC add_residual

2016-10-14 Thread Henrik Gramner
On Fri, Oct 14, 2016 at 10:29 AM, Luca Barbato wrote: > The term checkasm is misleading. The whole thing is a unit-test for some > specific dsp functions. Not really, no. The checkasm tests only tests whether or not the output of the assembly functions matches the output of

Re: [libav-devel] [PATCH 1/5] rtmpproto: Check the return from ff_amf_read_string

2016-10-14 Thread Luca Barbato
Set Ok. Maybe could land in release/12 as well. lu ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 2/7] build: Generalize yasm/nasm-related variable names

2016-10-14 Thread Diego Biurrun
On Fri, Oct 14, 2016 at 10:27:54AM +0300, Martin Storsjö wrote: > On Fri, 14 Oct 2016, Diego Biurrun wrote: > > >None of them are specific to the YASM assembler. > >--- > > This could probably mention that out of the two, nasm is the actively > developed one now. I mention that fact in the

Re: [libav-devel] [PATCH 4/7] build: Make standalone assembler command-line-selectable

2016-10-14 Thread Diego Biurrun
On Fri, Oct 14, 2016 at 10:29:58AM +0300, Martin Storsjö wrote: > On Fri, 14 Oct 2016, Diego Biurrun wrote: > >--- a/configure > >+++ b/configure > >@@ -261,7 +261,8 @@ Toolchain options: > > --toolchain=NAME set tool defaults according to NAME > > --nm=NM use nm tool >

Re: [libav-devel] [RFC] assembly-related toolchain refactoring(s)

2016-10-14 Thread Diego Biurrun
On Fri, Oct 14, 2016 at 10:24:14AM +0300, Martin Storsjö wrote: > On Fri, 14 Oct 2016, Diego Biurrun wrote: > >I decided to clean up an old crufty branch on the plane over the atlantic.. > > > >This generalizes the assembler program selection so that it works more > >like the compiler selection.

Re: [libav-devel] [RFC] [PATCH] fate: Add --skip-tests configure option for omitting FATE tests

2016-10-14 Thread Martin Storsjö
On Fri, 14 Oct 2016, Diego Biurrun wrote: On Thu, Oct 13, 2016 at 11:34:05PM +0300, Martin Storsjö wrote: On Fri, 7 Oct 2016, Martin Storsjö wrote: >On Fri, 7 Oct 2016, Martin Storsjö wrote: >>On Fri, 7 Oct 2016, Diego Biurrun wrote: >>>On Fri, Oct 07, 2016 at 10:45:47AM +0300, Martin Storsjö

Re: [libav-devel] [PATCH 4/4] checkasm: aarch64: Add filler args to make sure all parameters are passed on the stack

2016-10-14 Thread Janne Grunau
On Friday, 30 September 2016 11:22:15 CEST, Martin Storsjö wrote: This, combined with clobbering the stack space prior to the call, increases the chances of finding cases where 32 bit parameters are erroneously treated as 64 bit. --- With the current aarch64 asm and checkasm tests, this found

Re: [libav-devel] [PATCH 1/4] checkasm: arm/aarch64: Fix the amount of space reserved for stack parameters

2016-10-14 Thread Janne Grunau
On Friday, 30 September 2016 11:22:12 CEST, Martin Storsjö wrote: Even if MAX_ARGS - 2 (for arm) or MAX_ARGS - 7 (for aarch64) parameters are passed on the stack to checkasm_checked_call, we actually only need to store MAX_ARGS - 4 (for arm) or MAX_ARGS - 8 (for aarch64) parameters on the stack

Re: [libav-devel] [PATCH 1/2] build: checkasm: Drop duplicate yasm recipe

2016-10-14 Thread Janne Grunau
On Friday, 14 October 2016 01:42:02 CEST, Diego Biurrun wrote: Also move yasm recipe next to the other local pattern rules for .o files. The patch moves the duplicate yasm rules into the top Makefile. Both patches ok after fixing this description. Janne

Re: [libav-devel] [PATCH 3/4] checkasm: aarch64: Clobber the stack before calling functions

2016-10-14 Thread Janne Grunau
On Friday, 30 September 2016 11:22:14 CEST, Martin Storsjö wrote: --- tests/checkasm/aarch64/checkasm.S | 14 ++ tests/checkasm/checkasm.h | 6 +- 2 files changed, 19 insertions(+), 1 deletion(-) diff --git a/tests/checkasm/aarch64/checkasm.S

[libav-devel] [PATCH 5/5] rtmpproto: Don't include a client version in the unencrypted C1 handshake

2016-10-14 Thread Martin Storsjö
According to the public RTMP specification, these 4 bytes should be zero. librtmp in server mode assumes that the RTMPE (FP9) handshake is used if these bytes are nonzero. --- libavformat/rtmpproto.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/libavformat/rtmpproto.c

[libav-devel] [PATCH 2/5] rtmpproto: Lengthen the filename buffer when receiving streams

2016-10-14 Thread Martin Storsjö
Some applications such as Adobe FME append lots of parameters here, making it easily overflow the current limit. --- libavformat/rtmpproto.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c index 6402425..8817744 100644 ---

[libav-devel] [PATCH 1/5] rtmpproto: Check the return from ff_amf_read_string

2016-10-14 Thread Martin Storsjö
If this failed, we used to continue with an uninitialized filename buffer. CC: libav-sta...@libav.org --- libavformat/rtmpproto.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c index e7e2479..6402425 100644 ---

Re: [libav-devel] [PATCH 1/5] rtmpproto: Check the return from ff_amf_read_string

2016-10-14 Thread Martin Storsjö
On Fri, 14 Oct 2016, Luca Barbato wrote: Set Ok. Maybe could land in release/12 as well. Yep, 1-3 or 1-4 can probably go in right away. For patch 5, I'd prefer to have it only in master first for a little while, and if we don't hear anything bad about it, it can be backported to release

[libav-devel] [PATCHv2 3/4] checkasm: aarch64: Clobber the stack before calling functions

2016-10-14 Thread Martin Storsjö
--- Clobbering 16 bytes per iteration in the asm function, using 23 (8 + 15) parameters instead of 21 as before. --- tests/checkasm/aarch64/checkasm.S | 13 + tests/checkasm/checkasm.h | 6 +- 2 files changed, 18 insertions(+), 1 deletion(-) diff --git

Re: [libav-devel] [PATCH 3/4] checkasm: aarch64: Clobber the stack before calling functions

2016-10-14 Thread Martin Storsjö
On Fri, 14 Oct 2016, Janne Grunau wrote: On Friday, 30 September 2016 11:22:14 CEST, Martin Storsjö wrote: --- tests/checkasm/aarch64/checkasm.S | 14 ++ tests/checkasm/checkasm.h | 6 +- 2 files changed, 19 insertions(+), 1 deletion(-) diff --git