Re: [libav-devel] [PATCH 10/14] vaapi_h264: Add missing return value check

On Thu, Nov 09, 2017 at 01:07:52AM +, Mark Thompson wrote: > --- > libavcodec/vaapi_encode_h264.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) LGTM Diego ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH 01/14] cbs: Allocate the context inside the init function

On Thu, Nov 09, 2017 at 01:07:43AM +, Mark Thompson wrote: > ... instead of making the caller allocate it themselves. This is "making callers allocate it themselves" sounds more natural to me. Diego ___ libav-devel mailing list

Re: [libav-devel] [PATCH 09/14] h264_metadata: Fix clearing SEI payload in error case

On Thu, Nov 09, 2017 at 01:07:51AM +, Mark Thompson wrote: > --- > libavcodec/h264_metadata_bsf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) OK > --- a/libavcodec/h264_metadata_bsf.c > +++ b/libavcodec/h264_metadata_bsf.c > @@ -368,7 +368,7 @@ static int

Re: [libav-devel] [PATCH 05/14] cbs: Minor comment fixes / cosmetics

On Thu, Nov 09, 2017 at 01:07:47AM +, Mark Thompson wrote: > --- a/libavcodec/cbs.h > +++ b/libavcodec/cbs.h > @@ -25,6 +25,19 @@ > > +/* > + * This defines a framework for converting between a coded bitstream > + * and structures defining all individual syntax elements found in > + * such a

Re: [libav-devel] [PATCH 07/14] cbs_mpeg2: Fix marker_bit type

On Thu, Nov 09, 2017 at 01:07:49AM +, Mark Thompson wrote: > --- a/libavcodec/cbs_mpeg2.c > +++ b/libavcodec/cbs_mpeg2.c > @@ -54,7 +54,7 @@ > > #define marker_bit() do { \ > -av_unused int one = 1; \ > +av_unused uint32_t one; \ > CHECK(ff_cbs_read_unsigned(ctx,

Re: [libav-devel] [PATCH 04/14] cbs: Add a missing return value check

On Thu, Nov 09, 2017 at 01:07:46AM +, Mark Thompson wrote: > --- > libavcodec/cbs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) OK Diego ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH 03/14] cbs: Use correct conversion specifier for unit type

On Thu, Nov 09, 2017 at 01:07:45AM +, Mark Thompson wrote: > --- > libavcodec/cbs_h2645.c | 2 +- > libavcodec/cbs_mpeg2.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) Why not squash this into 2/14 where you already switch some conversion specifiers (or switch all conversion

Re: [libav-devel] [PATCH 08/14] cbs_h2645: Fix memory leak on when reading SEI fails

On Thu, Nov 09, 2017 at 01:07:50AM +, Mark Thompson wrote: > --- a/libavcodec/cbs_h2645.c > +++ b/libavcodec/cbs_h2645.c > @@ -824,6 +824,7 @@ static int cbs_h264_read_nal_unit(CodedBitstreamContext > *ctx, > err = cbs_h264_read_sei(ctx, , sei); > if (err < 0) { >

Re: [libav-devel] [PATCH 1/5] configure: Miscellaneous minor changes

On 11/3/2017 1:43 PM, Diego Biurrun wrote: > - Move a variable closer to where it is used > - Add an explanatory comment > - Simplify a crosscompile check > - Minor SHFLAGS simplification > - Coalesce some threads tests > --- > configure | 17 - > 1 file changed, 8 insertions(+),

Re: [libav-devel] the big configure cleanup (act V)

On Fri, Nov 03, 2017 at 05:43:17PM +0100, Diego Biurrun wrote: > miscellaneous minor changes and refactorings ping Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] [PATCH] configure: Simplify restrict keyword handling

Skip a variable indirection and only redefine restrict if necessary. --- Should still work on MSVC 2010 now as I don't kill the ugly workaround. configure | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/configure b/configure index 5684bddf9e..17acc98962 100755 ---

Re: [libav-devel] [PATCH 3/5] configure: Factorize check_64_bit()

On 11/3/2017 1:43 PM, Diego Biurrun wrote: > --- > > I'm assuming that the change for MIPS is safe. If you can't test it on a MIPS target, then it would be best to ask someone who can. It probably has its own special check for a reason. > > configure | 15 +++ > 1 file changed, 7

Re: [libav-devel] [PATCH 3/5] configure: Factorize check_64_bit()

On Fri, Nov 10, 2017 at 07:47:44PM +0100, Luca Barbato wrote: > On 03/11/2017 17:43, Diego Biurrun wrote: > > --- > > > > I'm assuming that the change for MIPS is safe. > > From what I recall of the many many ABIs of MIPS it should not. Can you elaborate, I'm not following .. Diego

Re: [libav-devel] [PATCH 2/5] configure: Coalesce some arch configuration and PIC handling

On 11/3/2017 1:43 PM, Diego Biurrun wrote: > --- > configure | 24 +++- > 1 file changed, 11 insertions(+), 13 deletions(-) > > diff --git a/configure b/configure > index 33c52240aa..169a6fa33f 100755 > --- a/configure > +++ b/configure > @@ -2595,6 +2595,7 @@

Re: [libav-devel] [PATCH 3/5] configure: Factorize check_64_bit()

On 03/11/2017 17:43, Diego Biurrun wrote: --- I'm assuming that the change for MIPS is safe. From what I recall of the many many ABIs of MIPS it should not. lu ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH] qsv/hevcdec: Load hw plugin by default on non-windows os

On 10/11/2017 09:03, Zhong Li wrote: Software plugin is not available on Linux, Only works on Windows. Similar changes have been applied to qsv hevc encoder by b05128f3c953bd66483e697d60a2e7e45ee9cfa0. Signed-off-by: Zhong Li --- libavcodec/qsvdec_h2645.c | 8 +++- 1

Re: [libav-devel] [PATCH] qsv/hevcdec: Load hw plugin by default on non-windows os

agree, will commit it shortly On Fri, Nov 10, 2017 at 7:43 PM, Luca Barbato wrote: > On 10/11/2017 09:03, Zhong Li wrote: > >> Software plugin is not available on Linux, Only works on Windows. >> Similar changes have been applied to qsv hevc encoder by >>

Re: [libav-devel] [PATCH 3/5] configure: Factorize check_64_bit()

On 10/11/2017 19:54, Diego Biurrun wrote: On Fri, Nov 10, 2017 at 07:47:44PM +0100, Luca Barbato wrote: On 03/11/2017 17:43, Diego Biurrun wrote: --- I'm assuming that the change for MIPS is safe. From what I recall of the many many ABIs of MIPS it should not. Can you elaborate, I'm not

Re: [libav-devel] [PATCH 1/2] smacker: add sanity check for length in smacker_decode_tree()

On Thu, Nov 9, 2017 at 9:28 AM, Diego Biurrun wrote: > On Thu, Nov 09, 2017 at 03:27:10PM +0100, Diego Biurrun wrote: >> On Wed, Nov 08, 2017 at 07:22:53PM -0500, Sean McGovern wrote: >> > --- a/libavcodec/smacker.c >> > +++ b/libavcodec/smacker.c >> > @@ -97,6 +97,11 @@ enum

[libav-devel] [PATCH] qsv/hevcdec: Load hw plugin by default on non-windows os

Software plugin is not available on Linux, Only works on Windows. Similar changes have been applied to qsv hevc encoder by b05128f3c953bd66483e697d60a2e7e45ee9cfa0. Signed-off-by: Zhong Li --- libavcodec/qsvdec_h2645.c | 8 +++- 1 file changed, 7 insertions(+), 1