It has native 8 and 10 bit support.
---
libavcodec/libx264.c | 30 ++
1 file changed, 30 insertions(+)
diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c
index 0dec12edd2..6aadf33c94 100644
--- a/libavcodec/libx264.c
+++ b/libavcodec/libx264.c
@@ -243,7 +243,11
On 12/26/2017 8:33 AM, Luca Barbato wrote:
> It has native 8 and 10 bit support.
> ---
> libavcodec/libx264.c | 30 ++
> 1 file changed, 30 insertions(+)
>
> diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c
> index 0dec12edd2..6aadf33c94 100644
> ---
James Almer (2017-12-26):
> > +#if X264_BUILD >= 155
> > +if (x4->params.i_bitdepth > 8)
> > +#else
> Wouldn't using av_pix_fmt_desc_get(avctx->pix_fmt)->comp[0].depth here
> as well be cleaner?
avctx->pix_fmt tells us what libavcodec wants; x4->params.i_bitdepth
tells us what x264 proposes;
On 26/12/2017 13:54, James Almer wrote:
You can still build libx264 with support for only 8 and 10 bits after
this multibitdepth change, so ideally you'd still check for what's
available based on X264_BIT_DEPTH and use the new enum array if it's 0.
I have a patch doing this but was waiting for
On 26/12/2017 22:34, James Almer wrote:
On 12/26/2017 11:39 AM, Luca Barbato wrote:
On 26/12/2017 13:54, James Almer wrote:
You can still build libx264 with support for only 8 and 10 bits after
this multibitdepth change, so ideally you'd still check for what's
available based on X264_BIT_DEPTH
On 26/12/2017 13:54, James Almer wrote:
Wouldn't using av_pix_fmt_desc_get(avctx->pix_fmt)->comp[0].depth here
as well be cleaner?
The two values must be the same and I prefer to use the shorter expression.
lu
___
libav-devel mailing list
On 12/26/2017 10:10 AM, Nicolas George wrote:
> James Almer (2017-12-26):
>>> +#if X264_BUILD >= 155
>>> +if (x4->params.i_bitdepth > 8)
>>> +#else
>
>> Wouldn't using av_pix_fmt_desc_get(avctx->pix_fmt)->comp[0].depth here
>> as well be cleaner?
>
> avctx->pix_fmt tells us what libavcodec
On 12/26/2017 11:39 AM, Luca Barbato wrote:
> On 26/12/2017 13:54, James Almer wrote:
>> You can still build libx264 with support for only 8 and 10 bits after
>> this multibitdepth change, so ideally you'd still check for what's
>> available based on X264_BIT_DEPTH and use the new enum array if
