Re: [libav-devel] [PATCH v2] qsv: enforcing continuous memory layout

2018-07-30 Thread Luca Barbato
On 30/07/2018 18:02, Maxym Dmytrychenko wrote: > we need to make sure that memory allocation for Y/UV planes is continuous and > re-used from a > pool > --- I'm afraid this would break the already-proper-frame codepath. I would simplify the default avcoded allocator and call it directly. >

Re: [libav-devel] [PATCH] qsv: enforcing continuous memory layout

2018-07-30 Thread Maxym Dmytrychenko
On Sun, Jul 29, 2018 at 7:38 PM Diego Biurrun wrote: > On Sun, Jul 29, 2018 at 12:50:42AM +0200, Maxym Dmytrychenko wrote: > > On Sat, Jul 28, 2018 at 12:20 PM Diego Biurrun wrote: > > > On Sat, Jul 28, 2018 at 10:53:54AM +0200, maxim_d33 wrote: > > > > --- > > > > libavcodec/qsvenc.c | 34

[libav-devel] [PATCH v2] qsv: enforcing continuous memory layout

2018-07-30 Thread Maxym Dmytrychenko
we need to make sure that memory allocation for Y/UV planes is continuous and re-used from a pool --- libavcodec/qsvenc.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c index e349a075f..c74b3ae31 100644 ---

Re: [libav-devel] [PATCH] qsv: enforcing continuous memory layout

2018-07-30 Thread Luca Barbato
On 30/07/2018 07:39, Li, Zhong wrote: > Could this make sure the reallocated aligned_frame is continuous memory? I made so it is in [libav-devel] [PATCH] frame: Simplify the video allocation. lu ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH] qsv: enforcing continuous memory layout

2018-07-30 Thread Luca Barbato
On 30/07/2018 07:39, Li, Zhong wrote: > If yes, I guess the best fix is not to making a copy (it will > introduce performance drop). Continuous layout is required by spec, > not only for qsv. Currently nothing prevents anybody to implement a frame allocator that does not respects that.

Re: [libav-devel] [PATCH v2] qsv: enforcing continuous memory layout

2018-07-30 Thread Rogozhkin, Dmitry V
On Mon, 2018-07-30 at 18:02 +0200, Maxym Dmytrychenko wrote: > we need to make sure that memory allocation for Y/UV planes is > continuous and re-used from a > pool Could you, please, be more explicit in the commit message otherwise we slip the discussion since not everyone here in the mailing