[libav-devel] [PATCH] Revert "decode: copy the output parameters from the last bsf in the chain back to the AVCodecContext"

2018-09-12 Thread James Almer
This reverts commit 662558f985f50834eebe82d6b6854c66f33ab320. The avcodec_parameters_to_context() call was freeing and reallocating AVCodecContext->extradata, essentially taking ownership of it, which according to the doxy is user owned. This is an API break and has produces crashes in some

[libav-devel] [PATCH] libfdk-aac: Don't use defined() in a #define

2018-09-12 Thread Martin Storsjö
MSVC expands the preprocessor directives differently, making the version check fail in the previous form. --- I'm pretty sure I've seen a better description of this issue somewhere, I don't remember off-hand right now where that was. But I think the gist of it was that the previous form was

Re: [libav-devel] [PATCH] libfdk-aac: Don't use defined() in a #define

2018-09-12 Thread Martin Storsjö
On Wed, 12 Sep 2018, Martin Storsjö wrote: MSVC expands the preprocessor directives differently, making the version check fail in the previous form. --- I'm pretty sure I've seen a better description of this issue somewhere, I don't remember off-hand right now where that was. But I think the