Re: [libav-devel] [PATCH 03/12] fate: yadif: add >8 bit tests

2016-10-22 Thread Janne Grunau 
On 2016-10-21 09:52:06 +0200, Anton Khirnov wrote:
> Quoting Janne Grunau (2016-10-16 20:10:53)
> > From: Christophe Gisquet 
> > 
> > Signed-off-by: Janne Grunau 
> > ---
> >  tests/fate/filter-video.mak   |  6 ++
> >  tests/ref/fate/filter-yadif10 | 31 +++
> >  tests/ref/fate/filter-yadif16 | 31 +++
> >  3 files changed, 68 insertions(+)
> >  create mode 100644 tests/ref/fate/filter-yadif10
> >  create mode 100644 tests/ref/fate/filter-yadif16
> > 
> > diff --git a/tests/fate/filter-video.mak b/tests/fate/filter-video.mak
> > index 82d0a62..a3effaa 100644
> > --- a/tests/fate/filter-video.mak
> > +++ b/tests/fate/filter-video.mak
> > @@ -7,6 +7,12 @@ fate-filter-yadif-mode0: CMD = framecrc -flags bitexact 
> > -idct simple -i $(TARGET
> >  FATE_YADIF += fate-filter-yadif-mode1
> >  fate-filter-yadif-mode1: CMD = framecrc -flags bitexact -idct simple -i 
> > $(TARGET_SAMPLES)/mpeg2/mpeg2_field_encoding.ts -vf yadif=1
> >  
> > +FATE_YADIF += fate-filter-yadif10
> > +fate-filter-yadif10: CMD = framecrc -flags bitexact -idct simple -i 
> > $(TARGET_SAMPLES)/mpeg2/mpeg2_field_encoding.ts -flags bitexact -pix_fmt 
> > yuv420p10le -vframes 30 -vf yadif=0
> > +
> > +FATE_YADIF += fate-filter-yadif16
> > +fate-filter-yadif16: CMD = framecrc -flags bitexact -idct simple -i 
> > $(TARGET_SAMPLES)/mpeg2/mpeg2_field_encoding.ts -flags bitexact -pix_fmt 
> > yuv420p16le -vframes 30 -vf yadif=0
> 
> This looks broken to me. -pix_fmt foo only makes sure the final output
> is in format foo, but makes no guarantees as to where exactly in the
> filtergraph the conversion happens. Testing this patch, it seems that
> the video is first deinterlaced as 8bit and then converted to 10/16bit.
> The right thing to do is drop -pix_fmt and use
> -vf format=yuv420p{10,16}le,yadif=0

I thought I checked that right asm actually runs but it can't since the 
framecrcs changed.
> 
> Also, change -vframes to -frames:v, this first one is
> obsolete/undocumented/unsupported syntax.

fixed, thanks

Janne
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 03/12] fate: yadif: add >8 bit tests

2016-10-21 Thread Anton Khirnov 
Quoting Janne Grunau (2016-10-16 20:10:53)
> From: Christophe Gisquet 
> 
> Signed-off-by: Janne Grunau 
> ---
>  tests/fate/filter-video.mak   |  6 ++
>  tests/ref/fate/filter-yadif10 | 31 +++
>  tests/ref/fate/filter-yadif16 | 31 +++
>  3 files changed, 68 insertions(+)
>  create mode 100644 tests/ref/fate/filter-yadif10
>  create mode 100644 tests/ref/fate/filter-yadif16
> 
> diff --git a/tests/fate/filter-video.mak b/tests/fate/filter-video.mak
> index 82d0a62..a3effaa 100644
> --- a/tests/fate/filter-video.mak
> +++ b/tests/fate/filter-video.mak
> @@ -7,6 +7,12 @@ fate-filter-yadif-mode0: CMD = framecrc -flags bitexact 
> -idct simple -i $(TARGET
>  FATE_YADIF += fate-filter-yadif-mode1
>  fate-filter-yadif-mode1: CMD = framecrc -flags bitexact -idct simple -i 
> $(TARGET_SAMPLES)/mpeg2/mpeg2_field_encoding.ts -vf yadif=1
>  
> +FATE_YADIF += fate-filter-yadif10
> +fate-filter-yadif10: CMD = framecrc -flags bitexact -idct simple -i 
> $(TARGET_SAMPLES)/mpeg2/mpeg2_field_encoding.ts -flags bitexact -pix_fmt 
> yuv420p10le -vframes 30 -vf yadif=0
> +
> +FATE_YADIF += fate-filter-yadif16
> +fate-filter-yadif16: CMD = framecrc -flags bitexact -idct simple -i 
> $(TARGET_SAMPLES)/mpeg2/mpeg2_field_encoding.ts -flags bitexact -pix_fmt 
> yuv420p16le -vframes 30 -vf yadif=0

This looks broken to me. -pix_fmt foo only makes sure the final output
is in format foo, but makes no guarantees as to where exactly in the
filtergraph the conversion happens. Testing this patch, it seems that
the video is first deinterlaced as 8bit and then converted to 10/16bit.
The right thing to do is drop -pix_fmt and use
-vf format=yuv420p{10,16}le,yadif=0

Also, change -vframes to -frames:v, this first one is
obsolete/undocumented/unsupported syntax.

-- 
Anton Khirnov
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 03/12] fate: yadif: add >8 bit tests

2016-10-20 Thread Diego Biurrun 
On Sun, Oct 16, 2016 at 08:10:53PM +0200, Janne Grunau wrote:
> From: Christophe Gisquet 
> 
> Signed-off-by: Janne Grunau 
> ---
>  tests/fate/filter-video.mak   |  6 ++
>  tests/ref/fate/filter-yadif10 | 31 +++
>  tests/ref/fate/filter-yadif16 | 31 +++
>  3 files changed, 68 insertions(+)
>  create mode 100644 tests/ref/fate/filter-yadif10
>  create mode 100644 tests/ref/fate/filter-yadif16

LGTM

Diego
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] [PATCH 03/12] fate: yadif: add >8 bit tests

2016-10-16 Thread Janne Grunau 
From: Christophe Gisquet 

Signed-off-by: Janne Grunau 
---
 tests/fate/filter-video.mak   |  6 ++
 tests/ref/fate/filter-yadif10 | 31 +++
 tests/ref/fate/filter-yadif16 | 31 +++
 3 files changed, 68 insertions(+)
 create mode 100644 tests/ref/fate/filter-yadif10
 create mode 100644 tests/ref/fate/filter-yadif16

diff --git a/tests/fate/filter-video.mak b/tests/fate/filter-video.mak
index 82d0a62..a3effaa 100644
--- a/tests/fate/filter-video.mak
+++ b/tests/fate/filter-video.mak
@@ -7,6 +7,12 @@ fate-filter-yadif-mode0: CMD = framecrc -flags bitexact -idct 
simple -i $(TARGET
 FATE_YADIF += fate-filter-yadif-mode1
 fate-filter-yadif-mode1: CMD = framecrc -flags bitexact -idct simple -i 
$(TARGET_SAMPLES)/mpeg2/mpeg2_field_encoding.ts -vf yadif=1
 
+FATE_YADIF += fate-filter-yadif10
+fate-filter-yadif10: CMD = framecrc -flags bitexact -idct simple -i 
$(TARGET_SAMPLES)/mpeg2/mpeg2_field_encoding.ts -flags bitexact -pix_fmt 
yuv420p10le -vframes 30 -vf yadif=0
+
+FATE_YADIF += fate-filter-yadif16
+fate-filter-yadif16: CMD = framecrc -flags bitexact -idct simple -i 
$(TARGET_SAMPLES)/mpeg2/mpeg2_field_encoding.ts -flags bitexact -pix_fmt 
yuv420p16le -vframes 30 -vf yadif=0
+
 FATE_FILTER-$(call FILTERDEMDEC, YADIF, MPEGTS, MPEG2VIDEO) += $(FATE_YADIF)
 
 FATE_SAMPLES_AVCONV += $(FATE_FILTER-yes)
diff --git a/tests/ref/fate/filter-yadif10 b/tests/ref/fate/filter-yadif10
new file mode 100644
index 000..e0731d7
--- /dev/null
+++ b/tests/ref/fate/filter-yadif10
@@ -0,0 +1,31 @@
+#tb 0: 1/18
+0,  64800,  64800,0,  1244160, 0x5b49e0c0
+0,  72000,  72000,0,  1244160, 0x76ba6bab
+0,  79200,  79200,0,  1244160, 0x0298cb8d
+0,  86400,  86400,0,  1244160, 0x9c81759a
+0,  93600,  93600,0,  1244160, 0xa239d1ae
+0, 100800, 100800,0,  1244160, 0x3e95ada9
+0, 108000, 108000,0,  1244160, 0x8b87e8f8
+0, 115200, 115200,0,  1244160, 0x64f89653
+0, 122400, 122400,0,  1244160, 0x58e5d12e
+0, 129600, 129600,0,  1244160, 0x38b4003a
+0, 136800, 136800,0,  1244160, 0xc005c29c
+0, 144000, 144000,0,  1244160, 0x10c0c60d
+0, 151200, 151200,0,  1244160, 0x1b550998
+0, 158400, 158400,0,  1244160, 0x7aacf6ab
+0, 165600, 165600,0,  1244160, 0xeb205d98
+0, 172800, 172800,0,  1244160, 0x6ad2134c
+0, 18, 18,0,  1244160, 0x8aea4e56
+0, 187200, 187200,0,  1244160, 0x0d910a6b
+0, 194400, 194400,0,  1244160, 0x749ae307
+0, 201600, 201600,0,  1244160, 0x8ff7af3c
+0, 208800, 208800,0,  1244160, 0x9ba51b91
+0, 216000, 216000,0,  1244160, 0xad476514
+0, 223200, 223200,0,  1244160, 0x674481d6
+0, 230400, 230400,0,  1244160, 0x0937e677
+0, 237600, 237600,0,  1244160, 0x6c2c53ee
+0, 244800, 244800,0,  1244160, 0x524a164e
+0, 252000, 252000,0,  1244160, 0x77a405ab
+0, 259200, 259200,0,  1244160, 0xaa6b47c4
+0, 266400, 266400,0,  1244160, 0x0b5ab556
+0, 273600, 273600,0,  1244160, 0xbe1edab9
diff --git a/tests/ref/fate/filter-yadif16 b/tests/ref/fate/filter-yadif16
new file mode 100644
index 000..964bfee
--- /dev/null
+++ b/tests/ref/fate/filter-yadif16
@@ -0,0 +1,31 @@
+#tb 0: 1/18
+0,  64800,  64800,0,  1244160, 0xc1d695eb
+0,  72000,  72000,0,  1244160, 0xaae3cd2f
+0,  79200,  79200,0,  1244160, 0xca5c8c9f
+0,  86400,  86400,0,  1244160, 0x00b423a3
+0,  93600,  93600,0,  1244160, 0x361ce808
+0, 100800, 100800,0,  1244160, 0x0c782e19
+0, 108000, 108000,0,  1244160, 0xf544f06a
+0, 115200, 115200,0,  1244160, 0x48b2b1fa
+0, 122400, 122400,0,  1244160, 0x82852e9e
+0, 129600, 129600,0,  1244160, 0xd2ac1cfe
+0, 136800, 136800,0,  1244160, 0x980dcdd8
+0, 144000, 144000,0,  1244160, 0x7b80b4f3
+0, 151200, 151200,0,  1244160, 0xe6d12ffd
+0, 158400, 158400,0,  1244160, 0x6e9af940
+0, 165600, 165600,0,  1244160, 0xdc57daf3
+0, 172800, 172800,0,  1244160, 0x064e2573
+0, 18, 18,0,  1244160, 0x72542128
+0, 187200, 187200,0,  1244160, 0xaa066272
+0, 194400, 194400,0,  1244160, 0xd1669204
+0, 201600, 201600,0,  1244160, 0x825871f9
+0, 208800, 208800,0,  1244160, 0xc2b65d67
+0, 216000, 216000,0,  1244160, 0x0e0f547b
+0, 223200, 223200,0,  1244160, 0x8d7880be
+0, 230400, 230400,