Re: [libav-devel] [PATCH 1/2] checkasm: Add a test for HEVC add_residual

2016-10-19 Thread Diego Biurrun
On Wed, Oct 19, 2016 at 10:18:07AM +0200, Diego Biurrun wrote: > --- /dev/null > +++ b/tests/checkasm/hevc_add_res.c > @@ -0,0 +1,84 @@ > +static void check_add_res(HEVCDSPContext h, int bit_depth) > +{ > +int i; > +LOCAL_ALIGNED(32, int16_t, res0, [32 * 32]); > +LOCAL_ALIGNED(32, int16

Re: [libav-devel] [PATCH 1/2] checkasm: Add a test for HEVC add_residual

2016-10-19 Thread Henrik Gramner
On Wed, Oct 19, 2016 at 5:43 PM, Diego Biurrun wrote: > What exactly segfaults? checkasm --bench=add_res The stride for bench_new() shouldn't be different from call_new() Actually it should probably be more like: int stride = block_size << (bit_depth > 8); call_ref(dst0, res0, stride);

Re: [libav-devel] [PATCH 1/2] checkasm: Add a test for HEVC add_residual

2016-10-19 Thread Diego Biurrun
On Wed, Oct 19, 2016 at 05:01:57PM +0200, Henrik Gramner wrote: > On Wed, Oct 19, 2016 at 10:18 AM, Diego Biurrun wrote: > > +bench_new(dst1, res1, block_size); > > Segfaults. Should probably be block_size * 2 like the other calls. What exactly segfaults? I get a complaint from clang

Re: [libav-devel] [PATCH 1/2] checkasm: Add a test for HEVC add_residual

2016-10-19 Thread Henrik Gramner
On Wed, Oct 19, 2016 at 10:18 AM, Diego Biurrun wrote: > +bench_new(dst1, res1, block_size); Segfaults. Should probably be block_size * 2 like the other calls. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailm

[libav-devel] [PATCH 1/2] checkasm: Add a test for HEVC add_residual

2016-10-19 Thread Diego Biurrun
From: Alexandra Hájková Signed-off-by: Diego Biurrun --- small cosmetics tests/checkasm/Makefile | 2 +- tests/checkasm/checkasm.c | 3 +- tests/checkasm/checkasm.h | 1 + tests/checkasm/hevc_add_res.c | 84 +++ 4 files changed, 88 inse

Re: [libav-devel] [PATCH 1/2] checkasm: Add a test for HEVC add_residual

2016-10-17 Thread Luca Barbato
On 17/10/2016 23:45, Martin Storsjö wrote: > So, what changed compared to the last version that Alexandra submitted > herself? Didn't we all agree that listing that is the least we can do, > when resubmitting someone (who is still active and present) else's patch > in a modified form. I changed wh

Re: [libav-devel] [PATCH 1/2] checkasm: Add a test for HEVC add_residual

2016-10-17 Thread Martin Storsjö
On Mon, 17 Oct 2016, Luca Barbato wrote: From: Alexandra Hájková --- tests/checkasm/Makefile | 2 +- tests/checkasm/checkasm.c | 1 + tests/checkasm/checkasm.h | 1 + tests/checkasm/hevc_add_res.c | 84 +++ 4 files changed, 87 insertions(+),

[libav-devel] [PATCH 1/2] checkasm: Add a test for HEVC add_residual

2016-10-17 Thread Luca Barbato
From: Alexandra Hájková --- tests/checkasm/Makefile | 2 +- tests/checkasm/checkasm.c | 1 + tests/checkasm/checkasm.h | 1 + tests/checkasm/hevc_add_res.c | 84 +++ 4 files changed, 87 insertions(+), 1 deletion(-) create mode 100644 test