On 16/09/16 14:50, Yogender Gupta wrote:
Thanks Diego, Luca. Will take care of your comments for the next
submissions. Few points based on your review :
1. We can keep the default as HQ only instead of medium (mapping of
medium is already to HQ), however we found of lot of people
comfortable
Bug fixes and behavior changes do not belong together with an API
update.
> -Original Message-
> From: libav-devel [mailto:libav-devel-boun...@libav.org] On Behalf Of Diego
> Biurrun
> Sent: Friday, September 16, 2016 1:27 AM
> To: libav development
> Subject: Re: [l
Subject: Re: [libav-devel] [Libav-devel][Patch] Patch for SDK 7 for NVENC
Some comments for next time as Luca said he wanted to take care of it.
Please try to maintain the style of the file you are working in.
> --- a/libavcodec/nvenc_hevc.c
> +++ b/libavcodec/nvenc_hevc.c
> @@ -27
Some comments for next time as Luca said he wanted to take care of it.
Please try to maintain the style of the file you are working in.
> --- a/libavcodec/nvenc_hevc.c
> +++ b/libavcodec/nvenc_hevc.c
> @@ -27,8 +27,11 @@
> #define VE AV_OPT_FLAG_VIDEO_PARAM | AV_OPT_FLAG_ENCODING_PARAM
> static
On 15/09/16 12:40, Yogender Gupta wrote:
> Attached is patch for SDK 7 for NVENC.
>
I'll need the weekend to update my system to try it, there are a couple
of style nits that I'll address while at it beside that seems fine.
Thanks a lot!
lu
___
