Re: [libav-devel] [PATCH] mmaldec: initialize refcount using atomic_init().

[Luca Barbato]

On 30/11/2016 20:52, Wan-Teh Chang wrote:
> This is how we initialize refcount in libavutil/buffer.c.
> 
> Signed-off-by: Wan-Teh Chang 
> ---
>  libavcodec/mmaldec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavcodec/mmaldec.c b/libavcodec/mmaldec.c
> index 924bfb2..e64ddba 100644
> --- a/libavcodec/mmaldec.c
> +++ b/libavcodec/mmaldec.c
> @@ -281,7 +281,7 @@ static int ffmal_update_format(AVCodecContext *avctx)
>  ret = AVERROR(ENOMEM);
>  goto fail;
>  }
> -atomic_store(&ctx->pool_out->refcount, 1);
> +atomic_init(&ctx->pool_out->refcount, 1);
>  
>  if (!format_out)
>  goto fail;
> 

Looks consistent, I just double checked

Thank you.
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] mmaldec: initialize refcount using atomic_init().

[Wan-Teh Chang]

I also noticed that |refcount| is declared as atomic_int in
libavcodec/mmaldec.c but declared as atomic_uint in
libavutil/buffer_internal.h. It would be nice to be consistent.

Wan-Teh Chang
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel