Re: [libav-devel] [PATCH] x86: Don't declare a non-static function as inline

2018-04-15 Thread Diego Biurrun
On Sat, Apr 14, 2018 at 10:40:26PM +0300, Martin Storsjö wrote: > This fixes building with clang in msvc mode, which does support > gcc style inline assembly. > --- > libavcodec/x86/xvididct_sse2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) probably OK Diego

Re: [libav-devel] [PATCH] x86: Don't declare a non-static function as inline

2018-04-14 Thread Martin Storsjö
On Sat, 14 Apr 2018, Diego Biurrun wrote: On Sat, Apr 14, 2018 at 01:38:30PM +0300, Martin Storsjö wrote: Make the actual implementation static inline, but add a non-static non-inline frontend for it. This fixes building with clang in msvc mode, which does support gcc style inline assembly.

Re: [libav-devel] [PATCH] x86: Don't declare a non-static function as inline

2018-04-14 Thread Diego Biurrun
On Sat, Apr 14, 2018 at 01:38:30PM +0300, Martin Storsjö wrote: > Make the actual implementation static inline, but add a non-static > non-inline frontend for it. > > This fixes building with clang in msvc mode, which does support > gcc style inline assembly. > ---

Re: [libav-devel] [PATCH] x86: Don't declare a non-static function as inline

2018-04-14 Thread Luca Barbato
On 14/04/2018 19:38, Martin Storsjö wrote: > Make the actual implementation static inline, but add a non-static > non-inline frontend for it. > > This fixes building with clang in msvc mode, which does support > gcc style inline assembly. > --- > libavcodec/x86/xvididct_sse2.c | 11 --- >