Re: [libav-devel] [PATCH 05/14] lavc: Add h264_metadata bitstream filter

2017-08-12 Thread Hendrik Leppkes 
On Sat, Aug 12, 2017 at 10:51 AM, Diego Biurrun  wrote:
> On Fri, Aug 11, 2017 at 12:37:00AM +0100, Mark Thompson wrote:
>> --- /dev/null
>> +++ b/libavcodec/h264_metadata_bsf.c
>> @@ -0,0 +1,511 @@
>> +
>> +typedef struct H264MetadataContext {
>> +const AVClass *class;
>
> Isn't the class member unused? Or did I just miss where this is used for 
> logging?
>

The priv_data of a BSF needs to have an AVClass member for AVOption support.

- Hendrik
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 05/14] lavc: Add h264_metadata bitstream filter

2017-08-12 Thread Diego Biurrun 
On Fri, Aug 11, 2017 at 12:37:00AM +0100, Mark Thompson wrote:
> --- /dev/null
> +++ b/libavcodec/h264_metadata_bsf.c
> @@ -0,0 +1,511 @@
> +
> +typedef struct H264MetadataContext {
> +const AVClass *class;

Isn't the class member unused? Or did I just miss where this is used for 
logging?

Diego
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel