Re: [libav-devel] [PATCH 1/3] avcodec: Document AV_PKT_DATA_PALETTE side data type

2016-09-21 Thread Anton Khirnov 
Quoting Vittorio Giovara (2016-09-20 23:11:14)
> On Tue, Sep 20, 2016 at 3:05 PM, Anton Khirnov  wrote:
> > Quoting Vittorio Giovara (2016-09-19 22:33:42)
> >> ---
> >>  libavcodec/avcodec.h | 3 +++
> >>  1 file changed, 3 insertions(+)
> >>
> >> diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
> >> index c863e53..840222c 100644
> >> --- a/libavcodec/avcodec.h
> >> +++ b/libavcodec/avcodec.h
> >> @@ -1190,6 +1190,9 @@ typedef struct AVCPBProperties {
> >>   * @{
> >>   */
> >>  enum AVPacketSideDataType {
> >> +/* An AV_PKT_DATA_PALETTE side data packet contains exactly 
> >> AVPALETTE_SIZE
> >
> > Needs an extra *
> >
> >> + * bytes worth of palette.
> >
> >> Usually the decoder needs to track its content
> >> + * and set palette_has_changed on the output frame when updated. */
> >
> > This part feels a bit too vague. I'd just say that this side data
> > signals a new palette to decoders and leave it at that.
> >
> > --
> > Anton Khirnov
> > ___
> > libav-devel mailing list
> > libav-devel@libav.org
> > https://lists.libav.org/mailman/listinfo/libav-devel
> 
> Would this be OK?

Yes, fine with me.

-- 
Anton Khirnov
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 1/3] avcodec: Document AV_PKT_DATA_PALETTE side data type

2016-09-20 Thread Vittorio Giovara 
On Tue, Sep 20, 2016 at 3:05 PM, Anton Khirnov  wrote:
> Quoting Vittorio Giovara (2016-09-19 22:33:42)
>> ---
>>  libavcodec/avcodec.h | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
>> index c863e53..840222c 100644
>> --- a/libavcodec/avcodec.h
>> +++ b/libavcodec/avcodec.h
>> @@ -1190,6 +1190,9 @@ typedef struct AVCPBProperties {
>>   * @{
>>   */
>>  enum AVPacketSideDataType {
>> +/* An AV_PKT_DATA_PALETTE side data packet contains exactly 
>> AVPALETTE_SIZE
>
> Needs an extra *
>
>> + * bytes worth of palette.
>
>> Usually the decoder needs to track its content
>> + * and set palette_has_changed on the output frame when updated. */
>
> This part feels a bit too vague. I'd just say that this side data
> signals a new palette to decoders and leave it at that.
>
> --
> Anton Khirnov
> ___
> libav-devel mailing list
> libav-devel@libav.org
> https://lists.libav.org/mailman/listinfo/libav-devel

Would this be OK?

---
 libavcodec/avcodec.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
index c863e53..840222c 100644
--- a/libavcodec/avcodec.h
+++ b/libavcodec/avcodec.h
@@ -1190,6 +1190,9 @@ typedef struct AVCPBProperties {
  * @{
  */
 enum AVPacketSideDataType {
+/** An AV_PKT_DATA_PALETTE side data packet contains exactly AVPALETTE_SIZE
+ * bytes worth of palette.This side data signals that a new
palette is preset. */
 AV_PKT_DATA_PALETTE,

 /**

--
2.10.0

-- 
Vittorio
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 1/3] avcodec: Document AV_PKT_DATA_PALETTE side data type

2016-09-20 Thread Anton Khirnov 
Quoting Vittorio Giovara (2016-09-19 22:33:42)
> ---
>  libavcodec/avcodec.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
> index c863e53..840222c 100644
> --- a/libavcodec/avcodec.h
> +++ b/libavcodec/avcodec.h
> @@ -1190,6 +1190,9 @@ typedef struct AVCPBProperties {
>   * @{
>   */
>  enum AVPacketSideDataType {
> +/* An AV_PKT_DATA_PALETTE side data packet contains exactly 
> AVPALETTE_SIZE

Needs an extra *

> + * bytes worth of palette.

> Usually the decoder needs to track its content
> + * and set palette_has_changed on the output frame when updated. */

This part feels a bit too vague. I'd just say that this side data
signals a new palette to decoders and leave it at that.

-- 
Anton Khirnov
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 1/3] avcodec: Document AV_PKT_DATA_PALETTE side data type

2016-09-20 Thread Luca Barbato 
On 19/09/16 22:33, Vittorio Giovara wrote:
> ---
>  libavcodec/avcodec.h | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h
> index c863e53..840222c 100644
> --- a/libavcodec/avcodec.h
> +++ b/libavcodec/avcodec.h
> @@ -1190,6 +1190,9 @@ typedef struct AVCPBProperties {
>   * @{
>   */
>  enum AVPacketSideDataType {
> +/* An AV_PKT_DATA_PALETTE side data packet contains exactly 
> AVPALETTE_SIZE
> + * bytes worth of palette. Usually the decoder needs to track its content
> + * and set palette_has_changed on the output frame when updated. */
>  AV_PKT_DATA_PALETTE,
>  
>  /**
> 

Sure.
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel