Re: [libav-devel] [PATCH 2/5] nvenc: Fix the low-latency preset order

2016-09-19 Thread Luca Barbato 
On 19/09/16 18:48, Vittorio Giovara wrote:
> On Sat, Sep 17, 2016 at 9:28 AM, Luca Barbato  wrote:
>> From: Yogender Gupta 
>>
>> Their order got swapped in SDK 7.
>> ---
>>  configure  | 4 ++--
>>  libavcodec/nvenc.c | 2 +-
>>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> Shouldn't we still support SDK 6?
> 

The SDK 7 requires the user to register and manually download a zip.

That might be mildly annoying compared to the sdk 6 (available
pre-packaged at least in Gentoo).

It requires a driver that at least on Gentoo is available since a while
(please correct me if I'm wrong, I just checked the version reported in
the website while downloading the sdk 7), so usage wise it isn't really
a roadblock IMHO.

We can either decide to bump version or have some ifdeffery in place to
support both.

Who wants to support SDK 6 could add some version-specific ifdefs on 4
and 5, remove the version check in configure and we should be done with
that.

lu
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 2/5] nvenc: Fix the low-latency preset order

2016-09-19 Thread Vittorio Giovara 
On Sat, Sep 17, 2016 at 9:28 AM, Luca Barbato  wrote:
> From: Yogender Gupta 
>
> Their order got swapped in SDK 7.
> ---
>  configure  | 4 ++--
>  libavcodec/nvenc.c | 2 +-
>  2 files changed, 3 insertions(+), 3 deletions(-)

Shouldn't we still support SDK 6?
-- 
Vittorio
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel