Re: [libav-devel] [PATCH 2/6] avio: avio_ prefix for url_exist().
On Thu, Apr 07, 2011 at 04:34:39PM -0400, Ronald S. Bultje wrote: Hi, On Thu, Apr 7, 2011 at 3:16 PM, Anton Khirnov an...@khirnov.net wrote: --- ffmpeg.c | 2 +- ffserver.c | 4 ++-- libavformat/avio.c | 6 +- libavformat/avio.h | 3 ++- libavformat/img2.c | 6 +++--- 5 files changed, 13 insertions(+), 8 deletions(-) Should this be public? I don't think it should. For local files, it's trivial to re-implement in each place where it's needed. Does it work for non-file://-URIs? It uses url_open, so I see no reason why it wouldn't. -- Anton Khirnov signature.asc Description: Digital signature ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 2/6] avio: avio_ prefix for url_exist().
Hi, On Thu, Apr 7, 2011 at 4:40 PM, Anton Khirnov an...@khirnov.net wrote: On Thu, Apr 07, 2011 at 04:34:39PM -0400, Ronald S. Bultje wrote: On Thu, Apr 7, 2011 at 3:16 PM, Anton Khirnov an...@khirnov.net wrote: --- ffmpeg.c | 2 +- ffserver.c | 4 ++-- libavformat/avio.c | 6 +- libavformat/avio.h | 3 ++- libavformat/img2.c | 6 +++--- 5 files changed, 13 insertions(+), 8 deletions(-) Should this be public? I don't think it should. For local files, it's trivial to re-implement in each place where it's needed. Does it work for non-file://-URIs? It uses url_open, so I see no reason why it wouldn't. I guess it's fine. I'm not very comfortable with it being in lavf but who am I to say it doesn't belong there if our top committer of the year thinks otherwise? :-). Ronald ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
Re: [libav-devel] [PATCH 2/6] avio: avio_ prefix for url_exist().
On Thu, Apr 07, 2011 at 09:50:28PM -0400, Ronald S. Bultje wrote: Hi, On Thu, Apr 7, 2011 at 4:40 PM, Anton Khirnov an...@khirnov.net wrote: On Thu, Apr 07, 2011 at 04:34:39PM -0400, Ronald S. Bultje wrote: On Thu, Apr 7, 2011 at 3:16 PM, Anton Khirnov an...@khirnov.net wrote: --- ffmpeg.c | 2 +- ffserver.c | 4 ++-- libavformat/avio.c | 6 +- libavformat/avio.h | 3 ++- libavformat/img2.c | 6 +++--- 5 files changed, 13 insertions(+), 8 deletions(-) Should this be public? I don't think it should. For local files, it's trivial to re-implement in each place where it's needed. Does it work for non-file://-URIs? It uses url_open, so I see no reason why it wouldn't. I guess it's fine. I'm not very comfortable with it being in lavf but who am I to say it doesn't belong there if our top committer of the year thinks otherwise? :-). See the first mail in the thread - I'm not exactly happy with it either. -- Anton Khirnov signature.asc Description: Digital signature ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel
