[Libcg-devel] [patch 35/41] libcgroup Test: libcgroup-split-new-cgroup-function

2008-11-26 Thread kumar
This patch splits the earlier created function new_cgroup() into two to make it more useful for other testcases. Signed-off-by: Sudhir Kumar<[EMAIL PROTECTED]> --- tests/libcgrouptest.h |2 + tests/libcgrouptest01.c | 65 +++- 2

[Libcg-devel] [patch 20/41] libcgroup Test: make-controller-use-generic-in-binary

2008-11-26 Thread kumar
set_controller() need to be updated with respect to the controllers and control file. The challenges yet to be solved are: (1)Choosing appropriate control file (2)Choosing appropriate control value dynamicaly. Thoughts are most welcome. Signed-off-by: Sudhir Kumar <[EMAIL PROTECTED]> ---

[Libcg-devel] [patch 32/41] libcgroup Test: fix-STRING-typo

2008-11-26 Thread kumar
Fixing a typo.(Bad effect of yy p :)) Signed-off-by: Sudhir Kumar<[EMAIL PROTECTED]> Index: test-devel/tests/libcgrouptest01.c === --- test-devel.orig/tests/libcgrouptest01.c +++ test-devel/tests/libcgrouptest01.c @@

[Libcg-devel] [patch 41/41] libcgroup Test:

2008-11-26 Thread kumar
Minor cleanups. Signed-off-by: Sudhir KUmar <[EMAIL PROTECTED]> Index: balbir-latest/tests/libcgrouptest01.c === --- balbir-latest.orig/tests/libcgrouptest01.c +++ balbir-latest/tests/libcgrouptest01.c @@ -214,9 +214,9 @@ in

[Libcg-devel] [patch 04/41] libcgroup Test: libcgrouptest-multimnt03

2008-11-26 Thread kumar
third calll we give the argument as a non existing group, so the return value should be ECGROUPNOTEXIST. Signed-off-by: Sudhir Kumar <[EMAIL PROTECTED]> Index: test-devel/tests/libcgrouptest01.c === --- test-devel.orig/tests/libcgr

[Libcg-devel] [patch 10/41] libcgroup Test: cleanup2

2008-11-26 Thread kumar
Hi, This patch does printf and other cleanups in second set of testcases. Signed-off-by: Sudhir Kumar <[EMAIL PROTECTED]> --- tests/libcgrouptest01.c | 144 1 file changed, 86 insertions(+), 58 deletions(-) Index: trunk/tests/libcgroup

[Libcg-devel] [patch 31/41] libcgroup Test: fix-modify_cgroup-failures-by-changing-cntl-values

2008-11-26 Thread kumar
function creation part is over. Signed-off-by: Sudhir Kumar<[EMAIL PROTECTED]> Index: test-devel/tests/libcgrouptest01.c === --- test-devel.orig/tests/libcgrouptest01.c +++ test-devel/tests/libcgrouptest01.c @@ -223,14 +

[Libcg-devel] [patch 18/41] libcgroup Test: put-commoncode-in-build-path-function

2008-11-26 Thread kumar
This patch puts the common code into a function build_path() and thus reduces lots of redundant lines of code. Signed-off-by: Sudhir Kumar <[EMAIL PROTECTED]> --- tests/libcgrouptest.h |2 tests/libcgrouptest01.c | 106 +--- 2 files c

[Libcg-devel] [patch 21/41] libcgroup Test: fix-typo-error-in-delete-cgroup

2008-11-26 Thread kumar
This patch fixes a testcase which was having some typo errors. (libcgroup api cgroup_delete_cgroup() for a common group in multiple mount scenario) Signed-off-by: Sudhir Kumar <[EMAIL PROTECTED]> Index: test-devel/tests/libcgroupte

[Libcg-devel] [patch 27/41] libcgroup Test: libcgroup-add-static-array-for-testcase-info-messages

2008-11-26 Thread kumar
main motto has been to avoid the global variables due to thread safety reasons. Signed-off-by: Sudhir Kumar<[EMAIL PROTECTED]> --- tests/libcgrouptest.h |9 tests/libcgrouptest01.c | 107 2 files changed, 116 insertions(+)

[Libcg-devel] [patch 28/41] libcgroup Test: libcgroup-create-function-for-init-api

2008-11-26 Thread kumar
the testing under all conditions. The advantage is that the code repetition has reduced now. Signed-off-by: Sudhir Kumar<[EMAIL PROTECTED]> Index: test-devel/tests/libcgrouptest.h === --- test-devel.orig/tests/libcgroup

[Libcg-devel] [patch 19/41] libcgroup Test: set-another-controller-if-first-fails

2008-11-26 Thread kumar
This patch adds a warning in case setting a controller fails and tries to set values for another controller. Signed-off-by: Sudhir Kumar <[EMAIL PROTECTED]> --- tests/libcgrouptest01.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) Index: trunk

[Libcg-devel] [patch 33/41] libcgroup Test: fix-modify_cgroup-bug-in-multimnt

2008-11-26 Thread kumar
this patch fixes the testcase for cgroup_modify_cgroup() multi mount. The second controller was not initialised to a value, so doing that. /me learns the bad effects of using global data structure :) Signed-off-by: Sudhir Kumar<[EMAIL PROTECTED]> Index: libcgroup-0.2/tests/libcgroup

[Libcg-devel] [patch 08/41] libcgroup Test: change subsyscheck logic in testscript

2008-11-26 Thread kumar
Hi The shell script as expected does not do a non null check using -n option as i observed. hence changing the logic as below. Signed-off-by: Sudhir Kumar <[EMAIL PROTECTED]> Index: test-devel/tests/runlibcgrouptest.sh === --

[Libcg-devel] [patch 40/41] libcgroup Test: add message

2008-11-26 Thread kumar
This patch fixes the NUM_MSGS error which was still 10, however there are more type of messages to be printed. It also adds the support to just print a new line in case there is no message to be printed. Signed-off-by: Sudhir Kumar <[EMAIL PROTECTED]> Index: balbir-latest/tests/libcgroup

[Libcg-devel] [patch 17/41] libcgroup Test: make-controller-check-generic

2008-11-26 Thread kumar
debug devices ns cpuacct cpuset Also what type of values can be written to those control files? I need to take care before i write something stupid to a control file. Please review the patch and give your valuable comments. Signed-off-by: Sudhir Kumar <[EMAIL PROTECTED]> ---

[Libcg-devel] [patch 26/41] libcgroup Test: libcgrouptest-fix-to-empty-extra-string-and-add-a-new-warning

2008-11-26 Thread kumar
Index: test-devel/tests/libcgrouptest01.c === --- test-devel.orig/tests/libcgrouptest01.c +++ test-devel/tests/libcgrouptest01.c @@ -635,6 +635,8 @@ int main(int argc, char *argv[]) else message(

[Libcg-devel] [patch 13/41] libcgroup Test: cleanup4

2008-11-26 Thread kumar
Hi, This patch does printf and other cleanups in third set of testcases. Signed-off-by: Sudhir Kumar <[EMAIL PROTECTED]> --- tests/libcgrouptest01.c | 263 1 file changed, 177 insertions(+), 86 deletions(-) Index: trunk/tests/libcgroup

[Libcg-devel] [patch 30/41] libcgroup Test: fix-newly-broken-test

2008-11-26 Thread kumar
The previous patch creating the function for attach_task() breaks a test case because of global data usage. This patch fixes that. (There will be functions corresponding to each API to test all the APIs) Signed-off-by: Sudhir Kumar<[EMAIL PROTECTED]> Index: test-devel

[Libcg-devel] [patch 14/41] libcgroup Test: add warnings

2008-11-26 Thread kumar
Hi, This patch adds some warnings in case some testcses fail. When we modify a group with nullcgroup then there is no need to check if values are changed. Signed-off-by: Sudhir Kumar <[EMAIL PROTECTED]> --- tests/libcgrouptest01.c | 22 +++--- 1 file changed, 15 inse

[Libcg-devel] [patch 22/41] libcgroup Test: libcgroup-attach_task-test-for-cmmongrp-multimnt

2008-11-26 Thread kumar
This patch adds a testcase for libcgroup api cgroup_attach_task() for a common group in multiple mount scenario. Signed-off-by: Sudhir Kumar <[EMAIL PROTECTED]> Index: test-devel/tests/libcgrouptest01.c === --- test-deve

[Libcg-devel] [patch 29/41] libcgroup Test: libcgroup-create-function-for-attach_task-api

2008-11-26 Thread kumar
which can handle the testing under all conditions. The advantage is that the test case becomes thread safe as all the variables are now declared on stack. The other benefit is that the code repetition has reduced now. Signed-off-by: Sudhir Kumar<[EMAIL PROTECTED]> --- tests/libcgroup

[Libcg-devel] [patch 09/41] libcgroup Test: cleanup1

2008-11-26 Thread kumar
Hi, This patch does cleanup in first set of testcases. It defines a new function to print test results. Signed-off-by: Sudhir Kumar <[EMAIL PROTECTED]> --- tests/libcgrouptest.h |9 ++ tests/libcgrouptest01.c | 71 +--- 2 files chang

[Libcg-devel] [patch 34/41] libcgroup Test: libcgrouptest-fix-cntlr-order-error-in-script

2008-11-26 Thread kumar
Sometimes on some machines, encounterd an issue of getting the controllers information in reverse order. So keeping the uniformity for future. Signed-off-by: Sudhir Kumar <[EMAIL PROTECTED]> Index: test-devel/tests/libcgroup

[Libcg-devel] [patch 02/41] libcgroup Test: libcgrouptest-multimnt01

2008-11-26 Thread kumar
ommon code in a function. Signed-off-by: Sudhir Kumar <[EMAIL PROTECTED]> --- tests/libcgrouptest.h |1 tests/libcgrouptest01.c | 76 2 files changed, 53 insertions(+), 24 deletions(-) Index: trunk/tests/libcgr

[Libcg-devel] [patch 12/41] libcgroup Test: fixed certain rejects

2008-11-26 Thread kumar
The following patch makes certain cleanups for the patchset to apply without any rejects. However the lines of code are being changed in one of the next patches. Signed-off-by: Sudhir Kumar <[EMAIL PROTECTED]> --- tests/libcgrouptest01.c |6 +++--- 1 file changed, 3 insertions

[Libcg-devel] [patch 38/41] libcgroup Test: address earlier comments

2008-11-26 Thread kumar
Removing the hard coding of control values using config file is under progress Signed-off-by: Sudhir Kumar <[EMAIL PROTECTED]> Index: balbir-latest/tests/libcgrouptest01.c === --- balbir-latest.orig/tests/libcgrouptest01.c

[Libcg-devel] [patch 05/41] libcgroup Test: libcgrouptest-multimnt04

2008-11-26 Thread kumar
ff-by: Sudhir Kumar <[EMAIL PROTECTED]> Index: test-devel/tests/libcgrouptest01.c === --- test-devel.orig/tests/libcgrouptest01.c +++ test-devel/tests/libcgrouptest01.c @@ -387,6 +387,8 @@ int main(int argc,

[Libcg-devel] [patch 01/41] libcgroup Test: multi-mount-script-enhanced

2008-11-26 Thread kumar
: Sudhir Kumar <[EMAIL PROTECTED]> Index: test-devel/tests/runlibcgrouptest.sh === --- test-devel.orig/tests/runlibcgrouptest.sh +++ test-devel/tests/runlibcgrouptest.sh @@ -15,57 +15,78 @@ # Description: This script runs the the basic

[Libcg-devel] [patch 06/41] libcgroup Test: libcgrouptest-multimnt05

2008-11-26 Thread kumar
Hi The following patch adds three testcases for libcg apis create and delete _cgroup() and wrapper apis for multiple mount case. The patch creates a valid cgroup structure with two controllers and after calling to apis performs a check under both controllers. Signed-off-by: Sudhir Kumar <[EM

[Libcg-devel] [patch 25/41] libcgroup Test: libcgroup-modify_cgroup-test3-for-multimnt

2008-11-26 Thread kumar
??? Signed-off-by: Sudhir Kumar <[EMAIL PROTECTED]> Index: test-devel/tests/libcgrouptest01.c === --- test-devel.orig/tests/libcgrouptest01.c +++ test-devel/tests/libcgrouptest01.c @@ -930,7 +930,73 @@ int main(int argc, char

[Libcg-devel] [patch 11/41] libcgroup Test: cleanup3

2008-11-26 Thread kumar
Hi, This patch does cleanups in test script. Signed-off-by: Sudhir Kumar <[EMAIL PROTECTED]> Index: test-devel/tests/libcgrouptest01.c Index: test-devel/tests/runlibcgrouptest.sh === --- test-devel.orig/tests/runlibcgroupt

[Libcg-devel] [patch 15/41] libcgroup Test: change test call

2008-11-26 Thread kumar
Hi, The api cgroup_modify_cgroup(cgroup1) had to be called before cgroup_modify_cgroup(cgroup2). This patch does that. Signed-off-by: Sudhir Kumar <[EMAIL PROTECTED]> --- tests/libcgrouptest01.c | 37 ++--- 1 file changed, 22 insertions(+), 15 del

[Libcg-devel] [patch 23/41] libcgroup Test: libcgroup-modify_cgroup-test1-for-multimnt

2008-11-26 Thread kumar
for that which will have the controller name, control file name and the control value. But not sure if there is any better approach. So thoughts ??? Signed-off-by: Sudhir Kumar <[EMAIL PROTECTED]> Index: test-devel/tests/libcgroupte

[Libcg-devel] [patch 16/41] libcgroup Test: libcgroup-attach_task-singlemount-testcase

2008-11-26 Thread kumar
Hi, This patch adds a testcase for cgroup_attach_task() api for single mount. Signed-off-by: Sudhir Kumar <[EMAIL PROTECTED]> --- tests/libcgrouptest01.c | 41 ++--- 1 file changed, 34 insertions(+), 7 deletions(-) Index: trunk/tests/libcgroupte

[Libcg-devel] [patch 03/41] libcgroup Test: libcgrouptest-multimnt02

2008-11-26 Thread kumar
ff-by: Sudhir Kumar <[EMAIL PROTECTED]> Index: test-devel/tests/libcgrouptest01.c === --- test-devel.orig/tests/libcgrouptest01.c +++ test-devel/tests/libcgrouptest01.c @@ -20,6 +20,9 @@ int main(int argc, char *argv[]) { int

[Libcg-devel] [patch 00/41] Patches for testcases against trunk

2008-11-26 Thread kumar
- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in th

[Libcg-devel] [patch 07/41] libcgroup Test: libcgrouptest-multimnt-sanitycheck

2008-11-26 Thread kumar
Hi The following patch adds the sanity check in c file for multiple mount case. The parameter passed to the function decides whether the check is for single mount or multiple mount. Signed-off-by: Sudhir Kumar <[EMAIL PROTECTED]> --- tests/libcgrouptest.h |2 +- tests/libcgroupte

[Libcg-devel] [patch 37/41] libcgroup Test: suppress-string-constant-warnings-in-compilation

2008-11-26 Thread kumar
The following patch removes the string to char * conversion warnings. Signed-off-by: Sudhir Kumar <[EMAIL PROTECTED]> Index: trunk/tests/libcgrouptest.h === --- trunk.orig/tests/libcgrouptest.h +++ trunk/tests/libcgroup

[Libcg-devel] [patch 36/41] libcgroup Test: change error value to be checked

2008-11-26 Thread kumar
Chanhe the error values as per the change in APIs Signed-off-by: Sudhir Kumar<[EMAIL PROTECTED]> Index: libcgroup-0.2/tests/libcgrouptest01.c === --- libcgroup-0.2.orig/tests/libcgrouptest01.c +++ libcgroup-0.2

[Libcg-devel] [patch 24/41] libcgroup Test: libcgroup-modify_cgroup-test2-for-multimnt

2008-11-26 Thread kumar
-by: Sudhir Kumar <[EMAIL PROTECTED]> Index: test-devel/tests/libcgrouptest01.c === --- test-devel.orig/tests/libcgrouptest01.c +++ test-devel/tests/libcgrouptest01.c @@ -749,7 +749,39 @@ int main(int argc, char

[Libcg-devel] [patch 39/41] libcgroup Test: change control value

2008-11-26 Thread kumar
This patch changes the control values to be written to control file. The write of value 700 to memory.limt_in_bytes resulted in a silent write of 764, because of which modify() test case was failing. Signed-off-by: Sudhir Kumar <[EMAIL PROTECTED]> Index: balbir-latest

[Libcg-devel] PATCH Catch the error if cgroup is already mounted

2008-11-28 Thread Sudhir Kumar
The following patch catches the error due to cgroup already mounted. For now return an error and later write the routine to be called. This routine will take a snapshot of the current state of mountpoint. unount the mountpoint and remount it. Signed-off-by: Sudhir Kumar <[EMAIL PROTEC

Re: [Libcg-devel] libcgroup: Revert makefile change

2008-11-28 Thread Sudhir Kumar
t Linux based applications with Moblin SDK & win great prizes > Grand prize is a trip for two to an Open Source event anywhere in the world > http://moblin-contest.org/redirect.php?banner_id=100&url=/ > ___ > Libcg-devel mailing list > Libcg-devel@l

Re: [Libcg-devel] PATCH Catch the error if cgroup is already mounted

2008-11-28 Thread Sudhir Kumar
On Sat, Nov 29, 2008 at 11:29:06AM +0530, Sudhir Kumar wrote: NACK. Sorry Did not do the right way. Will post the fresh patch soon > > The following patch catches the error due to cgroup already mounted. > For now return an error and later write the routine to be called. > This

[Libcg-devel] [PATCH] Corrected: Catch conf file mount failure and return new error

2008-11-28 Thread Sudhir Kumar
-by: Sudhir Kumar <[EMAIL PROTECTED]> Index: trunk/config.c === --- trunk.orig/config.c +++ trunk/config.c @@ -356,8 +356,16 @@ int cgroup_config_mount_fs() ret = mount(cgroup_filesystem, curr->path, cgroup_f

[Libcg-devel] [patch 40/41] libcgroup Test: add message

2008-11-30 Thread Sudhir Kumar
This patch fixes the NUM_MSGS error which was still 10, however there are more type of messages to be printed. It also adds the support to just print a new line in case there is no message to be printed. Signed-off-by: Sudhir Kumar <[EMAIL PROTECTED]> Index: balbir-latest/tests/libcgroup

[Libcg-devel] [patch 35/41] libcgroup Test: libcgroup-split-new-cgroup-function

2008-11-30 Thread Sudhir Kumar
This patch splits the earlier created function new_cgroup() into two to make it more useful for other testcases. Signed-off-by: Sudhir Kumar<[EMAIL PROTECTED]> --- tests/libcgrouptest.h |2 + tests/libcgrouptest01.c | 65 +++- 2

[Libcg-devel] [patch 24/41] libcgroup Test: libcgroup-modify_cgroup-test2-for-multimnt

2008-11-30 Thread Sudhir Kumar
-by: Sudhir Kumar <[EMAIL PROTECTED]> Index: test-devel/tests/libcgrouptest01.c === --- test-devel.orig/tests/libcgrouptest01.c +++ test-devel/tests/libcgrouptest01.c @@ -749,7 +749,39 @@ int main(int argc, char

[Libcg-devel] [patch 37/41] libcgroup Test: suppress-string-constant-warnings-in-compilation

2008-11-30 Thread Sudhir Kumar
The following patch removes the string to char * conversion warnings. Signed-off-by: Sudhir Kumar <[EMAIL PROTECTED]> Index: trunk/tests/libcgrouptest.h === --- trunk.orig/tests/libcgrouptest.h +++ trunk/tests/libcgroup

[Libcg-devel] [patch 08/41] libcgroup Test: change subsyscheck logic in testscript

2008-11-30 Thread Sudhir Kumar
Hi The shell script as expected does not do a non null check using -n option as i observed. hence changing the logic as below. Signed-off-by: Sudhir Kumar <[EMAIL PROTECTED]> Index: test-devel/tests/runlibcgrouptest.sh === --

[Libcg-devel] [patch 02/41] libcgroup Test: libcgrouptest-multimnt01

2008-11-30 Thread Sudhir Kumar
ommon code in a function. Signed-off-by: Sudhir Kumar <[EMAIL PROTECTED]> --- tests/libcgrouptest.h |1 tests/libcgrouptest01.c | 76 2 files changed, 53 insertions(+), 24 deletions(-) Index: trunk/tests/libcgr

[Libcg-devel] [patch 38/41] libcgroup Test: address earlier comments

2008-11-30 Thread Sudhir Kumar
Removing the hard coding of control values using config file is under progress Signed-off-by: Sudhir Kumar <[EMAIL PROTECTED]> Index: balbir-latest/tests/libcgrouptest01.c === --- balbir-latest.orig/tests/libcgrouptest01.c

[Libcg-devel] [patch 26/41] libcgroup Test: libcgrouptest-fix-to-empty-extra-string-and-add-a-new-warning

2008-11-30 Thread Sudhir Kumar
Index: test-devel/tests/libcgrouptest01.c === --- test-devel.orig/tests/libcgrouptest01.c +++ test-devel/tests/libcgrouptest01.c @@ -635,6 +635,8 @@ int main(int argc, char *argv[]) else message(

[Libcg-devel] [patch 41/41] libcgroup Test:

2008-11-30 Thread Sudhir Kumar
Minor cleanups. Signed-off-by: Sudhir KUmar <[EMAIL PROTECTED]> Index: balbir-latest/tests/libcgrouptest01.c === --- balbir-latest.orig/tests/libcgrouptest01.c +++ balbir-latest/tests/libcgrouptest01.c @@ -214,9 +214,9 @@ in

[Libcg-devel] [patch 12/41] libcgroup Test: fixed certain rejects

2008-11-30 Thread Sudhir Kumar
The following patch makes certain cleanups for the patchset to apply without any rejects. However the lines of code are being changed in one of the next patches. Signed-off-by: Sudhir Kumar <[EMAIL PROTECTED]> --- tests/libcgrouptest01.c |6 +++--- 1 file changed, 3 insertions

[Libcg-devel] [patch 21/41] libcgroup Test: fix-typo-error-in-delete-cgroup

2008-11-30 Thread Sudhir Kumar
This patch fixes a testcase which was having some typo errors. (libcgroup api cgroup_delete_cgroup() for a common group in multiple mount scenario) Signed-off-by: Sudhir Kumar <[EMAIL PROTECTED]> Index: test-devel/tests/libcgroupte

[Libcg-devel] [patch 30/41] libcgroup Test: fix-newly-broken-test

2008-11-30 Thread Sudhir Kumar
The previous patch creating the function for attach_task() breaks a test case because of global data usage. This patch fixes that. (There will be functions corresponding to each API to test all the APIs) Signed-off-by: Sudhir Kumar<[EMAIL PROTECTED]> Index: test-devel

[Libcg-devel] [patch 07/41] libcgroup Test: libcgrouptest-multimnt-sanitycheck

2008-11-30 Thread Sudhir Kumar
Hi The following patch adds the sanity check in c file for multiple mount case. The parameter passed to the function decides whether the check is for single mount or multiple mount. Signed-off-by: Sudhir Kumar <[EMAIL PROTECTED]> --- tests/libcgrouptest.h |2 +- tests/libcgroupte

[Libcg-devel] [patch 23/41] libcgroup Test: libcgroup-modify_cgroup-test1-for-multimnt

2008-11-30 Thread Sudhir Kumar
for that which will have the controller name, control file name and the control value. But not sure if there is any better approach. So thoughts ??? Signed-off-by: Sudhir Kumar <[EMAIL PROTECTED]> Index: test-devel/tests/libcgroupte

[Libcg-devel] [patch 18/41] libcgroup Test: put-commoncode-in-build-path-function

2008-11-30 Thread Sudhir Kumar
This patch puts the common code into a function build_path() and thus reduces lots of redundant lines of code. Signed-off-by: Sudhir Kumar <[EMAIL PROTECTED]> --- tests/libcgrouptest.h |2 tests/libcgrouptest01.c | 106 +--- 2 files c

[Libcg-devel] [patch 13/41] libcgroup Test: cleanup4

2008-11-30 Thread Sudhir Kumar
Hi, This patch does printf and other cleanups in third set of testcases. Signed-off-by: Sudhir Kumar <[EMAIL PROTECTED]> --- tests/libcgrouptest01.c | 263 1 file changed, 177 insertions(+), 86 deletions(-) Index: trunk/tests/libcgroup

[Libcg-devel] [patch 16/41] libcgroup Test: libcgroup-attach_task-singlemount-testcase

2008-11-30 Thread Sudhir Kumar
Hi, This patch adds a testcase for cgroup_attach_task() api for single mount. Signed-off-by: Sudhir Kumar <[EMAIL PROTECTED]> --- tests/libcgrouptest01.c | 41 ++--- 1 file changed, 34 insertions(+), 7 deletions(-) Index: trunk/tests/libcgroupte

[Libcg-devel] [patch 34/41] libcgroup Test: libcgrouptest-fix-cntlr-order-error-in-script

2008-11-30 Thread Sudhir Kumar
Sometimes on some machines, encounterd an issue of getting the controllers information in reverse order. So keeping the uniformity for future. Signed-off-by: Sudhir Kumar <[EMAIL PROTECTED]> Index: test-devel/tests/libcgroup

[Libcg-devel] [patch 33/41] libcgroup Test: fix-modify_cgroup-bug-in-multimnt

2008-11-30 Thread Sudhir Kumar
this patch fixes the testcase for cgroup_modify_cgroup() multi mount. The second controller was not initialised to a value, so doing that. /me learns the bad effects of using global data structure :) Signed-off-by: Sudhir Kumar<[EMAIL PROTECTED]> Index: libcgroup-0.2/tests/libcgroup

[Libcg-devel] [patch 14/41] libcgroup Test: add warnings

2008-11-30 Thread Sudhir Kumar
Hi, This patch adds some warnings in case some testcses fail. When we modify a group with nullcgroup then there is no need to check if values are changed. Signed-off-by: Sudhir Kumar <[EMAIL PROTECTED]> --- tests/libcgrouptest01.c | 22 +++--- 1 file changed, 15 inse

[Libcg-devel] [patch 22/41] libcgroup Test: libcgroup-attach_task-test-for-cmmongrp-multimnt

2008-11-30 Thread Sudhir Kumar
This patch adds a testcase for libcgroup api cgroup_attach_task() for a common group in multiple mount scenario. Signed-off-by: Sudhir Kumar <[EMAIL PROTECTED]> Index: test-devel/tests/libcgrouptest01.c === --- test-deve

[Libcg-devel] [patch 31/41] libcgroup Test: fix-modify_cgroup-failures-by-changing-cntl-values

2008-11-30 Thread Sudhir Kumar
function creation part is over. Signed-off-by: Sudhir Kumar<[EMAIL PROTECTED]> Index: test-devel/tests/libcgrouptest01.c === --- test-devel.orig/tests/libcgrouptest01.c +++ test-devel/tests/libcgrouptest01.c @@ -223,14 +

[Libcg-devel] [patch 28/41] libcgroup Test: libcgroup-create-function-for-init-api

2008-11-30 Thread Sudhir Kumar
the testing under all conditions. The advantage is that the code repetition has reduced now. Signed-off-by: Sudhir Kumar<[EMAIL PROTECTED]> Index: test-devel/tests/libcgrouptest.h === --- test-devel.orig/tests/libcgroup

[Libcg-devel] [patch 01/41] libcgroup Test: multi-mount-script-enhanced

2008-11-30 Thread Sudhir Kumar
: Sudhir Kumar <[EMAIL PROTECTED]> Index: test-devel/tests/runlibcgrouptest.sh === --- test-devel.orig/tests/runlibcgrouptest.sh +++ test-devel/tests/runlibcgrouptest.sh @@ -15,57 +15,78 @@ # Description: This script runs the the basic

[Libcg-devel] [patch 32/41] libcgroup Test: fix-STRING-typo

2008-11-30 Thread Sudhir Kumar
Fixing a typo.(Bad effect of yy p :)) Signed-off-by: Sudhir Kumar<[EMAIL PROTECTED]> Index: test-devel/tests/libcgrouptest01.c === --- test-devel.orig/tests/libcgrouptest01.c +++ test-devel/tests/libcgrouptest01.c @@

[Libcg-devel] [patch 36/41] libcgroup Test: change error value to be checked

2008-11-30 Thread Sudhir Kumar
Chanhe the error values as per the change in APIs Signed-off-by: Sudhir Kumar<[EMAIL PROTECTED]> Index: libcgroup-0.2/tests/libcgrouptest01.c === --- libcgroup-0.2.orig/tests/libcgrouptest01.c +++ libcgroup-0.2

[Libcg-devel] [patch 06/41] libcgroup Test: libcgrouptest-multimnt05

2008-11-30 Thread Sudhir Kumar
Hi The following patch adds three testcases for libcg apis create and delete _cgroup() and wrapper apis for multiple mount case. The patch creates a valid cgroup structure with two controllers and after calling to apis performs a check under both controllers. Signed-off-by: Sudhir Kumar <[EM

[Libcg-devel] [patch 20/41] libcgroup Test: make-controller-use-generic-in-binary

2008-11-30 Thread Sudhir Kumar
set_controller() need to be updated with respect to the controllers and control file. The challenges yet to be solved are: (1)Choosing appropriate control file (2)Choosing appropriate control value dynamicaly. Thoughts are most welcome. Signed-off-by: Sudhir Kumar <[EMAIL PROTECTED]> ---

[Libcg-devel] [patch 27/41] libcgroup Test: libcgroup-add-static-array-for-testcase-info-messages

2008-11-30 Thread Sudhir Kumar
main motto has been to avoid the global variables due to thread safety reasons. Signed-off-by: Sudhir Kumar<[EMAIL PROTECTED]> --- tests/libcgrouptest.h |9 tests/libcgrouptest01.c | 107 2 files changed, 116 insertions(+)

[Libcg-devel] [patch 25/41] libcgroup Test: libcgroup-modify_cgroup-test3-for-multimnt

2008-11-30 Thread Sudhir Kumar
??? Signed-off-by: Sudhir Kumar <[EMAIL PROTECTED]> Index: test-devel/tests/libcgrouptest01.c === --- test-devel.orig/tests/libcgrouptest01.c +++ test-devel/tests/libcgrouptest01.c @@ -930,7 +930,73 @@ int main(int argc, char

[Libcg-devel] [patch 04/41] libcgroup Test: libcgrouptest-multimnt03

2008-11-30 Thread Sudhir Kumar
third calll we give the argument as a non existing group, so the return value should be ECGROUPNOTEXIST. Signed-off-by: Sudhir Kumar <[EMAIL PROTECTED]> Index: test-devel/tests/libcgrouptest01.c === --- test-devel.orig/tests/libcgr

[Libcg-devel] [patch 17/41] libcgroup Test: make-controller-check-generic

2008-11-30 Thread Sudhir Kumar
debug devices ns cpuacct cpuset Also what type of values can be written to those control files? I need to take care before i write something stupid to a control file. Please review the patch and give your valuable comments. Signed-off-by: Sudhir Kumar <[EMAIL PROTECTED]> ---

[Libcg-devel] [patch 39/41] libcgroup Test: change control value

2008-11-30 Thread Sudhir Kumar
This patch changes the control values to be written to control file. The write of value 700 to memory.limt_in_bytes resulted in a silent write of 764, because of which modify() test case was failing. Signed-off-by: Sudhir Kumar <[EMAIL PROTECTED]> Index: balbir-latest

[Libcg-devel] [patch 03/41] libcgroup Test: libcgrouptest-multimnt02

2008-11-30 Thread Sudhir Kumar
ff-by: Sudhir Kumar <[EMAIL PROTECTED]> Index: test-devel/tests/libcgrouptest01.c === --- test-devel.orig/tests/libcgrouptest01.c +++ test-devel/tests/libcgrouptest01.c @@ -20,6 +20,9 @@ int main(int argc, char *argv[]) { int

[Libcg-devel] [patch 15/41] libcgroup Test: change test call

2008-11-30 Thread Sudhir Kumar
Hi, The api cgroup_modify_cgroup(cgroup1) had to be called before cgroup_modify_cgroup(cgroup2). This patch does that. Signed-off-by: Sudhir Kumar <[EMAIL PROTECTED]> --- tests/libcgrouptest01.c | 37 ++--- 1 file changed, 22 insertions(+), 15 del

[Libcg-devel] [patch 11/41] libcgroup Test: cleanup3

2008-11-30 Thread Sudhir Kumar
Hi, This patch does cleanups in test script. Signed-off-by: Sudhir Kumar <[EMAIL PROTECTED]> Index: test-devel/tests/libcgrouptest01.c Index: test-devel/tests/runlibcgrouptest.sh === --- test-devel.orig/tests/runlibcgroupt

[Libcg-devel] [patch 19/41] libcgroup Test: set-another-controller-if-first-fails

2008-11-30 Thread Sudhir Kumar
This patch adds a warning in case setting a controller fails and tries to set values for another controller. Signed-off-by: Sudhir Kumar <[EMAIL PROTECTED]> --- tests/libcgrouptest01.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) Index: trunk

[Libcg-devel] [patch 05/41] libcgroup Test: libcgrouptest-multimnt04

2008-11-30 Thread Sudhir Kumar
ff-by: Sudhir Kumar <[EMAIL PROTECTED]> Index: test-devel/tests/libcgrouptest01.c === --- test-devel.orig/tests/libcgrouptest01.c +++ test-devel/tests/libcgrouptest01.c @@ -387,6 +387,8 @@ int main(int argc,

[Libcg-devel] [patch 10/41] libcgroup Test: cleanup2

2008-11-30 Thread Sudhir Kumar
Hi, This patch does printf and other cleanups in second set of testcases. Signed-off-by: Sudhir Kumar <[EMAIL PROTECTED]> --- tests/libcgrouptest01.c | 144 1 file changed, 86 insertions(+), 58 deletions(-) Index: trunk/tests/libcgroup

[Libcg-devel] [patch 09/41] libcgroup Test: cleanup1

2008-11-30 Thread Sudhir Kumar
Hi, This patch does cleanup in first set of testcases. It defines a new function to print test results. Signed-off-by: Sudhir Kumar <[EMAIL PROTECTED]> --- tests/libcgrouptest.h |9 ++ tests/libcgrouptest01.c | 71 +--- 2 files chang

[Libcg-devel] [patch 29/41] libcgroup Test: libcgroup-create-function-for-attach_task-api

2008-11-30 Thread Sudhir Kumar
which can handle the testing under all conditions. The advantage is that the test case becomes thread safe as all the variables are now declared on stack. The other benefit is that the code repetition has reduced now. Signed-off-by: Sudhir Kumar<[EMAIL PROTECTED]> --- tests/libcgroup

[Libcg-devel] [patch 00/41] Testcases against trunk (email corrected)

2008-11-30 Thread Sudhir Kumar
- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in th

Re: [Libcg-devel] [PATCH][FIX]: Compilation failed

2008-12-14 Thread Sudhir Kumar
ARGET) > The Makefile in the current way is not correct however. Instead of linking to the library from the upper folder it should link from the standard system path. I will fix it in sometime. Rishi, Did you do a make install in upper dir

[Libcg-devel] [patch 12/14] test for cgroup_add/free_controller _

2008-12-18 Thread Sudhir Kumar
This patch adds testcases for cgroup_add_controller() wrapper api. Signed-off-by: Sudhir Kumar Index: trunk/tests/libcgrouptest01.c === --- trunk.orig/tests/libcgrouptest01.c +++ trunk/tests/libcgrouptest01.c @@ -133,6 +133,8

[Libcg-devel] [patch 03/14] create function for cgroup_new_cgroup

2008-12-18 Thread Sudhir Kumar
being used. I have fixed that in the dame patch to maintain uniformity as this is a single line fix only and is well commented in the code. Signed-off-by: Sudhir Kumar Index: trunk/tests/libcgrouptest01.c === --- trunk.orig/tests

[Libcg-devel] [patch 07/14] create function for cgroup_delete_cgroup

2008-12-18 Thread Sudhir Kumar
-off-by: Sudhir Kumar Index: trunk/tests/libcgrouptest.h === --- trunk.orig/tests/libcgrouptest.h +++ trunk/tests/libcgrouptest.h @@ -87,6 +87,8 @@ struct cgroup *get_new_cgroup_ds(int ctl

[Libcg-devel] [patch 06/14] create function for cgroup_create_cgroup

2008-12-18 Thread Sudhir Kumar
other apis. Signed-off-by: Sudhir Kumar Index: balbir-latest/tests/libcgrouptest01.c === --- balbir-latest.orig/tests/libcgrouptest01.c +++ balbir-latest/tests/libcgrouptest01.c @@ -114,11 +114,8 @@ int main(int argc, char *argv

[Libcg-devel] [patch 09/14] replace numbers by meaningful macros

2008-12-18 Thread Sudhir Kumar
This patch replaces the magic numbers from the info messages with the corresponding meaningful enums. Signed-off-by: Sudhir Kumar Index: trunk/tests/libcgrouptest.h === --- trunk.orig/tests/libcgrouptest.h +++ trunk/tests

[Libcg-devel] [patch 14/14] tetscase for cgroup_get/set_* wrappers

2008-12-18 Thread Sudhir Kumar
This patch adds testcases for different cgroup get_*, set_* wrapper apis. Since the apis are quite small so added the test for them in the same patch. Signed-off-by: sudhir Kumar Index: trunk/tests/libcgrouptest.h

[Libcg-devel] [patch 08/14] create function for cgroup_modify_cgroup

2008-12-18 Thread Sudhir Kumar
This patch creates the function test_cgroup_modify_cgroup(), to modify a group in fs, and this way eliminates lot of redundant code. This patch however may mesh up the numbering of testcases, which will be cleaned up in a later patch. Signed-off-by: Sudhir Kumar Index: balbir-latest/tests

[Libcg-devel] [patch 13/14] temp patch for libcgroup code to run the testcase

2008-12-18 Thread Sudhir Kumar
The following patch fixes the defect #2338181 on sourceforge.net. However this is not the updated fix, but it helps in running the test as the fix will be merged in the next release. Signed-off-by: Sudhir Kumar Index: trunk/libcgroup.h

[Libcg-devel] [patch 11/14] test for cgroup_get_cgroup

2008-12-18 Thread Sudhir Kumar
. Signed-off-by: Sudhir Kumar Index: trunk/tests/libcgrouptest01.c === --- trunk.orig/tests/libcgrouptest01.c +++ trunk/tests/libcgrouptest01.c @@ -295,9 +295,10 @@ int main(int argc, char *argv[]) * filesystem. Read it

[Libcg-devel] [patch 00/14] last set of libcgroup api testcases

2008-12-18 Thread Sudhir Kumar
The coming patchset generates the functions corresponding to testing each api. It does some cleanup as well. Testcases are neat and clean now. -- Regards Sudhir Kumar Linux Technology Center IBM, India. -- SF.Net email

[Libcg-devel] [patch 01/14] libcgroup testcases for compare_cgroup

2008-12-18 Thread Sudhir Kumar
This patch adds a testcase for cgroup_compare_cgroup() wrapper. Signed-off-by: Sudhir Kumar Index: balbir-latest/tests/libcgrouptest.h === --- balbir-latest.orig/tests/libcgrouptest.h +++ balbir-latest/tests/libcgrouptest.h

  1   2   >