Re: libecb patch: fix compile warnings on gcc-llvm 4.2.1 (OS X 10.6 with Xcode 4)

2011-12-09 Thread Marc Lehmann
On Thu, Dec 08, 2011 at 11:18:44PM +0100, Hongli Lai hon...@phusion.nl wrote: hmm, I am curious, what kind of warnings are these? hmm, these are harmless and can be ignored, and possibly switched off if they are a nuisance. I don't know whether it's fully implemented, but everything that

Re: libecb patch: fix compile warnings on gcc-llvm 4.2.1 (OS X 10.6 with Xcode 4)

2011-12-08 Thread Marc Lehmann
On Thu, Dec 08, 2011 at 09:46:24PM +0100, Hongli Lai hon...@phusion.nl wrote: ecb.h currently generates tons of warnings on gcc-llvm 4.2.1 (OS X hmm, I am curious, what kind of warnings are these? This causes ecb.h to think that __attribute__ and other gcc extension keywords are not supported

Re: libecb patch: fix compile warnings on gcc-llvm 4.2.1 (OS X 10.6 with Xcode 4)

2011-12-08 Thread Brandon Black
On Thu, Dec 8, 2011 at 4:18 PM, Hongli Lai hon...@phusion.nl wrote: I don't know whether it's fully implemented, but everything that ecb.h uses *is* fully implemented in llvm-gcc 4.2.1. This is pretty huge because Xcode 4 now uses llvm-gcc as the default gcc so all OS X users will get these

Re: libecb patch: fix compile warnings on gcc-llvm 4.2.1 (OS X 10.6 with Xcode 4)

2011-12-08 Thread Hongli Lai
On Thu, Dec 8, 2011 at 11:26 PM, Brandon Black blbl...@gmail.com wrote: I doubt they're actually fully implemented in OSX's llvm-gcc 4.2.1.  Do you have any supporting documentation or research on that? All I know is that they compile and that they seem to have effect. Are you saying that the

Re: libecb patch: fix compile warnings on gcc-llvm 4.2.1 (OS X 10.6 with Xcode 4)

2011-12-08 Thread Hongli Lai
Here's a new patch should be less invasive than the last one. The new approach is as follows: - Introduced an ECB_REAL_GCC macro which tells us whether the GCC is the real one or another implementation just claiming to be GCC. llvm-gcc is not considered to be real. - Introduced an