Re: [Libevent-users] [PATCH] epoll.c: epoll_dispatch() clarity/simplification/branch reduction cleanups

2007-11-09 Thread Nick Mathewson
On Fri, Nov 09, 2007 at 02:27:07AM -0800, Christopher Layne wrote: Regress checks out OK with both -O0 and -Os. Both size are with -O0. $ size .libs/libevent-1.4.so.2 textdata bss dec hex filename 9373510887084 101907 18e13 .libs/libevent-1.4.so.2 $ size

Re: [Libevent-users] [PATCH] signal.c, evsignal.h: properly save/restore previous signal handlers and fix memory stomp

2007-11-09 Thread Scott Lamb
Christopher Layne wrote: + /* save previous handler setup */ + if (sigaction(evsignal, NULL, sig-sa_old[evsignal]) == -1 + || sigaction(evsignal, sa, NULL) == -1) Not worth changing unless you're redoing the patch anyway, but is there some reason you aren't doing

Re: [Libevent-users] [PATCH] signal.c, evsignal.h: properly save/restore previous signal handlers and fix memory stomp

2007-11-09 Thread Christopher Layne
On Fri, Nov 09, 2007 at 04:03:46PM -0800, Scott Lamb wrote: Christopher Layne wrote: +/* save previous handler setup */ +if (sigaction(evsignal, NULL, sig-sa_old[evsignal]) == -1 +|| sigaction(evsignal, sa, NULL) == -1) Not worth changing unless you're redoing the patch

Re: [Libevent-users] latest libev eventxx fixes [was libev-1.3e ...]

2007-11-09 Thread Leandro Lucarella
Chris Brody, el 10 de noviembre a las 00:02 me escribiste: First, I would like to make a happy report that I just got the latest eventxx libev fixes (patching the latest cvs fixes into the libev-1.3e pre-release), built on OSX, and ran all but 2 tests (already known problems) OK. Thanks for

Re: [Libevent-users] [PATCH] epoll.c: epoll_dispatch() clarity/simplification/branch reduction cleanups

2007-11-09 Thread Nick Mathewson
On Fri, Nov 09, 2007 at 02:27:07AM -0800, Christopher Layne wrote: Regress checks out OK with both -O0 and -Os. Both size are with -O0. Applied; thanks! yrs, -- Nick Mathewson pgpGNOLeYC7MB.pgp Description: PGP signature ___ Libevent-users mailing

[Libevent-users] [PATCH] sample/Makefile.am: additional include

2007-11-09 Thread Christopher Layne
Separate build dir issue. Index: sample/Makefile.am === --- sample/Makefile.am (revision 506) +++ sample/Makefile.am (working copy) @@ -1,7 +1,7 @@ AUTOMAKE_OPTIONS = foreign no-dependencies LDADD = ../libevent.la -AM_CFLAGS =

Re: [Libevent-users] [PATCH] sample/Makefile.am: additional include

2007-11-09 Thread Nick Mathewson
On Fri, Nov 09, 2007 at 11:12:49PM -0800, Christopher Layne wrote: Separate build dir issue. Applied to trunk. yrs, -- Nick Mathewson pgppVzvy8jLzH.pgp Description: PGP signature ___ Libevent-users mailing list Libevent-users@monkey.org