Re: [Libevent-users] API compatibility (was Re: patch to use different return value for event_base_loop())

2009-10-01 Thread Nick Mathewson
On Tue, Sep 29, 2009 at 11:39:59AM -0700, Ka-Hing Cheung wrote: > On Sun, 2009-08-16 at 10:39 -0700, Nick Mathewson wrote: > > > but I am willing to submit another patch (the one with > > > accessor to base->event_gotterm/event_break) if you think that's the > > > better way to do it. > > > > Prob

Re: [Libevent-users] API compatibility (was Re: patch to use different return value for event_base_loop())

2009-09-29 Thread Ka-Hing Cheung
On Sun, 2009-08-16 at 10:39 -0700, Nick Mathewson wrote: > > but I am willing to submit another patch (the one with > > accessor to base->event_gotterm/event_break) if you think that's the > > better way to do it. > > Probably. Sorry for taking so long. Attached is the promised patch which adds a

[Libevent-users] API compatibility (was Re: patch to use different return value for event_base_loop())

2009-08-16 Thread Nick Mathewson
On Thu, Aug 13, 2009 at 11:04:52AM -0700, Ka-Hing Cheung wrote: > On Thu, 2009-08-13 at 09:16 -0700, Nick Mathewson wrote: > > On Wed, Aug 12, 2009 at 11:42:47AM -0700, Ka-Hing Cheung wrote: > > [...] > > > I do realize that this breaks existing assumptions about return values. > > > What if inste