Re: [Libevent-users] bug in min_heap

2009-04-22 Thread Nick Mathewson
On Wed, Apr 15, 2009 at 08:00:39PM +0300, Marko Kreen wrote: [...] > Well, I attached a draft of it, but its totally untested and the > minheap code is not very parseable for me. So somebody with > has better understanding of the code should review it. (Maxim?) > > Basic idea - if you replace an

Re: [Libevent-users] bug in min_heap

2009-04-15 Thread Marko Kreen
On 4/15/09, Nick Mathewson wrote: > On Wed, Apr 15, 2009 at 01:01:00PM +0300, Marko Kreen wrote: > > Given heap shape of: > > > > 1 > >/ \ > > / \ > > 10 3 > >/ \ / \ > > 11 12 5 6 > > > > And now deleting '11', it seems to fail to k

Re: [Libevent-users] bug in min_heap

2009-04-15 Thread Nick Mathewson
On Wed, Apr 15, 2009 at 01:01:00PM +0300, Marko Kreen wrote: > Given heap shape of: > > 1 >/ \ > / \ > 10 3 >/ \ / \ > 11 12 5 6 > > And now deleting '11', it seems to fail to keep heap property. > > The bug is probably hard to notice in pra