Re: [PATCH 1/1] cmake: do not check for g++ when FTDIPP is disabled

2020-01-15 Thread Thomas Jarosch
Hi Fabrice, You wrote on Wed, Oct 02, 2019 at 05:28:33PM +0200: > diff --git a/CMakeLists.txt b/CMakeLists.txt > index 71857d0..1e26ed4 100644 > --- a/CMakeLists.txt > +++ b/CMakeLists.txt > @@ -1,5 +1,5 @@ > # Project > -project(libftdi1) > +project(libftdi1 C) > set(MAJOR_VERSION 1) >

Re: [PATCH] libftdi: pass eeprom strings as const

2020-01-15 Thread Thomas Jarosch
Hi Dan, You wrote on Tue, Jan 07, 2020 at 11:18:30AM -0500: > These strings are not modified and it doesn't make sense that they ever > would be. Setting these as const ensures that they will not be modified > and allows const strings to be passed in without special manipulation. > >

Re: [PATCH] CMake: reorder Python detection

2020-01-15 Thread Thomas Jarosch
Hi Yegor, You wrote on Mon, Jan 13, 2020 at 03:08:44PM +0100: > From: Yegor Yefremov > > PythonInterp should be detected before PythonLibs otherwise > CMake exits with the following message: > > Could NOT find PythonLibs (missing: PYTHON_LIBRARIES PYTHON_INCLUDE_DIRS) > > Signed-off-by: Yegor

[PATCH] Fix typos

2020-01-15 Thread yegorslists
From: Yegor Yefremov Signed-off-by: Yegor Yefremov --- cmake/FindConfuse.cmake | 2 +- examples/async.c| 4 ++-- examples/serial_test.c | 2 +- examples/stream_test.c | 4 ++-- ftdipp/CMakeLists.txt | 2 +- ftdipp/ftdi.cpp | 2 +- python/examples/cbus.py | 2 +-

Re: [PATCH] Fix typos

2020-01-15 Thread Yegor Yefremov
Hi Thomas, On Thu, Jan 16, 2020 at 8:42 AM wrote: > > From: Yegor Yefremov > > Signed-off-by: Yegor Yefremov > --- > cmake/FindConfuse.cmake | 2 +- > examples/async.c| 4 ++-- > examples/serial_test.c | 2 +- > examples/stream_test.c | 4 ++-- > ftdipp/CMakeLists.txt | 2 +- >