Re: [libgadu-devel] Patch: Fixed uninitialized variable in notify60

2010-04-28 Thread Paul Aurich
And Wojtek Kaniewski spoke on 04/28/2010 02:31 PM, saying: > It's a feature, not a bug. You're supposed to iterate through the array > until there's uin == 0. Thanks for the feedback. I've changed libpurple's gg plugin to not print a debug statement outside the loop. ~Paul signature.asc Descr

Re: [libgadu-devel] Patch: Fixed uninitialized variable in notify60

2010-04-28 Thread Jakub Zawadzki
On Wed, Apr 28, 2010 at 11:31:53PM +0200, Wojtek Kaniewski wrote: > It's a feature, not a bug. It can be used as seed for random number generator ;P (MSPANC) ___ libgadu-devel mailing list libgadu-devel@lists.ziew.org http://lists.ziew.org/mailman/listin

Re: [libgadu-devel] Patch: Fixed uninitialized variable in notify60

2010-04-28 Thread Wojtek Kaniewski
Jan Kaluza pisze: > I'm sending simple patch which fixes uninitialized variables in three > places in event.c. I've just checked current stable version and it > seems the bug is still there. You can find out more information at > http://developer.pidgin.im/ticket/11746. Patch should be also attache

Re: [libgadu-devel] Patch: Fixed uninitialized variable in notify60

2010-04-28 Thread Jan Kaluza
On Wed, Apr 28, 2010 at 9:32 AM, Jakub Zawadzki wrote: > On Wed, Apr 28, 2010 at 07:44:26AM +0200, Jakub Zawadzki wrote: >> On Tue, Apr 27, 2010 at 11:50:42PM +0200, Jan Kaluza wrote: >> > I'm sending simple patch which fixes uninitialized variables in three >> > places in event.c. I've just check

Re: [libgadu-devel] Patch: Fixed uninitialized variable in notify60

2010-04-28 Thread Jan Kaluza
I'm pretty sure (just checked libpurple's and latest official stable libgadu version) that ev->event.notify60 is not allocated by calloc, but by malloc: e->event.notify60 = malloc(sizeof(*e->event.notify60)); therefore e->event.notify60[0].descr could be anything. Jan Kaluza On Wed, Apr 28, 201

Re: [libgadu-devel] Patch: Fixed uninitialized variable in notify60

2010-04-28 Thread Jakub Zawadzki
On Wed, Apr 28, 2010 at 07:44:26AM +0200, Jakub Zawadzki wrote: > On Tue, Apr 27, 2010 at 11:50:42PM +0200, Jan Kaluza wrote: > > I'm sending simple patch which fixes uninitialized variables in three > > places in event.c. I've just checked current stable version and it > > seems the bug is still t

Re: [libgadu-devel] Patch: Fixed uninitialized variable in notify60

2010-04-27 Thread Jakub Zawadzki
Hi, On Tue, Apr 27, 2010 at 11:50:42PM +0200, Jan Kaluza wrote: > I'm sending simple patch which fixes uninitialized variables in three > places in event.c. I've just checked current stable version and it > seems the bug is still there. The whole memory of structure event_t is initialized to 0 in

[libgadu-devel] Patch: Fixed uninitialized variable in notify60

2010-04-27 Thread Jan Kaluza
Hi, I'm sending simple patch which fixes uninitialized variables in three places in event.c. I've just checked current stable version and it seems the bug is still there. You can find out more information at http://developer.pidgin.im/ticket/11746. Patch should be also attached to this email. Than