Re: [Libguestfs] [PATCH] virt-v2v: Support for Converting VirtualBox Guests

2012-03-12 Thread Marko Myllynen
Hi, + # Uninstall VirtualBox Guest Additions + foreach my $app (@$apps) { + my $name = $app->{app_name}; + + if ($name eq "virtualbox-guest-additions") { + _remove_application($name, $g); Can you rebase this to the latest upstream? _remove_application() became _remove_applications(). Can you s

Re: [Libguestfs] [PATCH] virt-v2v: Support for Converting VirtualBox Guests

2012-03-12 Thread Matthew Booth
On 03/12/2012 10:56 AM, Marko Myllynen wrote: Hi, attached is an updated [1] patch for virt-v2v to support converting VirtualBox guests with VirtualBox Guest Additions [2] installed. With the patch applied a VirtualBox RHEL 6 guest with Guest Additions can be converted with the steps documented

Re: [Libguestfs] [PATCH V2] virt-sysprep:add ipconfig for preparation

2012-03-12 Thread Wanlong Gao
On 03/12/2012 08:07 PM, Richard W.M. Jones wrote: > On Sun, Mar 11, 2012 at 07:06:32PM +0800, Wanlong Gao wrote: >> On 03/09/2012 11:48 PM, Richard W.M. Jones wrote: >> >>> On Fri, Mar 09, 2012 at 02:50:17PM +0800, Wanlong Gao wrote: +#FIXME: This may not work OK for IPv6 ? >>> >>> :-) >>> Do

Re: [Libguestfs] [PATCH V2] virt-sysprep:add ipconfig for preparation

2012-03-12 Thread Richard W.M. Jones
On Sun, Mar 11, 2012 at 07:06:32PM +0800, Wanlong Gao wrote: > On 03/09/2012 11:48 PM, Richard W.M. Jones wrote: > > > On Fri, Mar 09, 2012 at 02:50:17PM +0800, Wanlong Gao wrote: > >> +#FIXME: This may not work OK for IPv6 ? > > > > :-) > > Does it work or not? Anyone?? > > > The "enable=ipco

[Libguestfs] [PATCH] virt-v2v: Support for Converting VirtualBox Guests

2012-03-12 Thread Marko Myllynen
Hi, attached is an updated [1] patch for virt-v2v to support converting VirtualBox guests with VirtualBox Guest Additions [2] installed. With the patch applied a VirtualBox RHEL 6 guest with Guest Additions can be converted with the steps documented in the manual page. I've tested this patch

Re: [Libguestfs] [PATCH V2] virt-sysprep:add ipconfig for preparation

2012-03-12 Thread Wanlong Gao
Hi Rich: > On 03/09/2012 11:48 PM, Richard W.M. Jones wrote: > >> On Fri, Mar 09, 2012 at 02:50:17PM +0800, Wanlong Gao wrote: >>> +#FIXME: This may not work OK for IPv6 ? >> >> :-) >> Does it work or not? Anyone?? > > > The "enable=ipconfig" can work but "--ipconfig" here can't work on IPv6 >

Re: [Libguestfs] Compilation troubles

2012-03-12 Thread Richard W.M. Jones
Please keep replies on the list. On Mon, Mar 12, 2012 at 12:05:58AM +0100, Alessandro Dentella wrote: > On Sun, Mar 11, 2012 at 09:50:35PM +, Richard W.M. Jones wrote: > > On Sun, Mar 11, 2012 at 08:43:56PM +0100, Alessandro Dentella wrote: > > > Hi, > > > > > > I'm trying to compile hivex l

Re: [Libguestfs] Compilation troubles

2012-03-12 Thread Alessandro Dentella
Thanks Richard, On Sun, Mar 11, 2012 at 09:50:35PM +, Richard W.M. Jones wrote: > On Sun, Mar 11, 2012 at 08:43:56PM +0100, Alessandro Dentella wrote: > > Hi, > > > > I'm trying to compile hivex library that I just discovered. I'd use binaries > > but I only have an i386 ubuntu and debian so

Re: [Libguestfs] [PATCH] Coalesce printable characters in debug and trace messages (RHBZ#802109).

2012-03-12 Thread Jim Meyering
Richard W.M. Jones wrote: > +#define NO_ESCAPING(c) \ > + (c_isprint ((c)) || (from_appliance && ((c) == '\n' || (c) == '\r'))) > + > for (i = 0; i < buf_len; ++i) { > - c = buf[i]; > - if (c_isprint (c) || (from_appliance && (c == '\n' || c == '\r'))) > -putc (c, stderr