Re: [Libguestfs] [PATCH v3 7/7] resize: add support to resize logical partitions

On Tue, Sep 23, 2014 at 01:37:10PM +0800, Hu Tao wrote: On Mon, Sep 22, 2014 at 04:58:44PM +0100, Richard W.M. Jones wrote: I'm going to have to test the heck out of patch 07 to really understand what it is doing and whether it works. Our current virt-resize test suite isn't really up

Re: [Libguestfs] [PATCH] inspect: basic Minix support

On Mon, Sep 22, 2014 at 08:16:13PM +0200, Pino Toscano wrote: Add a basic support for identifying Minix, extracting its version and hostname. Related to RHBZ#1144137. ACK. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and

Re: [Libguestfs] [PATCH v3 7/7] resize: add support to resize logical partitions

On Tue, Sep 23, 2014 at 08:39:33AM +0100, Richard W.M. Jones wrote: On Tue, Sep 23, 2014 at 01:37:10PM +0800, Hu Tao wrote: On Mon, Sep 22, 2014 at 04:58:44PM +0100, Richard W.M. Jones wrote: I'm going to have to test the heck out of patch 07 to really understand what it is doing and

[Libguestfs] [PATCH] inspect: map Hurd devices, and enable fstab introspection

Add a mapping for the Hurd device names, so it is possible to enable the inspection of /etc/fstab. --- src/inspect-fs-unix.c | 25 - 1 file changed, 24 insertions(+), 1 deletion(-) diff --git a/src/inspect-fs-unix.c b/src/inspect-fs-unix.c index 3f57cd5..b629508 100644

[Libguestfs] [PATCH 00/13] syntax-check

Hi Rich, This series includes patches to make `make syntax-check` pass. Some of the fix require change to maint.mk, but the file is not in git repo. Is it intended? Thanks! Hu Tao (13): syntax-check: dirty hack to pass bindtextdomain check syntax-check: fix error_message_period check

[Libguestfs] [PATCH 04/13] syntax-check: fix prohibit_assert_without_use check

Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- p2v/config.c | 1 - p2v/conversion.c | 1 - p2v/main.c | 1 - 3 files changed, 3 deletions(-) diff --git a/p2v/config.c b/p2v/config.c index b4abb40..abc91be 100644 --- a/p2v/config.c +++ b/p2v/config.c @@ -24,7 +24,6 @@ #include

[Libguestfs] [PATCH 05/13] syntax-check: fix prohibit_c_ctype_without_use check

Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- cat/cat.c | 2 -- cat/log.c | 2 -- edit/edit.c | 1 - 3 files changed, 5 deletions(-) diff --git a/cat/cat.c b/cat/cat.c index 211d6e3..ec9c81f 100644 --- a/cat/cat.c +++ b/cat/cat.c @@ -29,8 +29,6 @@ #include assert.h #include libintl.h

[Libguestfs] [PATCH 08/13] syntax-check: fix prohibit_getopt_without_use check

Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- p2v/gui.c | 1 - 1 file changed, 1 deletion(-) diff --git a/p2v/gui.c b/p2v/gui.c index 2df5017..dc6619a 100644 --- a/p2v/gui.c +++ b/p2v/gui.c @@ -23,7 +23,6 @@ #include string.h #include inttypes.h #include unistd.h -#include getopt.h #include

[Libguestfs] [PATCH 11/13] syntax-check: fix prohibit_undesirable_word_seq check

Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- BUGS| 6 +++--- guestfs-release-notes.pod | 8 guestfs-release-notes.txt | 8 po-docs/ja.po | 8 po-docs/libguestfs-docs.pot | 8 po-docs/uk.po | 8

[Libguestfs] [PATCH 02/13] syntax-check: fix error_message_period check

Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- resize/resize.ml | 10 +- sparsify/copying.ml | 2 +- src/fuse.c | 2 +- src/launch-libvirt.c | 4 ++-- src/libvirt-domain.c | 2 +- v2v/convert_linux.ml | 6 +++--- v2v/input_libvirt.ml | 4 ++-- v2v/lib_ovf.ml |

[Libguestfs] [PATCH 06/13] syntax-check: fix prohibit_dirent_without_use check

Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- src/appliance.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/appliance.c b/src/appliance.c index a3a083e..d7aa6b1 100644 --- a/src/appliance.c +++ b/src/appliance.c @@ -19,7 +19,6 @@ #include config.h #include errno.h -#include dirent.h

[Libguestfs] [PATCH 01/13] syntax-check: dirty hack to pass bindtextdomain check

Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- p2v/gui.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/p2v/gui.c b/p2v/gui.c index a50307d..2df5017 100644 --- a/p2v/gui.c +++ b/p2v/gui.c @@ -69,7 +69,7 @@ static GtkWidget *run_dlg, *cancel_button; /* The entry point

[Libguestfs] [PATCH 13/13] syntax-check: fix trailing_blank check

Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- builder/website/debian.preseed | 2 +- builder/website/index | 120 +- builder/website/index.asc | 120 +- customize/customize_run.mli| 2 +- daemon/mount.c | 2 +- fish/test-file-attrs.sh

[Libguestfs] [PATCH 12/13] syntax-check: fix require_config_h_first check

Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- python/guestfs-py-byhand.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/python/guestfs-py-byhand.c b/python/guestfs-py-byhand.c index b071f81..5d2d858 100644 --- a/python/guestfs-py-byhand.c +++ b/python/guestfs-py-byhand.c

[Libguestfs] [PATCH 07/13] syntax-check: fix prohibit_empty_lines_at_EOF check

Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- builder/website/ubuntu.preseed | 1 - guestfs-release-notes.txt | 1 - p2v/issue | 1 - tests/guests/guest-aux/debian-packages | 1 - 4 files changed, 4 deletions(-) diff --git

[Libguestfs] [PATCH 10/13] syntax-check: fix prohibit_test_minus_ao check

Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- align/test-virt-alignment-scan-guests.sh | 2 +- align/test-virt-alignment-scan.sh| 2 +- builder/test-virt-builder-planner.sh | 2 +- builder/website/ubuntu.sh| 2 +- configure.ac | 2 +-

[Libguestfs] [PATCH 03/13] syntax-check: fix makefile_at_at_check

Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- align/Makefile.am| 2 +- builder/Makefile.am | 2 +- builder/website/Makefile.am | 2 +- cat/Makefile.am | 4 ++-- common-rules.mk | 8 customize/Makefile.am

[Libguestfs] [PATCH 09/13] syntax-check: fix prohibit_path_max_allocation check

Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- daemon/inotify.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/daemon/inotify.c b/daemon/inotify.c index 36e5ede..b847b7d 100644 --- a/daemon/inotify.c +++ b/daemon/inotify.c @@ -309,7 +309,7 @@ do_inotify_files

Re: [Libguestfs] libguestfs fails on FreeBSD9.3, MINIX3 qcow2 images

Hello Assaf, On Thursday 18 September 2014 11:38:09 Assaf Gordon wrote: I'm experimenting with libguestfs on non-linux VMs, encountered errors on FreeBSD9.3 and MINIX3 (and few others, but these ones are easy to share), with host Ubuntu 14.04.01 LTS x86-64. Thanks for the images! Now with

[Libguestfs] Virt-v2v conversion issue

Hi, I am running virt-v2v under CentOS 7, I use the new libguestfs-1.27.48-1.1, and when I try to import my Windows 2008 (running perfectly using virt-manager) in my cloud oVirt, I encounter this issue : libguestfs: trace: mkdir_p = 0 libguestfs: trace: case_sensitive_path

Re: [Libguestfs] [PATCH] inspect: map Hurd devices, and enable fstab introspection

On Tue, Sep 23, 2014 at 10:46:26AM +0200, Pino Toscano wrote: Add a mapping for the Hurd device names, so it is possible to enable the inspection of /etc/fstab. --- src/inspect-fs-unix.c | 25 - 1 file changed, 24 insertions(+), 1 deletion(-) diff --git

Re: [Libguestfs] Virt-v2v conversion issue

On Tue, Sep 23, 2014 at 08:50:13AM +, VONDRA Alain wrote: Hi, I am running virt-v2v under CentOS 7, I use the new libguestfs-1.27.48-1.1, and when I try to import my Windows 2008 (running perfectly using virt-manager) in my cloud oVirt, I encounter this issue : libguestfs:

[Libguestfs] Why is virt-resize designed to involve two disks?

HI, As you've known, vhd-util and qemu-img both provide the capacity for resizing the original disk, but why is virt-resize designed to involve two disks, not only original disk? Is there any concern? Is it possible that only one original disk is involved in virt-resize? -- Regards, Zhi Yong

[Libguestfs] Why is virt-resize designed to involve two disks?

HI, As you've known, vhd-util and qemu-img both provide the capacity for resizing the original disk, but why is virt-resize designed to involve two disks, not only original disk? Is there any concern? Is it possible that only one original disk is involved in virt-resize? --  Regards,   Zhi

Re: [Libguestfs] Why is virt-resize designed to involve two disks?

On Tue, Sep 23, 2014 at 06:19:21PM +0800, Zhi Yong Wu wrote: As you've known, vhd-util and qemu-img both provide the capacity for resizing the original disk, .. although they only resize the container, not the contents which is what virt-resize does. So these tools are not really comparable.

Re: [Libguestfs] [PATCH 12/13] syntax-check: fix require_config_h_first check

On Tuesday 23 September 2014 17:20:38 Hu Tao wrote: Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- python/guestfs-py-byhand.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/python/guestfs-py-byhand.c b/python/guestfs-py-byhand.c index b071f81..5d2d858 100644 ---

Re: [Libguestfs] [PATCH 09/13] syntax-check: fix prohibit_path_max_allocation check

On Tuesday 23 September 2014 17:20:35 Hu Tao wrote: Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- daemon/inotify.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) While I'd personally get rid of PATH_MAX at all, I understand the Linux inotify implementation relies on

Re: [Libguestfs] [PATCH 11/13] syntax-check: fix prohibit_undesirable_word_seq check

On Tuesday 23 September 2014 17:20:37 Hu Tao wrote: Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- BUGS| 6 +++--- guestfs-release-notes.pod | 8 guestfs-release-notes.txt | 8 po-docs/ja.po | 8

Re: [Libguestfs] [PATCH 01/13] syntax-check: dirty hack to pass bindtextdomain check

On Tuesday 23 September 2014 17:20:27 Hu Tao wrote: Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- p2v/gui.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/p2v/gui.c b/p2v/gui.c index a50307d..2df5017 100644 --- a/p2v/gui.c +++ b/p2v/gui.c @@ -69,7 +69,7 @@ static

Re: [Libguestfs] [PATCH 00/13] syntax-check

Hi Hu, On Tuesday 23 September 2014 17:20:26 Hu Tao wrote: This series includes patches to make `make syntax-check` pass. Thanks for your work. I have few general notes about it: - please be more descriptive about each issue: just tell in the first line of the commit what is the actual

Re: [Libguestfs] [PATCH 13/13] syntax-check: fix trailing_blank check

On Tuesday 23 September 2014 17:20:39 Hu Tao wrote: Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- builder/website/index | 120 +- builder/website/index.asc | 120 +- The index files for virt-builder need a trailing space to indicate a continuation line in

Re: [Libguestfs] [PATCH 01/13] syntax-check: dirty hack to pass bindtextdomain check

On Tue, Sep 23, 2014 at 04:00:44PM +0200, Pino Toscano wrote: On Tuesday 23 September 2014 17:20:27 Hu Tao wrote: Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- p2v/gui.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/p2v/gui.c b/p2v/gui.c index

Re: [Libguestfs] [PATCH 02/13] syntax-check: fix error_message_period check

On Tue, Sep 23, 2014 at 05:20:28PM +0800, Hu Tao wrote: Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- resize/resize.ml | 10 +- sparsify/copying.ml | 2 +- src/fuse.c | 2 +- src/launch-libvirt.c | 4 ++-- src/libvirt-domain.c | 2 +- v2v/convert_linux.ml | 6

Re: [Libguestfs] [PATCH 03/13] syntax-check: fix makefile_at_at_check

On Tue, Sep 23, 2014 at 05:20:29PM +0800, Hu Tao wrote: check-valgrind: - $(MAKE) VG=$(top_builddir)/run @VG@ check + $(MAKE) VG=$(top_builddir)/run $(VG) check make syntax-check is definitely wrong about these. We must not use $(VG) here since it will cause VG to be expanded at the

Re: [Libguestfs] [PATCH 07/13] syntax-check: fix prohibit_empty_lines_at_EOF check

On Tue, Sep 23, 2014 at 04:00:49PM +0200, Pino Toscano wrote: This is installed as /etc/issue in the p2v iso (see p2v/virt-p2v-make-disk.in). I assume the extra empty line is cosmetic. cosmetic .. and necessary. Rich. -- Richard Jones, Virtualization Group, Red Hat

Re: [Libguestfs] [PATCH 06/13] syntax-check: fix prohibit_dirent_without_use check

On Tue, Sep 23, 2014 at 05:20:32PM +0800, Hu Tao wrote: Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- src/appliance.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/appliance.c b/src/appliance.c index a3a083e..d7aa6b1 100644 --- a/src/appliance.c +++ b/src/appliance.c @@ -19,7

Re: [Libguestfs] [PATCH 09/13] syntax-check: fix prohibit_path_max_allocation check

On Tue, Sep 23, 2014 at 04:00:54PM +0200, Pino Toscano wrote: On Tuesday 23 September 2014 17:20:35 Hu Tao wrote: Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- daemon/inotify.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) While I'd personally get rid of PATH_MAX

Re: [Libguestfs] [PATCH 10/13] syntax-check: fix prohibit_test_minus_ao check

On Tue, Sep 23, 2014 at 05:20:36PM +0800, Hu Tao wrote: # 0, 2 and 3 are reasonable non-error exit codes. Others are errors. -if [ $r -ne 0 -a $r -ne 2 -a $r -ne 3 ]; then +if [ $r -ne 0 $r -ne 2 $r -ne 3 ]; then I think the intention of this test is that you're supposed to do: if [ $r

Re: [Libguestfs] [PATCH 08/13] syntax-check: fix prohibit_getopt_without_use check

On Tue, Sep 23, 2014 at 05:20:34PM +0800, Hu Tao wrote: Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- p2v/gui.c | 1 - 1 file changed, 1 deletion(-) diff --git a/p2v/gui.c b/p2v/gui.c index 2df5017..dc6619a 100644 --- a/p2v/gui.c +++ b/p2v/gui.c @@ -23,7 +23,6 @@ #include string.h

Re: [Libguestfs] [PATCH 00/13] syntax-check

On Tue, Sep 23, 2014 at 04:00:34PM +0200, Pino Toscano wrote: - in case of unused includes, I'd say it should be fine to just remove them together in a single commit Ah - I just pushed all the include patches :-) Rich. -- Richard Jones, Virtualization Group, Red Hat

Re: [Libguestfs] Virt-v2v conversion issue

Hi Thank you for your quick response, do you know when the build 1.27.53 will be available ? Alain Alain VONDRA Chargé d'exploitation des Systèmes d'Information Direction Administrative et Financière +33 1 44 39 77 76 UNICEF France 3 rue Duguay Trouin 75006 PARIS www.unicef.fr

Re: [Libguestfs] Virt-v2v conversion issue

On Tue, Sep 23, 2014 at 03:46:33PM +, VONDRA Alain wrote: Hi Thank you for your quick response, do you know when the build 1.27.53 will be available ? Probably tomorrow if all goes well. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my

Re: [Libguestfs] [Qemu-devel] Why is virt-resize designed to involve two disks?

On 09/23/2014 04:15 AM, 吴志勇 wrote: HI, [please configure your mailer to wrap long lines] As you've known, vhd-util and qemu-img both provide the capacity for resizing the original disk, but why is virt-resize designed to involve two disks, not only original disk? Is there any concern? Is it

Re: [Libguestfs] Virt-v2v conversion issue

The 1.27.53 build is available now. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net

[Libguestfs] Another possible bug in the preview version of virt-v2v for RHEL/CentOS 7.1

I have been able to get a litle further with converting a windows VM. After getting the updated virt-v2v code and rhsrvany, I now get this error: libguestfs: trace: hivex_node_set_value = 0 libguestfs: trace: upload /usr/share/virtio-win/drivers/amd64/Win2012R2/netkvm.cat

Re: [Libguestfs] [PATCH 00/13] syntax-check

On Tue, Sep 23, 2014 at 04:00:34PM +0200, Pino Toscano wrote: Hi Hu, On Tuesday 23 September 2014 17:20:26 Hu Tao wrote: This series includes patches to make `make syntax-check` pass. Thanks for your work. I have few general notes about it: - please be more descriptive about each

Re: [Libguestfs] Why is virt-resize designed to involve two disks?

On Tue, Sep 23, 2014 at 8:11 PM, Richard W.M. Jones rjo...@redhat.com wrote: On Tue, Sep 23, 2014 at 06:19:21PM +0800, Zhi Yong Wu wrote: As you've known, vhd-util and qemu-img both provide the capacity for resizing the original disk, .. although they only resize the container, not the