Re: [Libguestfs] Concurrent scanning of same disk

2015-05-28 Thread Richard W.M. Jones
On Thu, May 28, 2015 at 09:48:41AM +0300, NoxDaFox wrote: 2015-05-27 15:21 GMT+03:00 Richard W.M. Jones rjo...@redhat.com: On Wed, May 27, 2015 at 09:38:38AM +0300, NoxDaFox wrote: * RuntimeError: file receive cancelled by daemon - On r = libguestfsmod.checksums_out (self._o, csumtype,

Re: [Libguestfs] Concurrent scanning of same disk

2015-05-28 Thread Richard W.M. Jones
On Thu, May 28, 2015 at 10:33:48AM +0300, NoxDaFox wrote: To create the snapshots I'm using the libvirt command snapshotCreateXML with no flag set. Does libvirt support consistent snapshotting or shall I rely on QEMU backup new feature only? According to: http://wiki.libvirt.org/page/Snapshots

Re: [Libguestfs] Concurrent scanning of same disk

2015-05-28 Thread Richard W.M. Jones
On Thu, May 28, 2015 at 10:57:51AM +0300, NoxDaFox wrote: 2015-05-28 10:40 GMT+03:00 Richard W.M. Jones rjo...@redhat.com: On Thu, May 28, 2015 at 10:33:48AM +0300, NoxDaFox wrote: To create the snapshots I'm using the libvirt command snapshotCreateXML with no flag set. Does libvirt

Re: [Libguestfs] [PATCH v2 02/11] resize: add logical_partitions and extended_partition

2015-05-28 Thread Richard W.M. Jones
On Thu, May 28, 2015 at 01:13:28PM +0200, Pino Toscano wrote: In data giovedì 28 maggio 2015 12:06:18, Richard W.M. Jones ha scritto: + let logical_partitions = +List.filter (fun p - parttype = MBR p.p_mbr_p_type = LogicalPartition) partitions in + (* Filter out logical

Re: [Libguestfs] Concurrent scanning of same disk

2015-05-28 Thread Richard W.M. Jones
On Thu, May 28, 2015 at 01:41:51PM +0300, NoxDaFox wrote: I made a couple of changes and the hive corruption issue seems to be gone. The RuntimeError: file receive cancelled by daemon still persists. From the guestfs trace I can't see any evidence if not what seems a sort of overflow:

Re: [Libguestfs] [PATCH v2 02/11] resize: add logical_partitions and extended_partition

2015-05-28 Thread Richard W.M. Jones
On Wed, May 20, 2015 at 06:51:28AM -0400, Chen Hanxiao wrote: For MBR, logical partitions laid inside extended partition. Add 3 variables to describe this: - partitions flat list of primary partitions (as now, the global 'partitions'). extended partitions is essentially primary

Re: [Libguestfs] [PATCH v2 04/11] resize: add support for logical partitions for calculate_surplus

2015-05-28 Thread Richard W.M. Jones
On Thu, May 28, 2015 at 12:11:17PM +0100, Richard W.M. Jones wrote: On Wed, May 20, 2015 at 06:51:30AM -0400, Chen Hanxiao wrote: Add support for logical partitions. - count number of logical_partition (we've split partitions list) - don't count size of extended partition For it'll

Re: [Libguestfs] [PATCH v2 02/11] resize: add logical_partitions and extended_partition

2015-05-28 Thread Pino Toscano
In data giovedì 28 maggio 2015 12:06:18, Richard W.M. Jones ha scritto: + let logical_partitions = +List.filter (fun p - parttype = MBR p.p_mbr_p_type = LogicalPartition) partitions in + (* Filter out logical partitions. See note above. *) + let partitions = +(* for GPT,

Re: [Libguestfs] Concurrent scanning of same disk

2015-05-28 Thread NoxDaFox
2015-05-28 11:10 GMT+03:00 Richard W.M. Jones rjo...@redhat.com: On Thu, May 28, 2015 at 10:57:51AM +0300, NoxDaFox wrote: 2015-05-28 10:40 GMT+03:00 Richard W.M. Jones rjo...@redhat.com: On Thu, May 28, 2015 at 10:33:48AM +0300, NoxDaFox wrote: To create the snapshots I'm using the

Re: [Libguestfs] [PATCH v2 04/11] resize: add support for logical partitions for calculate_surplus

2015-05-28 Thread Richard W.M. Jones
On Wed, May 20, 2015 at 06:51:30AM -0400, Chen Hanxiao wrote: Add support for logical partitions. - count number of logical_partition (we've split partitions list) - don't count size of extended partition For it'll duplicate with logical partition, we'll count it later - we need at leat

Re: [Libguestfs] Concurrent scanning of same disk

2015-05-28 Thread Daniel P. Berrange
On Wed, May 27, 2015 at 09:38:38AM +0300, NoxDaFox wrote: Greetings, I am suffering of several weird errors which show randomly and make me suspect some concurrency issue. Libguestfs version is 1.28.1, linux kernel 3.16, libvirt 1.2.9 and qemu 2.1. What I'm trying to do is comparing the

Re: [Libguestfs] [PATCH v5] inspector: recognize ppc64 and ppc64le archs (RHBZ#1211996)

2015-05-28 Thread Richard W.M. Jones
On Fri, May 22, 2015 at 05:10:14PM +0200, Maros Zatko wrote: @@ -145,7 +154,7 @@ magic_for_file (guestfs_h *g, const char *filename, bool *loading_ok, if (loading_ok) *loading_ok = true; - elf_arch = match1 (g, line, re_file_elf); + match2 (g, line, re_file_elf, endianness,

[Libguestfs] [PATCH 3/4] ocaml: doc: add the version (if available) of APIs

2015-05-28 Thread Pino Toscano
Make sure to not add more newline's than needed. --- generator/ocaml.ml | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/generator/ocaml.ml b/generator/ocaml.ml index e7c6a1a..d2a4690 100644 --- a/generator/ocaml.ml +++ b/generator/ocaml.ml @@ -153,12 +153,23 @@

[Libguestfs] [PATCH 1/4] generator: move api_version to a common version_added

2015-05-28 Thread Pino Toscano
This way the version string of each API can be used also in other generator modules. Mostly code motion, no actual behaviour changes. --- generator/c.ml | 21 ++--- generator/docstrings.ml | 6 ++ 2 files changed, 16 insertions(+), 11 deletions(-) diff --git

[Libguestfs] [PATCH 2/4] gobject: doc: add the version (if available) of APIs

2015-05-28 Thread Pino Toscano
--- generator/gobject.ml | 4 1 file changed, 4 insertions(+) diff --git a/generator/gobject.ml b/generator/gobject.ml index e563610..8d5ac06 100644 --- a/generator/gobject.ml +++ b/generator/gobject.ml @@ -1109,6 +1109,10 @@ guestfs_session_close (GuestfsSession *session, GError **err)

[Libguestfs] [PATCH 4/4] java: doc: add the version (if available) of APIs

2015-05-28 Thread Pino Toscano
--- generator/java.ml | 4 1 file changed, 4 insertions(+) diff --git a/generator/java.ml b/generator/java.ml index 573f1c2..4c89197 100644 --- a/generator/java.ml +++ b/generator/java.ml @@ -273,6 +273,10 @@ public class GuestFS { pr* /pp\n; pr* %s\n doc;