Re: [Libguestfs] [PATCH] added ntfscat_i api

2016-02-22 Thread noxdafox
On 22/02/16 19:43, Richard W.M. Jones wrote: On Mon, Feb 22, 2016 at 07:23:45PM +0200, noxdafox wrote: On 22/02/16 17:26, Richard W.M. Jones wrote: On Sun, Feb 21, 2016 at 11:22:23PM +0200, Matteo Cafasso wrote: Adding ntfscat_i command for downloading files based on their inode number.

Re: [Libguestfs] [PATCH 0/8] Fix valgrind tests.

2016-02-22 Thread Richard W.M. Jones
On Mon, Feb 22, 2016 at 06:49:47PM +0100, Pino Toscano wrote: > On Monday 22 February 2016 13:59:11 Richard W.M. Jones wrote: > > Since we switched to using parallel tests, our valgrind tests would > > definitely have found leaks in the /usr/bin/env program if it had any. > > Not so much in some

Re: [Libguestfs] [PATCH] added ntfscat_i api

2016-02-22 Thread Richard W.M. Jones
On Mon, Feb 22, 2016 at 07:23:45PM +0200, noxdafox wrote: > On 22/02/16 17:26, Richard W.M. Jones wrote: > >On Sun, Feb 21, 2016 at 11:22:23PM +0200, Matteo Cafasso wrote: > >>Adding ntfscat_i command for downloading files based on their inode number. > >> > >>This allows the dowload of files

Re: [Libguestfs] [PATCH] added ntfscat_i api

2016-02-22 Thread noxdafox
On 22/02/16 17:26, Richard W.M. Jones wrote: On Sun, Feb 21, 2016 at 11:22:23PM +0200, Matteo Cafasso wrote: Adding ntfscat_i command for downloading files based on their inode number. This allows the dowload of files unaccessible otherwise from a NTFS guest disk image. The patch seems fine,

[Libguestfs] [PATCH 1/3] python: tests: refactor to use unittest's discovery

2016-02-22 Thread Pino Toscano
Instead of running all the tests manually, the unittest module has a 'discovery' mode to run tests by importing them from a directory: this requires the tests to have different filenames, since they need to be imported as modules now (hence an empty __init__.py is added), and the current naming

[Libguestfs] [PATCH 2/3] python: tests: move the 'int' type in tests_helper

2016-02-22 Thread Pino Toscano
This way it can be used in other tests as well. Simple code motion. --- python/t/test080Version.py | 10 +++--- python/t/tests_helper.py | 7 +++ 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/python/t/test080Version.py b/python/t/test080Version.py index

[Libguestfs] [PATCH 3/3] python: tests: fix long/int mismatch in test090RetValues.py

2016-02-22 Thread Pino Toscano
Cast the value to the "int_type" representing the "long" value for test_rint64, so the test works again with Python 3. --- python/t/test090RetValues.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/python/t/test090RetValues.py b/python/t/test090RetValues.py index

Re: [Libguestfs] Reply:Re: how to compile my own libguestfs with the ntfs support ?

2016-02-22 Thread Richard W.M. Jones
On Mon, Feb 22, 2016 at 11:00:53PM +0800, 罗思标 wrote: > Hi rjones, > > Good catch, thanks a lot. Does it only disable from official > rhel/centos RPM with > `-RHEL-7-Reject-use-of-libguestfs-winsupport-features-.patch' in > libguestfs while it still work in upstream source code ( > e.g.

Re: [Libguestfs] [PATCH] added ntfscat_i api

2016-02-22 Thread Richard W.M. Jones
On Sun, Feb 21, 2016 at 11:22:23PM +0200, Matteo Cafasso wrote: > Adding ntfscat_i command for downloading files based on their inode number. > > This allows the dowload of files unaccessible otherwise from a NTFS guest > disk image. The patch seems fine, but it really needs a test otherwise

[Libguestfs] Reply:Re: how to compile my own libguestfs with the ntfs support ?

2016-02-22 Thread 罗思标
Hi rjones, Good catch, thanks a lot. Does it only disable from official rhel/centos RPM with `-RHEL-7-Reject-use-of-libguestfs-winsupport-features-.patch' in libguestfs while it still work in upstream source code ( e.g. rhel-7.2 branch in https://github.com/libguestfs/libguestfs ) , which

Re: [Libguestfs] [PATCH v2 3/4] v2v: take requested caps into account when converting

2016-02-22 Thread Richard W.M. Jones
On Sat, Feb 20, 2016 at 11:26:09AM +0300, Roman Kagan wrote: > Give the caller certain control over what kind of interface to use for > virtual disks, network and video cards upon conversion. > > For that, make convert functions accept additional rcaps parameter > containing an object with

Re: [Libguestfs] [PATCH v2 2/4] v2v: introduce requested guestcaps type

2016-02-22 Thread Richard W.M. Jones
On Sat, Feb 20, 2016 at 11:26:08AM +0300, Roman Kagan wrote: > Introduce a type to contain the guestcaps that are to be put in effect > in the converted VM: options of the block type, net type, and video. > > It'll be populated by the caller and passed into convert function to > affect its choice

Re: [Libguestfs] [PATCH v2 1/4] v2v: collect source network and video adapter types

2016-02-22 Thread Richard W.M. Jones
On Sat, Feb 20, 2016 at 11:26:07AM +0300, Roman Kagan wrote: > Those will be useful when making decisions about what configuration to > set on output. > > The data is also included in --print-source so the tests are adjusted > accordingly. > > Signed-off-by: Roman Kagan >

Re: [Libguestfs] Cubietruck: QEMU, KVM and Fedora

2016-02-22 Thread Richard W.M. Jones
On Mon, Feb 22, 2016 at 12:59:47PM +0100, Kashyap Chamarthy wrote: > > root@cubietruck:~# /usr/bin/libguestfs-test-tool -V > > libguestfs-test-tool 1.30.6 [...] > > [00633ms] /usr/bin/qemu-system-arm \ > > -global virtio-blk-device.scsi=off \ > > -nodefconfig \ > > -enable-fips \ > >

[Libguestfs] [PATCH 8/8] tests: mount-local: Use LOG_COMPILER to run valgrind.

2016-02-22 Thread Richard W.M. Jones
--- tests/mount-local/Makefile.am | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/mount-local/Makefile.am b/tests/mount-local/Makefile.am index eac2cc8..b3c86cf 100644 --- a/tests/mount-local/Makefile.am +++ b/tests/mount-local/Makefile.am @@ -21,7 +21,8 @@ if

[Libguestfs] [PATCH 7/8] tests: c-api: Use LOG_COMPILER to run valgrind.

2016-02-22 Thread Richard W.M. Jones
--- tests/c-api/Makefile.am | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/c-api/Makefile.am b/tests/c-api/Makefile.am index 6503d94..40fe33e 100644 --- a/tests/c-api/Makefile.am +++ b/tests/c-api/Makefile.am @@ -80,7 +80,8 @@ TESTS_ENVIRONMENT = \

[Libguestfs] [PATCH 6/8] lib: Use LOG_COMPILER to run valgrind.

2016-02-22 Thread Richard W.M. Jones
--- src/Makefile.am | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/Makefile.am b/src/Makefile.am index 25c6fa3..3ebb7f5 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -253,7 +253,8 @@ endif # internal tests of utility functions. Note we don't just test what's

[Libguestfs] [PATCH 3/8] tests: daemon: Remove bogus use of $(VG).

2016-02-22 Thread Richard W.M. Jones
--- tests/daemon/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/daemon/Makefile.am b/tests/daemon/Makefile.am index bb380c5..053cad3 100644 --- a/tests/daemon/Makefile.am +++ b/tests/daemon/Makefile.am @@ -27,7 +27,7 @@ TESTS = \ test-daemon-start.pl

[Libguestfs] [PATCH 1/8] run.in: Remove out of date documentation for using $(VG).

2016-02-22 Thread Richard W.M. Jones
Since we enabled parallel tests, you can no longer run tests under valgrind merely by doing: TESTS_ENVIRONMENT = $(top_builddir)/run --test $(VG) check-valgrind: $(MAKE) check VG="@VG@" The reason is that the parallel tests framework doesn't run ``$(TESTS_ENVIRONMENT) ''. It inserts

[Libguestfs] [PATCH 0/8] Fix valgrind tests.

2016-02-22 Thread Richard W.M. Jones
Since we switched to using parallel tests, our valgrind tests would definitely have found leaks in the /usr/bin/env program if it had any. Not so much in some of our own programs. Let's fix that. Rich. ___ Libguestfs mailing list Libguestfs@redhat.com

[Libguestfs] [PATCH 2/8] docs: Describe how to set up check-valgrind rules correctly.

2016-02-22 Thread Richard W.M. Jones
--- docs/guestfs-hacking.pod | 32 ++-- 1 file changed, 30 insertions(+), 2 deletions(-) diff --git a/docs/guestfs-hacking.pod b/docs/guestfs-hacking.pod index c357717..419a4c2 100644 --- a/docs/guestfs-hacking.pod +++ b/docs/guestfs-hacking.pod @@ -274,8 +274,7 @@

[Libguestfs] [PATCH 4/8] lua: Remove bogus use of $(VG).

2016-02-22 Thread Richard W.M. Jones
No check-valgrind is used in this subdirectory anyway. --- lua/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lua/Makefile.am b/lua/Makefile.am index 4c01e80..264f170 100644 --- a/lua/Makefile.am +++ b/lua/Makefile.am @@ -64,7 +64,7 @@ guestfs.so: libluaguestfs.la

Re: [Libguestfs] Cubietruck: QEMU, KVM and Fedora

2016-02-22 Thread Kashyap Chamarthy
[CCing the libguestfs mailing list - as Rich responded on IRC about your question on timeout.] On Sun, Feb 21, 2016 at 10:07 PM, Thomas Kee wrote: > Hi Kashyap, > > Thanks for offering to help. The day job caused a pause and it took me an > hour to reassert where I was in the

Re: [Libguestfs] how to compile my own libguestfs with the ntfs support ?

2016-02-22 Thread Richard W.M. Jones
On Sun, Feb 21, 2016 at 09:42:34AM +0800, 罗思标 wrote: > I get that libguest not supported mount windows VM image from > rhel7.2 now, could you help point that how to compile my own > libguestfs with the ntfs support, which option to enable it when > make configure with the code ? Thx a lot. >

[Libguestfs] how to compile my own libguestfs with the ntfs support ?

2016-02-22 Thread 罗思标
I get that libguest not supported mount windows VM image from rhel7.2 now, could you help point that how to compile my own libguestfs with the ntfs support, which option to enable it when make configure with the code ? Thx a lot.