[Libguestfs] [PATCH 3/3] Code cleanup in daemon/sleuthkit.c

Adhere to coding standards. Signed-off-by: Matteo Cafasso --- daemon/sleuthkit.c | 48 +++- 1 file changed, 27 insertions(+), 21 deletions(-) diff --git a/daemon/sleuthkit.c b/daemon/sleuthkit.c index 2f8c97b..1262b68 100644 ---

[Libguestfs] [PATCH 1/3] Rename icat command in download_inode

The "icat" name comes from the employed command line tool which might be replaced at any time with a different implementation. The command name is a bit confusing because it's similar to "cat" but act as "donwload". download_inode is more clear and descriptive. Signed-off-by: Matteo Cafasso

[Libguestfs] [PATCH 0/3] rename icat API into download_inode

The command name is a bit confusing because it's similar to "cat" but act as "donwload". Therefore I am renaming it with a more clear name. At the same go I cleaned up a bit the code following the standards and improved the API documentation. This patch is ready for review. Code available at:

Re: [Libguestfs] [PATCH] inspect: use os-release for CoreOS

On Wed, Mar 30, 2016 at 04:38:31PM +0200, Pino Toscano wrote: > Look for /lib/os-release in the /usr partition and try to use it, if > present, before using lsb-release later on. This should not change the > final result of the inspection, while using the os-release detection > method also for

[Libguestfs] [PATCH] inspect: use os-release for CoreOS

Look for /lib/os-release in the /usr partition and try to use it, if present, before using lsb-release later on. This should not change the final result of the inspection, while using the os-release detection method also for CoreOS. --- Nikos, since you added the support for CoreOS in libguestfs,

Re: [Libguestfs] [ovirt-devel] virt-v2v become zombie via python cpopen on error

On 30.03.16 14:28, Nir Soffer wrote: > On Wed, Mar 30, 2016 at 1:36 PM, Michal Skrivanek > wrote: > > > >> On 30 Mar 2016, at 11:49, Richard W.M. Jones wrote: > >> > >> On Wed, Mar 30, 2016 at 12:19:35PM +0300, Shahar Havivi wrote: > >>> Hi, > >>>

Re: [Libguestfs] [PATCH] renamed daemon/tsk.c to daemon/sleuthkit.c

On Tuesday 29 March 2016 22:56:29 Matteo Cafasso wrote: > In order to support the new features I am renaming the file with a better > name. > > The file sleuthkit.c will contain the code depending on the sleuthkit package. > > The original tsk.c file will contain the logic built using libtsk >

Re: [Libguestfs] [PATCH 0/2] added filesystem_walk0 low level API

On Wednesday 30 March 2016 13:45:15 NoxDaFox wrote: > Thanks for the comments, just few notes and questions. Just remember to keep the list in the loop. > 2016-03-30 12:24 GMT+03:00 Pino Toscano : > > > Hi, > > > > while reviewing the new series of tsk-related changes, I'm

Re: [Libguestfs] virt-v2v become zombie via python cpopen on error

> On 30 Mar 2016, at 11:49, Richard W.M. Jones wrote: > > On Wed, Mar 30, 2016 at 12:19:35PM +0300, Shahar Havivi wrote: >> Hi, >> >> We encounter a problem in VDSM project that virt-v2v become zombie task while >> importing vm from vmware. >> When virt-v2v is in 'copy disk'

Re: [Libguestfs] virt-v2v become zombie via python cpopen on error

On Wed, Mar 30, 2016 at 12:19:35PM +0300, Shahar Havivi wrote: > Hi, > > We encounter a problem in VDSM project that virt-v2v become zombie task while > importing vm from vmware. > When virt-v2v is in 'copy disk' mode and we someone deletes the vm at vmware > the process hang in read() method, >

Re: [Libguestfs] [PATCH 1/2] rename icat API to download_inode

On Tuesday 29 March 2016 23:48:07 Matteo Cafasso wrote: > Signed-off-by: Matteo Cafasso > --- See general notes sent as https://www.redhat.com/archives/libguestfs/2016-March/msg00269.html This patch mixes two things: a) rename of API b) coding style changes (and some of them

Re: [Libguestfs] [PATCH 1/2] added filesystem_walk API

On Tuesday 29 March 2016 20:42:48 Matteo Cafasso wrote: > Signed-off-by: Matteo Cafasso > --- See general notes sent as https://www.redhat.com/archives/libguestfs/2016-March/msg00269.html > generator/actions.ml | 13 > src/Makefile.am | 1 + > src/tsk.c

Re: [Libguestfs] [PATCH 0/2] added filesystem_walk0 low level API

Hi, while reviewing the new series of tsk-related changes, I'm noticing common mistakes in all of them: I'll list them below, not copy/paste-ing them every review. (a) please check the coding style, in particular - the lack of space between a function name and its following opening

[Libguestfs] virt-v2v become zombie via python cpopen on error

Hi, We encounter a problem in VDSM project that virt-v2v become zombie task while importing vm from vmware. When virt-v2v is in 'copy disk' mode and we someone deletes the vm at vmware the process hang in read() method, I am pretty sure that its not virt-v2v problem because when I run it from the