Re: [Libguestfs] [PATCH 0/4] v2v: simplify Windows registry patching

Crumbs .. Yes .. I don't even know how to review this. I have a set of (non-upstream) virt-v2v tests against Windows guests which I will start running now. They usually take many hours to run, and also I'm on holiday tomorrow. That should hopefully tell me if it completely breaks stuff or

[Libguestfs] [PATCH 3/4] v2v: win >= 8: simplify registry patching

It turned out (by trial and error) that for Windows >= 8 / 2012, even though the PnP system uses names related to the original driver's .inf file for certain entries under DriverDatabase registry subtree, this doesn't have to hold for the storage driver to make it boot. So use our own artificial

[Libguestfs] [PATCH 1/4] v2v: win <= 7: reduce registry patch

The patch to the Windows registry allowing it to boot off a virtio-blk drive was initially conceived by comparing the state with virtio-blk driver properly installed, to that without. However, we don't want to replicate the Windows PnP system; rather we need to apply just enough edits to make the

[Libguestfs] [PATCH 2/4] v2v: win >= 8: reduce registry patch

The patch to the Windows registry allowing it to boot off a virtio-blk drive was initially conceived by comparing the state with virtio-blk driver properly installed, to that without. However, we don't want to replicate the Windows PnP system; rather we need to apply just enough edits to make the

[Libguestfs] [PATCH 4/4] v2v: win: factor out common bits in registry patching

Refactor registry patching to share common parts between Win <= 7 and Win >= 8. Also branch between the two based on the presence of the DriverDatabase subtree rather than on the OS version, which allows not to pass the inspect handle into the functions. OTOH make the patching functions accept

[Libguestfs] [PATCH 0/4] v2v: simplify Windows registry patching

The way we patch the Windows registry in order to allow it to boot off a virtio-blk drive was initially conceived by comparing the state with virtio-blk driver properly installed, to that without. However, we don't want to replicate the Windows PnP system; rather we need to apply just enough

[Libguestfs] [PATCH v4 2/5] configure: Added libtsk compile-time check

Ensure libtsk is available at compile time. If not, daemon routines depending on it won't be available. Signed-off-by: Matteo Cafasso --- docs/guestfs-building.pod | 4 m4/guestfs_daemon.m4 | 8 2 files changed, 12 insertions(+) diff --git

[Libguestfs] [PATCH v4 4/5] New API: filesystem_walk

Library's counterpart of the daemon's internal_filesystem_walk command. It writes the daemon's command output on a temporary file and parses it, deserialising the XDR formatted tsk_dirent structs. It returns to the caller the list of tsk_dirent structs generated by the internal_filesystem_walk

[Libguestfs] [PATCH v4 0/5] New API: filesystem_walk

v4: - Changed tsk_allocated struct field into tsk_flags. - Added optional dependency in documentation. - Use asprintf and perror instead of asprintf_nowarn and fprintf. - Ensure CLEANUP_FREE vars are initialised. - Reworked the function documentation. - Improved tests robustness.

[Libguestfs] [PATCH v4 1/5] generator: Added tsk_dirent struct

The tsk_dirent struct contains the information gathered via TSK APIs. The struct contains the following fields: * tsk_inode: inode of a file * tsk_type: type of file such as for dirwalk command * tsk_size: file size in bytes * tsk_name: path relative to its disk partition * tsk_flags:

[Libguestfs] [PATCH v4 3/5] New API: internal_filesystem_walk

The internal_filesystem_walk command walks through the FS structures of a disk partition and returns all the files or directories which could be found. The command is able to retrieve information regarding deleted or unaccessible files where other commands such as stat or find would fail. The

[Libguestfs] [PATCH v4 5/5] lib: Added filesystem_walk command tests

The tests check whether the filesystem_walk command is able to retrieve information regarding both existing and deleted files. A NTFS image is used as Ext3+ filesystems deletion is more aggressive in terms of metadata removal. Signed-off-by: Matteo Cafasso ---

Re: [Libguestfs] [PATCH 6/7] v2v: quiet virtio net and balloon devices wizards

On Wed, Apr 06, 2016 at 11:24:03AM +0200, Cedric Bosdonnat wrote: > On Wed, 2016-04-06 at 11:43 +0300, Roman Kagan wrote: > > I think this would be better addressed if you could disable PnP > > manager > > prompts globally during v2v, and reset it back in a firstboot script > > after your

Re: [Libguestfs] [PATCH 6/7] v2v: quiet virtio net and balloon devices wizards

On Wed, 2016-04-06 at 11:43 +0300, Roman Kagan wrote: > On Wed, Apr 06, 2016 at 10:13:35AM +0200, Cedric Bosdonnat wrote: > > The problem with running after the PnP is that user will be > > prompted > > for installation of virtio-net and virtio-balloon drivers... which > > doesn't make sense as we

Re: [Libguestfs] [PATCH 6/7] v2v: quiet virtio net and balloon devices wizards

On Wed, 2016-04-06 at 10:54 +0300, Roman Kagan wrote: > On Wed, Apr 06, 2016 at 09:16:16AM +0200, Cedric Bosdonnat wrote: > > On Tue, 2016-04-05 at 21:08 +0300, Roman Kagan wrote: > > > > I'll talk to our guys doing similar things. I wonder what they > > > > do > > > > -- > > > > they must have

Re: [Libguestfs] [PATCH 6/7] v2v: quiet virtio net and balloon devices wizards

On Wed, Apr 06, 2016 at 09:16:16AM +0200, Cedric Bosdonnat wrote: > On Tue, 2016-04-05 at 21:08 +0300, Roman Kagan wrote: > > > I'll talk to our guys doing similar things. I wonder what they do > > > -- > > > they must have similar problems. > > > > Indeed they do. The solution we're

Re: [Libguestfs] [PATCH 6/7] v2v: quiet virtio net and balloon devices wizards

On Tue, 2016-04-05 at 21:08 +0300, Roman Kagan wrote: > > I'll talk to our guys doing similar things. I wonder what they do > > -- > > they must have similar problems. > > Indeed they do. The solution we're considering ATM is > > 1) make the installer support running on a system where the