Re: [Libguestfs] [PATCH] sleuthkit code cleanup

On Mon, Aug 08, 2016 at 11:28:56PM +0300, Matteo Cafasso wrote: > Small cosmetic changes. > > Signed-off-by: Matteo Cafasso > --- > daemon/sleuthkit.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/daemon/sleuthkit.c b/daemon/sleuthkit.c >

[Libguestfs] [PATCH] sleuthkit code cleanup

Small cosmetic changes. Signed-off-by: Matteo Cafasso --- daemon/sleuthkit.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/daemon/sleuthkit.c b/daemon/sleuthkit.c index ce738e3..e642731 100644 --- a/daemon/sleuthkit.c +++ b/daemon/sleuthkit.c @@

[Libguestfs] ANNOUNCE: libguestfs 1.34 released

I'm pleased to announce libguestfs 1.34, a library and set of tools for accessing and modifying virtual machine disk images. This release took about 8 months of work by many contributors. Amongst the new features are large performance improvements, substantial enhancements to virt-p2v & virt-v2v,

[Libguestfs] Fwd: Patch for hivex ruby library extension

- Forwarded message from Margaret Lewicka - Date: Sat, 16 Jul 2016 23:56:39 +0100 From: Margaret Lewicka To: "Richard W.M. Jones" Subject: Patch for hivex ruby library extension Hi, Attaching a patch that fixes hivex ruby bindings on Mac, if you're interested. Wasn't sure if it belonged

[Libguestfs] [PATCH 8/8] v2v: linux: correctly reconfigure the initrd on Debian

Use the canonical way to regenerate the initrd images for all the installed kernels, i.e. reconfigure the initramfs-tools which will trigger the kernel postinst scripts. --- v2v/convert_linux.ml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/v2v/convert_linux.ml

[Libguestfs] [PATCH 4/8] v2v: linux: add /boot/grub/grub.cfg as Grub2 config

This is the location of the Grub2 configuration in Debian-based systems. --- v2v/convert_linux.ml | 1 + 1 file changed, 1 insertion(+) diff --git a/v2v/convert_linux.ml b/v2v/convert_linux.ml index 52d06bd..acc91dc 100644 --- a/v2v/convert_linux.ml +++ b/v2v/convert_linux.ml @@ -94,6 +94,7 @@

[Libguestfs] [PATCH 6/8] v2v: linux: check the kernel package name for Debian

On Debian-based systems, the kernel packages are named like "linux-image-$kver", so check for them. --- v2v/convert_linux.ml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/v2v/convert_linux.ml b/v2v/convert_linux.ml index 6ca7cdb..1800d3d 100644 --- a/v2v/convert_linux.ml

[Libguestfs] [PATCH 5/8] v2v: linux: check also kernel config for modules

When checking whether a kernel supports virtio or it is Xen-based, it is assumed that the feature has the kernel module for it; this will fail if the feature is built-in in the kernel, misrepresenting it. The solution is to check the kernel configuration (/boot/config-$kver) whether the feature

[Libguestfs] [PATCH 0/8] v2v: first bits of Debian/Ubuntu guests supports

Hi, this series implements the first bits in v2v to convert Debian/Ubuntu (and derived) guests. The series does not complete the support (see known issues below), but all the patches here should be fit for review and inclusion. The series does not enable the conversion, yet. Known issues: *

[Libguestfs] [PATCH 7/8] v2v: linux: adapt initrd name for Debian

The name of the initrd image on Debian-based systems is different from what used on Fedora/RHEL/SUSE and derived; set a different regexp to avoid making the current regexp even more complex. --- v2v/convert_linux.ml | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

[Libguestfs] [PATCH 3/8] v2v: linux: identify Debian-based distros as `Debian_family

Identify these distributions, so it is possible to add specific code for them. This does not allow them as supported distributions, yet. --- v2v/convert_linux.ml | 1 + 1 file changed, 1 insertion(+) diff --git a/v2v/convert_linux.ml b/v2v/convert_linux.ml index 65796d6..52d06bd 100644 ---

[Libguestfs] [PATCH 2/8] v2v: add basic support for the "deb" package manager

Implement the 'remove', 'file_list_of_package', and 'file_owner' methods of the Linux module for the "deb" package manager (dpkg basically, on Debian and derived distributions). Also allow it for the main conversion code. --- v2v/convert_linux.ml | 2 +- v2v/linux.ml | 23

[Libguestfs] [PATCH 1/8] v2v: refactor Linux.remove

Move the actual job in an helper function, so the common bits (like the check of the size of 'packages' and the reload of Augeas) can be done for all the package manager implementations. This should be code motion with no behaviour change. --- v2v/linux.ml | 29 - 1

Re: [Libguestfs] [PATCH] sparsify, v2v: use Common_utils.absolute_path

On Mon, Aug 08, 2016 at 05:35:38PM +0200, Pino Toscano wrote: > Use the common function for ensuring a path is absolute; it should not > change the behaviour at all. > --- > sparsify/cmdline.ml | 6 +- > v2v/input_disk.ml | 4 +--- > v2v/input_ova.ml| 4 +--- > 3 files changed, 3

[Libguestfs] [PATCH] sparsify, v2v: use Common_utils.absolute_path

Use the common function for ensuring a path is absolute; it should not change the behaviour at all. --- sparsify/cmdline.ml | 6 +- v2v/input_disk.ml | 4 +--- v2v/input_ova.ml| 4 +--- 3 files changed, 3 insertions(+), 11 deletions(-) diff --git a/sparsify/cmdline.ml

Re: [Libguestfs] [PATCH v2] v2v: disk: strip only common extension (RHBZ#1365005)

On Mon, Aug 08, 2016 at 05:21:35PM +0200, Pino Toscano wrote: > In disk input mode, to determine the guest name strip the extension from > the filename only if it's a very well extension for disk images. > --- > v2v/input_disk.ml | 18 -- > 1 file changed, 16 insertions(+), 2

[Libguestfs] [PATCH v2] v2v: disk: strip only common extension (RHBZ#1365005)

In disk input mode, to determine the guest name strip the extension from the filename only if it's a very well extension for disk images. --- v2v/input_disk.ml | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/v2v/input_disk.ml b/v2v/input_disk.ml index

Re: [Libguestfs] [PATCH] v2v: disk: strip only common extension (RHBZ#1365005)

On Mon, Aug 08, 2016 at 03:51:55PM +0200, Pino Toscano wrote: > In disk input mode, to determine the guest name strip the extension from > the filename only if it's a very well extension for disk images. > --- > v2v/input_disk.ml | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-)

[Libguestfs] [PATCH <= 1.32] appliance: Disable lvmetad.

lvmetad only works if the /run/lvm directory is created. It is normally created by systemd-tmpfiles, but prior to libguestfs 1.34 we didn't invoke systemd-tmpfiles to create directories under /run (fixed in upstream commit a6330e9d3af0f5286f1d53d909fd868387b67f69). If for some reason lvmetad

[Libguestfs] [PATCH] v2v: disk: strip only common extension (RHBZ#1365005)

In disk input mode, to determine the guest name strip the extension from the filename only if it's a very well extension for disk images. --- v2v/input_disk.ml | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/v2v/input_disk.ml b/v2v/input_disk.ml index 17ad61d..939a16b

Re: [Libguestfs] [PATCH] v2v: do not hide the error, rather report it

On Friday, 5 August 2016 12:25:03 CEST Richard W.M. Jones wrote: > On Fri, Aug 05, 2016 at 11:32:27AM +0200, Tomáš Golembiovský wrote: > > The Invalid_argument exception is there to catch unexpected situation > > when rpm returns no output. Such situation should be reported rather > > then hidden.

Re: [Libguestfs] [PATCH] v2v: fix regex replacement in grub2_update_console

On Saturday, 6 August 2016 20:04:53 CEST Tomáš Golembiovský wrote: > The replacement string was wrong. There are only two match groups in the > regular expression, not three. > > Signed-off-by: Tomáš Golembiovský > --- LGTM, pushed. Thanks, -- Pino Toscano signature.asc

Re: [Libguestfs] [libvirt-users] Cannot guestmount a Fedora 24 XFS disk.

On Fri, Aug 05, 2016 at 02:46:11PM +, Andre Goree wrote: > > I seem to be having trouble using guestmount to mount a Fedora 24 disk that > is using XFS.  This is the error messings I get when I try: > > root@cpdev-cn5:/var/lib/libvirt/images/base# guestmount --rw -a >