On Wed, 06 Feb 2019 17:02:57 +0100
Pino Toscano wrote:
> On Wednesday, 6 February 2019 14:11:41 CET Tomáš Golembiovský wrote:
> > > > + * Note that the call may succeed whithout copying any file at all.
> > > > This may
> > > > + * happen when the source subdirectory exists but is empty or when
On Wed, Feb 06, 2019 at 03:26:46PM +0100, Pino Toscano wrote:
> Newer versions do not have the 24px distributor.png icon; OTOH they have
> the 48px version, so look for that one before the 24px one.
>
> Also, bump the size limit to 10K, as newer versions of the icon are
> bigger than 3K.
> ---
>
On Wednesday, 6 February 2019 14:11:41 CET Tomáš Golembiovský wrote:
> > > + * Note that the call may succeed whithout copying any file at all. This
> > > may
> > > + * happen when the source subdirectory exists but is empty or when
> > > [filter]
> > > + * function is too strict to allow any of
> > + * Note that the call may succeed whithout copying any file at all. This
> > may
> > + * happen when the source subdirectory exists but is empty or when [filter]
> > + * function is too strict to allow any of the files.
>
> Not sure why copy_from_virtio_win should allow an empty list as sr
On Mon, 28 Jan 2019 17:39:23 +
"Richard W.M. Jones" wrote:
> On Sat, Jan 26, 2019 at 01:19:59PM +0100, Tomáš Golembiovský wrote:
> > Allow multiple alternative directory names for distributions (or
> > distribution familiy) when installing Linux guest tools packages.
> > Original naming requi
On Mon, 28 Jan 2019 17:24:15 +
"Richard W.M. Jones" wrote:
> On Sat, Jan 26, 2019 at 01:19:58PM +0100, Tomáš Golembiovský wrote:
> > The debug message was slightly changed too to better match the similar
> > message for ISO case. It refers to the root directory instead of the
> > specific sub
See individual patches.
Pino Toscano (3):
inspect: bump size limit for Mageia guests
inspect: factor out find_png helper function
inspect: revamp icon extraction for *SUSE guests
lib/inspect-icon.c | 39 +--
1 file changed, 25 insertions(+), 14 deletions
Newer versions do not have the 24px distributor.png icon; OTOH they have
the 48px version, so look for that one before the 24px one.
Also, bump the size limit to 10K, as newer versions of the icon are
bigger than 3K.
---
lib/inspect-icon.c | 10 +++---
1 file changed, 7 insertions(+), 3 delet
Newer versions of the logo in Cauldron are almost 3K, so bump the limit
to 10K for now.
---
lib/inspect-icon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/inspect-icon.c b/lib/inspect-icon.c
index 0edd3d1b0..c56d45295 100644
--- a/lib/inspect-icon.c
+++ b/lib/inspect-ic
Isolate the code for looking for a PNG file among a specified list from
the icon_ubuntu implementation, and switch that function to it.
This is just code refactoring, with no behaviour changes.
---
lib/inspect-icon.c | 27 +--
1 file changed, 17 insertions(+), 10 deletions
10 matches
Mail list logo
