Re: [Libguestfs] [PATCH nbdkit v4 06/15] delay: Allow block status (extents) requests to be separately delayed.

2019-03-27 Thread Eric Blake
On 3/26/19 4:17 PM, Richard W.M. Jones wrote: > --- > filters/delay/nbdkit-delay-filter.pod | 8 > filters/delay/delay.c | 26 ++ > 2 files changed, 34 insertions(+) > > diff --git a/filters/delay/nbdkit-delay-filter.pod > b/filters/delay/nbdkit-

Re: [Libguestfs] [PATCH nbdkit v4 05/15] cow: Disable extents information in this filter.

2019-03-27 Thread Eric Blake
On 3/26/19 4:17 PM, Richard W.M. Jones wrote: > The cow filter doesn't support trimming and we should assume the > underlying plugin is fully allocated too. Note that both of these > limitations might be lifted with a more advanced filter > implementation. > > However we ought to support this in

Re: [Libguestfs] [PATCH nbdkit v4 04/15] blocksize: Implement extents.

2019-03-27 Thread Eric Blake
On 3/26/19 4:17 PM, Richard W.M. Jones wrote: > --- > filters/blocksize/nbdkit-blocksize-filter.pod | 4 ++-- > filters/blocksize/blocksize.c | 19 +++ > 2 files changed, 21 insertions(+), 2 deletions(-) ACK. -- Eric Blake, Principal Software Engineer Red Hat, I

Re: [Libguestfs] [PATCH] v2v: windows: save log file from rhev-apt installer

2019-03-27 Thread Pino Toscano
On Monday, 25 March 2019 16:06:26 CET Richard W.M. Jones wrote: > On Thu, Feb 14, 2019 at 02:38:21PM +0100, Tomáš Golembiovský wrote: > > Store log from MSI installer. Log file will be located in firstboot > > scripts-done directory with name rhev-apt.log. The path has to be > > double-quoted to ha

Re: [Libguestfs] [PATCH v2 1/3] v2v: fix path to source when copying files from guest tools directory

2019-03-27 Thread Pino Toscano
On Thursday, 21 March 2019 10:36:47 CET Pino Toscano wrote: > On Friday, 8 February 2019 11:44:41 CET Tomáš Golembiovský wrote: > > The debug message was slightly changed too to better match the similar > > message for ISO case. It refers to the root directory instead of the > > specific subdirecto

Re: [Libguestfs] [PATCH 4/4] OCaml tools: output messages into JSON for machine readable

2019-03-27 Thread Tomáš Golembiovský
On Fri, 22 Mar 2019 16:33:43 +0100 Pino Toscano wrote: > When the machine readable mode is enabled, print all the messages > (progress, info, warning, and errors) also as JSON in the machine > readable stream: this way, users can easily parse the status of the > OCaml tool, and report that back.

Re: [Libguestfs] [PATCH nbdkit 7/8] vddk: Implement extents.

2019-03-27 Thread Richard W.M. Jones
FYI I now have a VDDK extents function which now works and is tested against a real server on real guests: https://github.com/rwmjones/nbdkit/commit/b327a79ee3fa0af0fe27d5d18ac7b5f44a7c243e There were quite a lot of changes: - The offset and length of the hole before each block was plain

Re: [Libguestfs] [PATCH 0/3] v2v: improve RHV guest tools installation

2019-03-27 Thread Tomáš Golembiovský
On Tue, 26 Mar 2019 18:02:39 +0100 Pino Toscano wrote: > This series slightly improves the way qemu-ga is installed from the > RHV Tools ISO, simplifying the feedback to the user. > > Patch #3 sort of conflicts with patch #2 of a related series by > Tomáš Golembiovský: > https://www.redhat.com/a

Re: [Libguestfs] [PATCH nbdkit 7/8] vddk: Implement extents.

2019-03-27 Thread Eric Blake
On 3/27/19 7:17 AM, Richard W.M. Jones wrote: >>> This inner loop might be long; you could add this: >>> >>> if (req_one) >>> break; > > So interestingly _no_ you can't add that here, and the reason does > reveal why the REQ_ONE flag is still hard to get right even with the > simpler implementa

Re: [Libguestfs] [PATCH nbdkit 7/8] vddk: Implement extents.

2019-03-27 Thread Richard W.M. Jones
On Mon, Mar 25, 2019 at 05:34:25PM +, Richard W.M. Jones wrote: > On Sat, Mar 23, 2019 at 02:29:54PM -0500, Eric Blake wrote: > > On 3/20/19 5:11 PM, Richard W.M. Jones wrote: > ... > > > +for (i = 0; i < block_list->numBlocks; ++i) { > > > + uint64_t offset, length; > > > + > > > +

Re: [Libguestfs] [PATCH] lib: direct: Set QEMU_AUDIO_DRV=none when testing schema.

2019-03-27 Thread Pino Toscano
On Saturday, 23 March 2019 19:11:21 CET Richard W.M. Jones wrote: > Schema parsing was failing with errors such as: > > libguestfs: QMP parse error: '[' or '{' expected near end of file (ignored) > > This happened because the QMP command was actually completely failing > and never printing a resu

Re: [Libguestfs] [PATCH 3/3] v2v: change the reporting of RHV Tools messages/warnings/error

2019-03-27 Thread Richard W.M. Jones
On Tue, Mar 26, 2019 at 06:02:42PM +0100, Pino Toscano wrote: > The RHV Tools ISO is provided as Red Hat only product, and thus not > available for all the virt-v2v users. Hence, change the way we report > the status of the installation of the qemu guest agent from the RHV > Tools ISO: > - do not

Re: [Libguestfs] [PATCH 2/3] v2v: try to pick the right arch for qemu-ga pkgs

2019-03-27 Thread Richard W.M. Jones
On Tue, Mar 26, 2019 at 06:02:41PM +0100, Pino Toscano wrote: > Right now the code copies, and then tries to install, all the files > found for the directory of a distro. This does not take into account > differences in the architectures of the packages available, so a x86_64 > package must be ins

Re: [Libguestfs] [PATCH 1/3] v2v: linux: add helper functions for pkg arch and extension

2019-03-27 Thread Richard W.M. Jones
On Tue, Mar 26, 2019 at 06:02:40PM +0100, Pino Toscano wrote: > Add helper functions to get the typical extension of binary packages > for a package manager, and the string for an architecture. > --- > v2v/linux.ml | 21 + > v2v/linux.mli | 8 > 2 files changed, 29 i

Re: [Libguestfs] [PATCH nbdkit v4 01/15] server: Implement extents/can_extents calls for plugins and filters.

2019-03-27 Thread Richard W.M. Jones
On Wed, Mar 27, 2019 at 09:49:10AM +, Richard W.M. Jones wrote: > I'll clarify it by saying "The C parameter to C ... I mean, "The C parameter of the C<.extents> callback ..." Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virt

Re: [Libguestfs] [PATCH nbdkit v4 01/15] server: Implement extents/can_extents calls for plugins and filters.

2019-03-27 Thread Richard W.M. Jones
On Wed, Mar 27, 2019 at 01:56:57AM -0500, Eric Blake wrote: > On 3/26/19 4:17 PM, Richard W.M. Jones wrote: > > This pair of calls allows plugins to describe which extents in the > > virtual disk are allocated, holes or zeroes. > > --- > > > +=head2 C<.extents> > > + > > + int extents (void *handl