Re: [Libguestfs] [PATCH v2v] v2v: -o rhv-upload: Make -oo rhv-cafile optional in all cases (RHBZ#1791240).

On Wed, Jan 15, 2020 at 3:01 PM Richard W.M. Jones wrote: > This is actually not required, because ovirtsdk4 will use the system's > global trust store if necessary. Therefore we can make it optional in > all cases. > The only way to avoid the cafile is to set insecure=True both when creating s

Re: [Libguestfs] [PATCH v2] add versioned directory for guest agent on EL8

On Thu, Jan 16, 2020 at 04:05:10PM +0100, Tomáš Golembiovský wrote: > There was no source directory for EL8 guest agent (only EL6 and EL7). > > RHBZ#1791802 > > Signed-off-by: Tomáš Golembiovský > --- > v2v/windows_virtio.ml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/v2v/windows_

Re: [Libguestfs] [PATCH] launch: libvirt: use machine type when querying for domcaps

On Thu, Jan 16, 2020 at 03:53:20PM +0100, Pino Toscano wrote: > On some architectures a certain machine type is used, so use it when > querying the libvirt domain capabilities. > --- > lib/launch-libvirt.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/lib/launch-l

Re: [Libguestfs] [PATCH] add default (unversioned) directory for guest agent on EL

On Thu, Jan 16, 2020 at 03:02:52PM +0100, Tomáš Golembiovský wrote: > There was no source directory for EL8 guest agent (only EL6 and EL7). > > RHBZ#1791802 > > Signed-off-by: Tomáš Golembiovský > --- > v2v/windows_virtio.ml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --gi

Re: [Libguestfs] [PATCH 0/4] Use libvirt firmware autoselection

The patch series looks fine to me. TBH I'm not really bothered about verbose using a non-debug firmware. It's rare that we would need to actually debug a UEFI issue, plus the debug output of UEFI is kind of crazy. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~r

[Libguestfs] [PATCH v2] add versioned directory for guest agent on EL8

There was no source directory for EL8 guest agent (only EL6 and EL7). RHBZ#1791802 Signed-off-by: Tomáš Golembiovský --- v2v/windows_virtio.ml | 1 + 1 file changed, 1 insertion(+) diff --git a/v2v/windows_virtio.ml b/v2v/windows_virtio.ml index 5ec7664b..86bc8c0a 100644 --- a/v2v/windows_virt

[Libguestfs] [PATCH] launch: libvirt: use machine type when querying for domcaps

On some architectures a certain machine type is used, so use it when querying the libvirt domain capabilities. --- lib/launch-libvirt.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/lib/launch-libvirt.c b/lib/launch-libvirt.c index 864eae314..f2cad9300 100644 --- a/lib/

Re: [Libguestfs] [PATCH v2v] v2v: -o rhv-upload: Make -oo rhv-cafile optional in all cases (RHBZ#1791240).

On Wednesday, 15 January 2020 14:01:11 CET Richard W.M. Jones wrote: > This is actually not required, because ovirtsdk4 will use the system's > global trust store if necessary. Therefore we can make it optional in > all cases. > --- LGTM. Thanks, -- Pino Toscano signature.asc Description: This

Re: [Libguestfs] [PATCH] add default (unversioned) directory for guest agent on EL

On Thursday, 16 January 2020 15:02:52 CET Tomáš Golembiovský wrote: > There was no source directory for EL8 guest agent (only EL6 and EL7). > > RHBZ#1791802 > > Signed-off-by: Tomáš Golembiovský > --- > v2v/windows_virtio.ml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --gi

[Libguestfs] [PATCH] add default (unversioned) directory for guest agent on EL

There was no source directory for EL8 guest agent (only EL6 and EL7). RHBZ#1791802 Signed-off-by: Tomáš Golembiovský --- v2v/windows_virtio.ml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/v2v/windows_virtio.ml b/v2v/windows_virtio.ml index 5ec7664b..6ddc488a 100644 --- a/

Re: [Libguestfs] [PATCH 2/2] Win::Hivex::Regedit: Ignore comments

Thanks, I have pushed these two upstream. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-builder quickly builds VMs from scratch http://libguestfs.org/virt-builder.1.html __

Re: [Libguestfs] [PATCH 0/4] Use libvirt firmware autoselection

On Thu, Jan 16, 2020 at 01:49:09PM +0100, Michal Privoznik wrote: > On 1/16/20 1:27 PM, Pino Toscano wrote: > > Starting with 5.2.0, libvirt has a way to select the firmware by > > specifying its type, provided configuration files for the firmware are > > shipped. Currently we start the appliance a

Re: [Libguestfs] [PATCH 0/4] Use libvirt firmware autoselection

On 1/16/20 1:27 PM, Pino Toscano wrote: Starting with 5.2.0, libvirt has a way to select the firmware by specifying its type, provided configuration files for the firmware are shipped. Currently we start the appliance as UEFI if any of the firmware are found, so instead we can try to just set the

[Libguestfs] [PATCH 3/4] lib: allow to use libvirt firmware autoselection

Enhance the UEFi firmware lookup function with the information on the libvirt firmware autoselection, allowing it to return a value to use for the appliance. At the moment no firmware is selected this way, so there is no behaviour change. --- lib/appliance-uefi.c | 18 ++ lib/gu

[Libguestfs] [PATCH 2/4] lib: uefi: reset out parameters earlier

Make sure they are always reset, no matter the code branches later on. This is mostly code motion. --- lib/appliance-uefi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/appliance-uefi.c b/lib/appliance-uefi.c index 5fca8cd37..138a8d2f9 100644 --- a/lib/appliance-ue

[Libguestfs] [PATCH 1/4] launch: libvirt: parse firmware autoselection

Parse from the domain capabilities whether libvirt supports the autoselection of firmware, and which values are supported. --- lib/launch-libvirt.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/lib/launch-libvirt.c b/lib/launch-libvirt.c index 95aed8054..fa7b6

[Libguestfs] [PATCH 4/4] lib: uefi: use the efi libvirt firmware if available

In case libvirt supports the firmware autoselection and there is an EFI firmware available, use it directly instead of handling the firmware manually. --- lib/appliance-uefi.c | 9 + 1 file changed, 9 insertions(+) diff --git a/lib/appliance-uefi.c b/lib/appliance-uefi.c index d2908867c..

[Libguestfs] [PATCH 0/4] Use libvirt firmware autoselection

Starting with 5.2.0, libvirt has a way to select the firmware by specifying its type, provided configuration files for the firmware are shipped. Currently we start the appliance as UEFI if any of the firmware are found, so instead we can try to just set the firmware type iff: - the libvirt autosele

[Libguestfs] [PATCH 2/2] Win::Hivex::Regedit: Ignore comments

--- perl/lib/Win/Hivex/Regedit.pm | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/perl/lib/Win/Hivex/Regedit.pm b/perl/lib/Win/Hivex/Regedit.pm index 2b17036..f0dbb50 100644 --- a/perl/lib/Win/Hivex/Regedit.pm +++ b/perl/lib/Win/Hivex/Regedit.pm @@ -153,8 +153,8 @@ sub re

[Libguestfs] [PATCH 1/2] Win::Hivex::Regedit: Accept CRLF line endings

--- perl/lib/Win/Hivex/Regedit.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/perl/lib/Win/Hivex/Regedit.pm b/perl/lib/Win/Hivex/Regedit.pm index 34426f1..2b17036 100644 --- a/perl/lib/Win/Hivex/Regedit.pm +++ b/perl/lib/Win/Hivex/Regedit.pm @@ -144,6 +144,7 @@ sub reg_import # th

Re: [Libguestfs] [PATCH] build: define HAVE_PYCODESTYLE in all the cases

On Wed, Jan 15, 2020 at 03:38:10PM +0100, Pino Toscano wrote: > Fixes commit cad3ea9e74bcff0dd42dc2a3710c6b3fa6e868b1 in case Python is > disabled, or not available. > --- > m4/guestfs-python.m4 | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/m4/guestfs-python.m4 b/m4/g