[Libguestfs] [PATCH 2/3] lib/proto: suppress "may be used uninitialized" in send_file_complete()

2021-10-11 Thread Laszlo Ersek
gcc emits the following warning: > proto.c: In function ‘send_file_complete’: > proto.c:437:10: error: ‘buf’ may be used uninitialized > [-Werror=maybe-uninitialized] > 437 | return send_file_chunk (g, 0, buf, 0); > | ^~ In theory, passing the

[Libguestfs] [PATCH 1/3] build: fix typo in "--enable-werror" help string

2021-10-11 Thread Laszlo Ersek
While correctly documents the "--enable-werror" option, the "./configure" help text itself doesn't. Replace "--enable-error" with "--enable-werror" now. Fixes: 0f54df53d26e4c293871fb30bce88511e1d61d6c Signed-off-by: Laszlo Ersek ---

[Libguestfs] [PATCH 3/3] daemon/yara: fix undefined behavior due to Yara 4.0 API changes

2021-10-11 Thread Laszlo Ersek
Currently, the Yara test case ("yara/test-yara-scan.sh") fails, with the following obscure error message: > > yara-scan /text.txt > libguestfs: error: deserialise_yara_detection_list: Namely, the Yara rule match list serialization / de-serialization, between the daemon and the library, is

[Libguestfs] [PATCH 0/3] daemon/yara: fix undefined behavior due to Yara 4.0 API changes

2021-10-11 Thread Laszlo Ersek
I *almost* got around looking at RHBZ#1995391 again, but then I pulled master to build a new baseline, and then: - the Yara test case failed (I had recently installed the Yara devel package), - it turns out the test case failure comes from a genuine bug, - it turns out that gcc warns about

Re: [Libguestfs] [PATCH RFC v2 5/5] block: Deprecate transaction type drive-backup

2021-10-11 Thread Eric Blake
On Sat, Oct 09, 2021 at 02:09:44PM +0200, Markus Armbruster wrote: > Several moons ago, Vladimir posted > > Subject: [PATCH v2 3/3] qapi: deprecate drive-backup > Date: Wed, 5 May 2021 16:58:03 +0300 > Message-Id: <20210505135803.67896-4-vsement...@virtuozzo.com> >

Re: [Libguestfs] [PATCH v2 4/5] qapi: Implement deprecated-input={reject, crash} for enum values

2021-10-11 Thread Eric Blake
On Sat, Oct 09, 2021 at 02:09:43PM +0200, Markus Armbruster wrote: > This copies the code implementing the policy from qapi/qmp-dispatch.c > to qapi/qobject-input-visitor.c. Tolerable, but if we acquire more > copes, we should look into factoring them out. copies > > Signed-off-by: Markus

Re: [Libguestfs] [PATCH v2 1/5] qapi: Enable enum member introspection to show more than name

2021-10-11 Thread Eric Blake
On Sat, Oct 09, 2021 at 02:09:40PM +0200, Markus Armbruster wrote: > The next commit will add feature flags to enum members. There's a > problem, though: query-qmp-schema shows an enum type's members as an > array of member names (SchemaInfoEnum member @values). If it showed > an array of