John Snow writes:
> On Mon, Oct 25, 2021 at 1:26 AM Markus Armbruster wrote:
>
>> By convention, names starting with "x-" are experimental. The parts
>> of external interfaces so named may be withdrawn or changed
>> incompatibly in future releases.
>>
>> Drawback: promoting something from
Pipeline #395096064 has failed!
Project: libnbd ( https://gitlab.com/nbdkit/libnbd )
Branch: master ( https://gitlab.com/nbdkit/libnbd/-/commits/master )
Commit: 5d7b9f16 (
https://gitlab.com/nbdkit/libnbd/-/commit/5d7b9f16f7f037df5e5274d488780402a62e
)
Commit Message: golang: Fix
---
tests/functions.sh.in| 10 ++
tests/test-ip-filter-anyvsock.sh | 1 +
tests/test-nbd-vsock.sh | 1 +
tests/test-vsock.sh | 1 +
4 files changed, 13 insertions(+)
diff --git a/tests/functions.sh.in b/tests/functions.sh.in
index 403fa56e..d6c4255c
On Mon, Oct 25, 2021 at 1:25 AM Markus Armbruster wrote:
> The code to check policy for handling deprecated input is triplicated.
> Factor it out into compat_policy_input_ok() before I mess with it in
> the next commit.
>
> Signed-off-by: Markus Armbruster
>
(Skipping C-only patches for quick
On Mon, Oct 25, 2021 at 1:26 AM Markus Armbruster wrote:
> New option parameters unstable-input and unstable-output set policy
> for unstable interfaces just like deprecated-input and
> deprecated-output set policy for deprecated interfaces (see commit
> 6dd75472d5 "qemu-options: New -compat to
On Mon, Oct 25, 2021 at 1:26 AM Markus Armbruster wrote:
> The code to check enumeration value policy can see special feature
> flag 'deprecated' in QEnumLookup member flags[value]. I want to make
> feature flag 'unstable' visible there as well, so I can add policy for
> it.
>
> Instead of
On Mon, Oct 25, 2021 at 1:25 AM Markus Armbruster wrote:
> The code to check command policy can see special feature flag
> 'deprecated' as command flag QCO_DEPRECATED. I want to make feature
> flag 'unstable' visible there as well, so I can add policy for it.
>
> To let me make it visible, add
On Mon, Oct 25, 2021 at 1:25 AM Markus Armbruster wrote:
> The generated visitor functions call visit_deprecated_accept() and
> visit_deprecated() when visiting a struct member with special feature
> flag 'deprecated'. This makes the feature flag visible to the actual
> visitors. I want to
On Mon, Oct 25, 2021 at 1:25 AM Markus Armbruster wrote:
> New enum QapiSpecialFeature enumerates the special feature flags.
>
> New helper gen_special_features() returns code to represent a
> collection of special feature flags as a bitset.
>
> The next few commits will put them to use.
>
>
On Mon, Oct 25, 2021 at 1:25 AM Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster
> ---
> include/qapi/qmp/dispatch.h | 1 -
> monitor/misc.c | 3 +--
> scripts/qapi/commands.py| 5 +
> 3 files changed, 2 insertions(+), 7 deletions(-)
>
> diff --git
On Mon, Oct 25, 2021 at 1:25 AM Markus Armbruster wrote:
> Add special feature 'unstable' everywhere the name starts with 'x-',
> except for InputBarrierProperties member x-origin and
> MemoryBackendProperties member x-use-canonical-path-for-ramblock-id,
> because these two are actually stable.
On Mon, Oct 25, 2021 at 1:26 AM Markus Armbruster wrote:
> By convention, names starting with "x-" are experimental. The parts
> of external interfaces so named may be withdrawn or changed
> incompatibly in future releases.
>
> Drawback: promoting something from experimental to stable involves
On Mon, Oct 25, 2021 at 10:01 AM Richard W.M. Jones
wrote:
> > But even if "libguestfs.org/libnbd" would work, we cannot use the
> > module from the source
> > since the source is missing the generated files (wrappers.go,
binding.go, ...).
> I believe that Matthew hit this problem too ...
(I
On 10/25/21 14:05, Kashyap Chamarthy wrote:
> On Mon, Oct 25, 2021 at 07:25:24AM +0200, Markus Armbruster wrote:
>> By convention, names starting with "x-" are experimental. The parts
>> of external interfaces so named may be withdrawn or changed
>> incompatibly in future releases.
>>
>>
On 10/25/21 07:25, Markus Armbruster wrote:
> The code to check policy for handling deprecated input is triplicated.
> Factor it out into compat_policy_input_ok() before I mess with it in
> the next commit.
>
> Signed-off-by: Markus Armbruster
> ---
> include/qapi/compat-policy.h | 7 +
>
On 10/25/21 07:25, Markus Armbruster wrote:
> The code to check command policy can see special feature flag
> 'deprecated' as command flag QCO_DEPRECATED. I want to make feature
> flag 'unstable' visible there as well, so I can add policy for it.
>
> To let me make it visible, add member
On Mon, Oct 25, 2021 at 08:05:47PM +0300, Nir Soffer wrote:
> On Mon, Oct 25, 2021 at 4:45 PM Nir Soffer wrote:
> >
> > I'm playing with libnbd go module, planning to use it in a new command[1]
> >
> > The biggest obstacle for me is that the module is not published in a way
> > that
> > Go
On Mon, Oct 25, 2021 at 4:45 PM Nir Soffer wrote:
>
> I'm playing with libnbd go module, planning to use it in a new command[1]
>
> The biggest obstacle for me is that the module is not published in a way that
> Go developers expect.
>
> The module is listed in:
>
Couple of months back I was playing with GitHub Actions so that the
libnbd-go is regenerated after each commit and the changes pushed into a
separate repository, tagging it if tag was pushed as well.
Unfortunately more pressing things came my way and I did not finish this
work. Now I am making
On Mon, Oct 25, 2021 at 05:22:28PM +0300, Nir Soffer wrote:
> On Mon, Oct 25, 2021 at 5:01 PM Richard W.M. Jones wrote:
> >
> > [Adding Matthew]
> >
> > On Mon, Oct 25, 2021 at 04:45:03PM +0300, Nir Soffer wrote:
> > > I'm playing with libnbd go module, planning to use it in a new command[1]
> >
On Mon, Oct 25, 2021 at 03:04:47PM +0100, Daniel P. Berrangé wrote:
> On Mon, Oct 25, 2021 at 04:45:03PM +0300, Nir Soffer wrote:
> > I'm playing with libnbd go module, planning to use it in a new command[1]
> >
> > The biggest obstacle for me is that the module is not published in a way
> >
On Mon, Oct 25, 2021 at 5:01 PM Richard W.M. Jones wrote:
>
> [Adding Matthew]
>
> On Mon, Oct 25, 2021 at 04:45:03PM +0300, Nir Soffer wrote:
> > I'm playing with libnbd go module, planning to use it in a new command[1]
> >
> > The biggest obstacle for me is that the module is not published in a
On Mon, Oct 25, 2021 at 5:04 PM Daniel P. Berrangé wrote:
>
> On Mon, Oct 25, 2021 at 04:45:03PM +0300, Nir Soffer wrote:
> > I'm playing with libnbd go module, planning to use it in a new command[1]
> >
> > The biggest obstacle for me is that the module is not published in a way
> > that
> > Go
On Mon, Oct 25, 2021 at 04:45:03PM +0300, Nir Soffer wrote:
> I'm playing with libnbd go module, planning to use it in a new command[1]
>
> The biggest obstacle for me is that the module is not published in a way that
> Go developers expect.
>
> The module is listed in:
>
[Adding Matthew]
On Mon, Oct 25, 2021 at 04:45:03PM +0300, Nir Soffer wrote:
> I'm playing with libnbd go module, planning to use it in a new command[1]
>
> The biggest obstacle for me is that the module is not published in a way that
> Go developers expect.
>
> The module is listed in:
>
I'm playing with libnbd go module, planning to use it in a new command[1]
The biggest obstacle for me is that the module is not published in a way that
Go developers expect.
The module is listed in:
https://pkg.go.dev/github.com/libguestfs/libnbd/golang
But the module actually lives in:
On Mon, Oct 25, 2021 at 07:25:24AM +0200, Markus Armbruster wrote:
> By convention, names starting with "x-" are experimental. The parts
> of external interfaces so named may be withdrawn or changed
> incompatibly in future releases.
>
> Drawback: promoting something from experimental to stable
Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster
Reviewed-by: Juan Quintela
___
Libguestfs mailing list
Libguestfs@redhat.com
https://listman.redhat.com/mailman/listinfo/libguestfs
Markus Armbruster wrote:
> Add special feature 'unstable' everywhere the name starts with 'x-',
> except for InputBarrierProperties member x-origin and
> MemoryBackendProperties member x-use-canonical-path-for-ramblock-id,
> because these two are actually stable.
>
> Signed-off-by: Markus
Markus Armbruster wrote:
> By convention, names starting with "x-" are experimental. The parts
> of external interfaces so named may be withdrawn or changed
> incompatibly in future releases.
>
> Drawback: promoting something from experimental to stable involves a
> name change. Client code
30 matches
Mail list logo
