Re: [Libguestfs] [libnbd PATCH 3/2] python: Slice pread_structured buffer from original

2022-06-01 Thread Nir Soffer
On Wed, Jun 1, 2022 at 3:24 AM Eric Blake wrote: > > On Wed, Jun 01, 2022 at 02:20:48AM +0300, Nir Soffer wrote: > > On Tue, May 31, 2022 at 6:52 PM Eric Blake wrote: > > > > > > On Tue, May 31, 2022 at 10:49:03AM -0500, Eric Blake wrote: > > > > This patch fixes the corner-case regression

Re: [Libguestfs] [libnbd PATCH 1/2] api: Tighter checking of structured read replies

2022-06-01 Thread Eric Blake
On Tue, May 31, 2022 at 10:32:23PM +0300, Nir Soffer wrote: > > > But we can have this case: > > > > > > 1. ask for 32m > > > 2. server sends 16m (data_seen increase to 16m) > > > 3. server sends 16m (data_seen increase to 32m) > > > 4. server sends 1m (data_seen does not increase) > > > > Yes it

Re: [Libguestfs] [nbdkit PATCH v2] blocksize: Avoid losing aligned writes to RMW race

2022-06-01 Thread Eric Blake
On Fri, May 27, 2022 at 11:06:23AM -0500, Eric Blake wrote: > On Fri, May 27, 2022 at 11:19:24AM +0100, Richard W.M. Jones wrote: > > On Thu, May 26, 2022 at 04:00:08PM -0500, Eric Blake wrote: > > > [We are still investigating if a CVE needs to be assigned.] > > > > > > > Reviewed-by: Richard

Re: [Libguestfs] [nbdkit PATCH] linuxdisk: Reduce size of test

2022-06-01 Thread Eric Blake
On Wed, Jun 01, 2022 at 10:15:52AM +0200, Laszlo Ersek wrote: > On 05/31/22 23:10, Eric Blake wrote: > > Using all of ../plugins as the contents for the linuxdisk gets > > progressively bigger over time with incremental builds. Before I > > cleaned it up, my plugins/rust/target/debug had

Re: [Libguestfs] [libnbd PATCH 3/2] python: Slice pread_structured buffer from original

2022-06-01 Thread Richard W.M. Jones
I agree with Nir's feedback and R-b's and don't have anything else to add. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com virt-p2v converts physical machines to virtual machines.

Re: [Libguestfs] [libnbd PATCH 3/2] python: Slice pread_structured buffer from original

2022-06-01 Thread Richard W.M. Jones
On Tue, May 31, 2022 at 07:24:03PM -0500, Eric Blake wrote: > On Wed, Jun 01, 2022 at 02:20:48AM +0300, Nir Soffer wrote: > > Does this work? > > > > PySlice_New(NULL, NULL, NULL); > > PySlice_AdjustIndices(length, start, stop, step); > > New in python 3.6.1. README says we still target

Re: [Libguestfs] [libnbd PATCH 3/2] python: Slice pread_structured buffer from original

2022-06-01 Thread Richard W.M. Jones
On Tue, May 31, 2022 at 10:52:35AM -0500, Eric Blake wrote: > And I really wish python didn't make it so hard to grab a slice of > another object using C code. Having to create 3 temporary PyObjects > instead of having a utility C function that takes normal integers was > annoying. You can add

Re: [Libguestfs] [nbdkit PATCH] linuxdisk: Reduce size of test

2022-06-01 Thread Richard W.M. Jones
On Tue, May 31, 2022 at 04:10:07PM -0500, Eric Blake wrote: > Using all of ../plugins as the contents for the linuxdisk gets > progressively bigger over time with incremental builds. Before I > cleaned it up, my plugins/rust/target/debug had accumulated over 6G of > cruft, causing

Re: [Libguestfs] [nbdkit PATCH] linuxdisk: Reduce size of test

2022-06-01 Thread Laszlo Ersek
On 05/31/22 23:10, Eric Blake wrote: > Using all of ../plugins as the contents for the linuxdisk gets > progressively bigger over time with incremental builds. Before I > cleaned it up, my plugins/rust/target/debug had accumulated over 6G of > cruft, causing test-linuxdisk-copy-out.sh to fail due