[Libguestfs] [PATCH virt-v2v 2/3] test-data/phony-guests: Allow virt-v2v to work against phony Fedora

2022-06-08 Thread Richard W.M. Jones
We didn't use the phony Fedora guest before with virt-v2v (only the phony Windows image). This commit makes miscellaneous changes so that it can be used for testing: - Add dummy rpm and dracut commands. - Add dummy kernel, initramfs and modules directory. - Add dummy grub configuration

[Libguestfs] [PATCH virt-v2v 3/3] tests: Add test cases for converting the phony Fedora images

2022-06-08 Thread Richard W.M. Jones
As well as testing a full Fedora conversion which was not really tested properly before, this also adds tests of conversions of Btrfs, RAID and LUKS guests. --- tests/Makefile.am | 8 ++ tests/test-v2v-fedora-btrfs-conversion.sh | 31 +

[Libguestfs] [PATCH virt-v2v 0/3] tests: Add a phony Fedora image for testing

2022-06-08 Thread Richard W.M. Jones
When we split virt-v2v from libguestfs many moons ago, I copied the test-data/ subdirectory over. I didn't modify it much, and it contains much test data that is irrelevant to virt-v2v. (This change does _not_ clean up any of that ...) However we did use the phony Windows image

[Libguestfs] [PATCH virt-v2v 1/3] test-data/phony-guests: Increase size of root filesystem

2022-06-08 Thread Richard W.M. Jones
Avoid this error in virt-v2v when trying to convert the phony Fedora guest image: [ 8.1] Checking for sufficient free disk space in the guest virt-v2v: error: not enough free space for conversion on filesystem ‘/’. 21.6 MB free < 100 MB needed --- test-data/phony-guests/make-fedora-img.pl | 4

Re: [Libguestfs] [v2v PATCH 4/4] convert_linux: install the QEMU guest agent with a firstboot script

2022-06-08 Thread Laszlo Ersek
On 06/07/22 17:22, Richard W.M. Jones wrote: > On Tue, Jun 07, 2022 at 01:59:30PM +0100, Richard W.M. Jones wrote: >> On Mon, Jun 06, 2022 at 04:19:41PM +0200, Laszlo Ersek wrote: >>> +(* Disable SELinux temporarily around package installation. >>> Refer to >>> + *

Re: [Libguestfs] [v2v PATCH 0/4] convert_linux: install the QEMU guest agent with a firstboot script

2022-06-08 Thread Laszlo Ersek
On 06/07/22 15:07, Richard W.M. Jones wrote: > On Tue, Jun 07, 2022 at 01:39:53PM +0100, Richard W.M. Jones wrote: >> OTOH ... my comment here: >> >> https://bugzilla.redhat.com/show_bug.cgi?id=2028764#c2 >> >> was about more social issues where we've not been able to put the >> qemu-ga RPMs on

Re: [Libguestfs] [v2v PATCH 4/4] convert_linux: install the QEMU guest agent with a firstboot script

2022-06-08 Thread Laszlo Ersek
On 06/07/22 14:59, Richard W.M. Jones wrote: > On Mon, Jun 06, 2022 at 04:19:41PM +0200, Laszlo Ersek wrote: >> Register a firstboot script, for installing the guest agent with the >> guest's own package manager -- that is, "Guest_packages.install_command". >> >> For installing the package,

Re: [Libguestfs] [v2v PATCH 1/4] output/create_libvirt_xml: wire up the QEMU guest agent

2022-06-08 Thread Laszlo Ersek
On 06/07/22 14:43, Richard W.M. Jones wrote: > > The patch looks OK, but qemu-ga supports vsock (-m listen-vsock), so > wouldn't it be easier to use that? I thought that virtio-serial was > unmaintained these days and so vsock would be preferred. I've not heard of qga using vsock. While that