Re: [Libguestfs] [nbdkit PATCH] rust: prevent dead_code warning

2022-10-14 Thread alan somers
The best strategy for Mockall consumers is to use the #[allow(dead_code)] just like you did. Or else, you know, to bug Mockall's maintainer to release the patch ;) On Fri, Oct 14, 2022, 2:59 PM Thomas Weißschuh wrote: > On 2022-10-14 21:54+0100, Richard W.M. Jones wrote: > > On Fri, Oct 14,

Re: [Libguestfs] [nbdkit PATCH] rust: prevent dead_code warning

2022-10-14 Thread Thomas Weißschuh
On 2022-10-14 21:54+0100, Richard W.M. Jones wrote: > On Fri, Oct 14, 2022 at 10:42:30PM +0200, Thomas Weißschuh wrote: > > rustc 1.64.0 generates warnings for the mocked Server. > > This leads to a failure of test.sh. > > > > ``` > > warning: associated function `expect` is never used > > -->

Re: [Libguestfs] [nbdkit PATCH] rust: prevent dead_code warning

2022-10-14 Thread Richard W.M. Jones
On Fri, Oct 14, 2022 at 10:42:30PM +0200, Thomas Weißschuh wrote: > rustc 1.64.0 generates warnings for the mocked Server. > This leads to a failure of test.sh. > > ``` > warning: associated function `expect` is never used > --> tests/common/mod.rs:49:1 >| > 49 | / mock!{ > 50 | | pub

[Libguestfs] [nbdkit PATCH] rust: prevent dead_code warning

2022-10-14 Thread Thomas Weißschuh
rustc 1.64.0 generates warnings for the mocked Server. This leads to a failure of test.sh. ``` warning: associated function `expect` is never used --> tests/common/mod.rs:49:1 | 49 | / mock!{ 50 | | pub Server {} 51 | | impl Server for Server { 52 | | fn cache(, count: u32,

Re: [Libguestfs] bug in gnutls_init()

2022-10-14 Thread Richard W.M. Jones
On Thu, Oct 13, 2022 at 02:04:34PM -0500, Eric Blake wrote: > I just fixed a bug in nbdkit for incorrectly calling > free(gnutls_session_t) after gnutls_init(, ...) fails: > https://gitlab.com/nbdkit/nbdkit/-/commit/40faf3dfb20c06b9c5faa0a122607e3ae7c6202a > > But in the process, I was browsing

Re: [Libguestfs] libnbd | Failed pipeline for master | 018d55a8

2022-10-14 Thread Jim Fehlig
Hi Daniel, Thanks for the detailed report! On 10/13/22 03:33, Daniel P. Berrangé wrote: On Thu, Oct 13, 2022 at 09:49:09AM +0100, Richard W.M. Jones wrote: On Wed, Oct 12, 2022 at 02:00:21PM -0500, Eric Blake wrote: Job #3163966643 ( https://gitlab.com/nbdkit/libnbd/-/jobs/3163966643/raw )

Re: [Libguestfs] libnbd | Failed pipeline for master | 018d55a8

2022-10-14 Thread Daniel P . Berrangé
On Thu, Oct 13, 2022 at 03:02:51PM -0600, Jim Fehlig wrote: > Hi Daniel, > > Thanks for the detailed report! > > On 10/13/22 03:33, Daniel P. Berrangé wrote: > > On Thu, Oct 13, 2022 at 09:49:09AM +0100, Richard W.M. Jones wrote: > > > On Wed, Oct 12, 2022 at 02:00:21PM -0500, Eric Blake wrote: