Re: [Libguestfs] [libnbd PATCH 1/2] api: Add LIBNBD_STRICT_PAYLOAD to honor qemu 32M write limit

2022-11-10 Thread Laszlo Ersek
On 11/10/22 00:26, Eric Blake wrote: > Modern qemu tends to advertise a strict 32M payload limit. Yet we > default to allowing the user to attempt up to 64M in pwrite. For > pread, qemu will reply with EINVAL but keep the connection up; but for > pwrite, an overlarge buffer is fatal. It's time

Re: [Libguestfs] [PATCH v2] curl: Fix verification of CURLOPT_TLS13_CIPHERS

2022-11-10 Thread Richard W.M. Jones
On Thu, Nov 10, 2022 at 05:17:35PM +0100, Michal Orzel wrote: > The code checking for CURLOPT_TLS13_CIPHERS option did not work > properly, because of incorrect assumption that this symbol was a > preprocessor macro. It is in fact element of enum type, which > resulted with #ifdef directive

[Libguestfs] [PATCH v2] curl: Fix verification of CURLOPT_TLS13_CIPHERS

2022-11-10 Thread Michal Orzel
The code checking for CURLOPT_TLS13_CIPHERS option did not work properly, because of incorrect assumption that this symbol was a preprocessor macro. It is in fact element of enum type, which resulted with #ifdef directive working improperly. Fix changes that check to be based on curl version

Re: [Libguestfs] [PATCH] curl: Fix verification of CURLOPT_TLS13_CIPHERS

2022-11-10 Thread Orzel, MichalX
And what about checking curl version (LIBCURL_VERSION_MAJOR, LIBCURL_VERSION_MINOR) instead? That option was introduced in version 7.61, and I see that You're using 7.21. Please verify the second version if it would do its job. Best regards, Michał Orzeł -Original Message- From:

Re: [Libguestfs] [nbdkit PATCH v2 2/2] sh: Add exit status triggers for nbdkit_{shutdown, disconnect}

2022-11-10 Thread Laszlo Ersek
On 11/09/22 21:43, Eric Blake wrote: > Make it possible for the sh and eval plugins to disconnect a client or > shut down the entire nbdkit server by use of special return values. > Prior to this patch we had reserved 4-7 for future use; this defines > 4-8, and extends the set of reserved return

Re: [Libguestfs] [nbdkit PATCH] sh: Add exit status triggers for nbdkit_{shutdown, disconnect}

2022-11-10 Thread Richard W.M. Jones
On Wed, Nov 09, 2022 at 01:47:15PM -0600, Eric Blake wrote: > On Wed, Nov 02, 2022 at 01:36:26PM +, Richard W.M. Jones wrote: > > > > -=item 4, 5, 6, 7 > > > > +=item S<4> > > > > > > The S<> notation seems new here (so it's going to be inconsistent with > > > the rest of this file, I think).

Re: [Libguestfs] [nbdkit PATCH] sh: Add exit status triggers for nbdkit_{shutdown, disconnect}

2022-11-10 Thread Richard W.M. Jones
On Thu, Nov 10, 2022 at 02:23:39PM +0100, Laszlo Ersek wrote: > On 11/09/22 20:47, Eric Blake wrote: > > On Wed, Nov 02, 2022 at 01:36:26PM +, Richard W.M. Jones wrote: > -=item 4, 5, 6, 7 > +=item S<4> > >>> > >>> The S<> notation seems new here (so it's going to be inconsistent

Re: [Libguestfs] [nbdkit PATCH v2 1/2] sh: Advertise max known status in --dump-plugin

2022-11-10 Thread Laszlo Ersek
On 11/09/22 21:43, Eric Blake wrote: > We are about to define specific meaning to more return status values. > To make it easier to probe if nbdkit is new enough to honor such > definitions (and thus whether it makes sense to write a script that > tries to utilize such special return values), it

Re: [Libguestfs] [nbdkit PATCH] sh: Add exit status triggers for nbdkit_{shutdown, disconnect}

2022-11-10 Thread Laszlo Ersek
On 11/09/22 20:47, Eric Blake wrote: > On Wed, Nov 02, 2022 at 01:36:26PM +, Richard W.M. Jones wrote: -=item 4, 5, 6, 7 +=item S<4> >>> >>> The S<> notation seems new here (so it's going to be inconsistent with >>> the rest of this file, I think). >> >> I was going to mention this