The documentation guarantees that a user's .free callback is reached
exactly once for all synchronous nbd_opt_* functions that take a
callback structure (nbd_opt_list, nbd_opt_list_meta, ...), regardless
of API success or failure, but we weren't actually testing that in the
testsuite. It is quite
On Wed, Jul 12, 2023 at 03:33:28PM -0500, Eric Blake wrote:
> > > /* Issue NBD_OPT_LIST and wait for the reply. */
> > > int
> > > nbd_unlocked_opt_list (struct nbd_handle *h, nbd_list_callback *list)
> > > {
> > > struct list_helper s = { .list = *list };
> > > nbd_list_callback l = {
On Wed, Jul 12, 2023 at 03:19:59PM +, Tage Johansson wrote:
> Hello,
>
>
> While writing some tests for the Rust bindings, I discovered a memory leak
> with Valgrind due to a completion callback not being freed. More specificly,
> the completion callback of `aio_opt_info()` doesn't seem to
On Wed, Jul 12, 2023 at 03:19:59PM +, Tage Johansson wrote:
> Hello,
>
> While writing some tests for the Rust bindings, I discovered a
> memory leak with Valgrind due to a completion callback not being
> freed. More specificly, the completion callback of `aio_opt_info()`
> doesn't seem to be
Hello,
While writing some tests for the Rust bindings, I discovered a memory
leak with Valgrind due to a completion callback not being freed. More
specificly, the completion callback of `aio_opt_info()` doesn't seem to
be if `aio_opt_info()` failes. In this case, `aio_opt_info()` was called
On Mon, Jun 26, 2023 at 05:29:25PM +0100, Richard W.M. Jones wrote:
>
> Thanks, this one is upstream in commit 557ed93df3.
Hello Tage, I'm looking forward to seeing your work this summer, and
congratulations on your first commit to libnbd!
Here's some advice to help on future patches.
First, I
On Wed, Jul 12, 2023 at 07:34:56AM +, Tage Johansson wrote:
> From: Tage Johansson
>
> When running make with OCaml 5.0.0, the following warnings are sometimes
> shown:
>
> ```
> OCaml's lib directory layout changed in 5.0. The unix subdirectory has been
> automatically added to the search
On 7/11/23 15:10, Richard W.M. Jones wrote:
> On Tue, Jul 11, 2023 at 01:39:06PM +0200, Laszlo Ersek wrote:
>> The last (only?) caller of guestfs_int_cmd_clear_close_files() disappeared
>> in commit e4c396888056 ("lib/info: Remove /dev/fd hacking and pass a true
>> filename to qemu-img info.",
From: Tage Johansson
When running make with OCaml 5.0.0, the following warnings are sometimes
shown:
```
OCaml's lib directory layout changed in 5.0. The unix subdirectory has been
automatically added to the search path, but you should add -I +unix to the
command-line to silence this alert
When running make with OCaml 5.0 installed, I get some warnings
complaining about changed lib directory layout. It suggests adding
"-I +unix -I +str" to the invocation of ocamlc. So this patch does just
that.
It does silence the warnings for me, but someone should probably test
that it works with
10 matches
Mail list logo
