[Libguestfs] [PATCH libnbd] copy/copy-file-to-qcow2-compressed.sh: Skip test for all zeroes disk

2023-08-07 Thread Richard W.M. Jones
Occasionally this test will choose a random seed which results in an all-zeroes disk. The test tries to convert this to a compressed qcow2 file, and fails because no compressed clusters are detected in the resulting file. This happens because qcow2 stores zero clusters with a special sparse

Re: [Libguestfs] [libnbd PATCH] golang: Optionally use gofmt on generated .go files

2023-08-07 Thread Richard W.M. Jones
On Mon, Aug 07, 2023 at 04:11:15PM -0500, Eric Blake wrote: > On Fri, Aug 04, 2023 at 09:29:48AM -0500, Eric Blake wrote: > > Combine my recent work on improving the generated Go output with > > Tage's work on using a canonical formatter for Rust. If gofmt is > > available during the build, then

[Libguestfs] libnbd | Failed pipeline for master | 9cb10b39

2023-08-07 Thread GitLab
Pipeline #958658174 has failed! Project: libnbd ( https://gitlab.com/nbdkit/libnbd ) Branch: master ( https://gitlab.com/nbdkit/libnbd/-/commits/master ) Commit: 9cb10b39 ( https://gitlab.com/nbdkit/libnbd/-/commit/9cb10b390e2def9cc7ed744382e5d68e874e1c7a ) Commit Message: golang: Optionally

[Libguestfs] libnbd | Failed pipeline for master | 9cb10b39

2023-08-07 Thread GitLab
Pipeline #958658174 has failed! Project: libnbd ( https://gitlab.com/nbdkit/libnbd ) Branch: master ( https://gitlab.com/nbdkit/libnbd/-/commits/master ) Commit: 9cb10b39 ( https://gitlab.com/nbdkit/libnbd/-/commit/9cb10b390e2def9cc7ed744382e5d68e874e1c7a ) Commit Message: golang: Optionally

Re: [Libguestfs] [libnbd PATCH] golang: Optionally use gofmt on generated .go files

2023-08-07 Thread Eric Blake
On Fri, Aug 04, 2023 at 09:29:48AM -0500, Eric Blake wrote: > Combine my recent work on improving the generated Go output with > Tage's work on using a canonical formatter for Rust. If gofmt is > available during the build, then the generated .go files will now use > TAB indents and have proper

Re: [Libguestfs] [PATCH v4 24/24] nbd/server: Add FLAG_PAYLOAD support to CMD_BLOCK_STATUS

2023-08-07 Thread Eric Blake
On Tue, Jun 27, 2023 at 10:42:20PM +0300, Vladimir Sementsov-Ogievskiy wrote: > On 08.06.23 16:56, Eric Blake wrote: > > Allow a client to request a subset of negotiated meta contexts. For > > example, a client may ask to use a single connection to learn about > > both block status and dirty

Re: [Libguestfs] [PATCH v4 19/24] nbd/client: Initial support for extended headers

2023-08-07 Thread Eric Blake
On Tue, Jun 27, 2023 at 05:22:09PM +0300, Vladimir Sementsov-Ogievskiy wrote: > On 08.06.23 16:56, Eric Blake wrote: > > Update the client code to be able to send an extended request, and > > parse an extended header from the server. Note that since we reject > > any structured reply with a

Re: [Libguestfs] [PATCH v4 16/24] nbd/server: Support 64-bit block status

2023-08-07 Thread Vladimir Sementsov-Ogievskiy
On 04.08.23 22:36, Eric Blake wrote: On Tue, Jun 27, 2023 at 04:23:49PM +0300, Vladimir Sementsov-Ogievskiy wrote: On 08.06.23 16:56, Eric Blake wrote: The NBD spec states that if the client negotiates extended headers, the server must avoid NBD_REPLY_TYPE_BLOCK_STATUS and instead use

Re: [Libguestfs] [PATCH v4 15/24] nbd/server: Prepare to send extended header replies

2023-08-07 Thread Vladimir Sementsov-Ogievskiy
On 04.08.23 22:28, Eric Blake wrote: On Fri, Jun 16, 2023 at 09:48:18PM +0300, Vladimir Sementsov-Ogievskiy wrote: On 08.06.23 16:56, Eric Blake wrote: Although extended mode is not yet enabled, once we do turn it on, we need to reply with extended headers to all messages. Update the low

Re: [Libguestfs] [PATCH nbdkit v2 8/9] curl: Use curl multi interface

2023-08-07 Thread Laszlo Ersek
On 8/7/23 13:08, Richard W.M. Jones wrote: > On Mon, Aug 07, 2023 at 12:57:02PM +0200, Laszlo Ersek wrote: >> On 8/4/23 20:04, Richard W.M. Jones wrote: >>> On Fri, Aug 04, 2023 at 11:38:03AM -0500, Eric Blake wrote: On Fri, Jul 28, 2023 at 06:17:52PM +0100, Richard W.M. Jones wrote: >

Re: [Libguestfs] debug a corrupted VHDX file with libguestfs

2023-08-07 Thread Richard W.M. Jones
On Fri, Aug 04, 2023 at 10:37:50PM +, Lin, HongYi - Dell Team wrote: > I tried to recompile Ubuntu kernel and add some printk messages, they don’t > show up in dmesg when I run > > root@HenrikUbuntu2204:/mnt/sdj# guestmount -a > c1eef115-0006-ec888b8d-64888b8d-00155000-4a448456 -m

[Libguestfs] debug a corrupted VHDX file with libguestfs

2023-08-07 Thread Lin, HongYi - Dell Team
Hi I am using libguestfs-1.46.2 on Ubuntu 22.04 I already enabled export LIBGUESTFS_DEBUG=1 export LIBGUESTFS_TRACE=1 I want to mount a vhdx file (which is known to be corrupted) with root@HenrikUbuntu2204:/mnt/sdj# guestmount -a 8b062ac7-0006-d6ac6b69-64ac6b69-002b5000-4a448456 -m

[Libguestfs] debug a corrupted VHDX file with libguestfs

2023-08-07 Thread Lin, HongYi - Dell Team
Hi I am using libguestfs-1.46.2 on Ubuntu 22.04 I already enabled export LIBGUESTFS_DEBUG=1 export LIBGUESTFS_TRACE=1 I want to mount a vhdx file (which is known to be corrupted) with root@HenrikUbuntu2204:/mnt/sdj# guestmount -a c1eef115-0006-ec888b8d-64888b8d-00155000-4a448456 -m

Re: [Libguestfs] [PATCH nbdkit v2 8/9] curl: Use curl multi interface

2023-08-07 Thread Richard W.M. Jones
On Mon, Aug 07, 2023 at 12:57:02PM +0200, Laszlo Ersek wrote: > On 8/4/23 20:04, Richard W.M. Jones wrote: > > On Fri, Aug 04, 2023 at 11:38:03AM -0500, Eric Blake wrote: > >> On Fri, Jul 28, 2023 at 06:17:52PM +0100, Richard W.M. Jones wrote: > >>> See the comment at the top of

Re: [Libguestfs] [libnbd PATCH v4 05/25] golang: Change logic of copy_uint32_array

2023-08-07 Thread Laszlo Ersek
On 8/4/23 11:16, Richard W.M. Jones wrote: > On Wed, Aug 02, 2023 at 08:50:25PM -0500, Eric Blake wrote: >> Commit 6725fa0e12 changed copy_uint32_array() to utilize a Go hack for >> accessing a C array as a Go slice in order to potentially benefit from >> any optimizations in Go's copy() for bulk

Re: [Libguestfs] [PATCH nbdkit v2 8/9] curl: Use curl multi interface

2023-08-07 Thread Laszlo Ersek
On 8/4/23 20:04, Richard W.M. Jones wrote: > On Fri, Aug 04, 2023 at 11:38:03AM -0500, Eric Blake wrote: >> On Fri, Jul 28, 2023 at 06:17:52PM +0100, Richard W.M. Jones wrote: >>> See the comment at the top of plugins/curl/pool.c for general >>> information about how this works. >>> >>> This makes