On Mon, Apr 03, 2023 at 01:28:14PM +0100, Richard W.M. Jones wrote:
>
> 13:19 < tgolembi[m]> is there a trick how to convert a VM with name that
> starts with a dash? It's being confused for virt-v2v argument.
> :)
>
> Yes you can do this:
>
> $ virt-v2v -o [etc...] --
. This will also help to prevent some corner case
scenarios (that would be difficult to debug) when the VM creation job
fails after virt-v2v already termintates with success.
Thanks: Nir Soffer
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1985827
Signed-off-by: Tomáš Golembiovský
Reviewed
. This will also help to prevent some corner case
scenarios (that would be difficult to debug) when the VM creation job
fails after virt-v2v already termintates with success.
Thanks: Nir Soffer
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1985827
Signed-off-by: Tomáš Golembiovský
Reviewed
On Tue, Apr 12, 2022 at 08:34:27PM +0200, Tomáš Golembiovský wrote:
> oVirt API call for VM creation finishes before the VM is actually
> created. Entities may be still locked after virt-v2v terminates and if
> user tries to perform (scripted) actions after virt-v2v those operations
&
. This will also help to prevent some corner case
scenarios (that would be difficult to debug) when the VM creation job
fails after virt-v2v already termintates with success.
Thanks: Nir Soffer
Signed-off-by: Tomáš Golembiovský
Reviewed-by: Arik Hadas
---
output/rhv-upload-createvm.py | 57
On Mon, Feb 22, 2021 at 04:45:09PM +, Richard W.M. Jones wrote:
> On Mon, Feb 22, 2021 at 02:51:32PM +0100, Tomáš Golembiovský wrote:
> > Hi,
> >
> > from time to time we get a request [1] to import appliance with crafted
> > OVF (from Cisco or Gigamon) into oV
/1705600
[2] Open Virtualization Format Specification (DSP0243) Version 2.1.1,
Chapter 9.8 -- DeploymentOptionSection
[3] Open Virtualization Format Specification (DSP0243) Version 2.1.1,
Chapter 9.5.1 -- Property elements
--
Tomáš Golembiovský
virt-engine/+/106692
>
> Am I missing something?
>
> Rich.
>
>
--
Tomáš Golembiovský
___
Libguestfs mailing list
Libguestfs@redhat.com
https://www.redhat.com/mailman/listinfo/libguestfs
On Mon, Nov 30, 2020 at 09:13:31AM +, Richard W.M. Jones wrote:
> Bug: https://bugzilla.redhat.com/show_bug.cgi?id=1895323
> ---
> v2v/convert_windows.ml | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
LGTM
___
Libguestfs mailing list
> g = guestfs.GuestFS(python_return_dict=True)
>>> g.add_drive("my-machine.qcow2")
>>> g.launch()
>>> g.list_filesystems()
{'/dev/sda1': 'xfs'}
>>> g.mount('/dev/sda1', '/')
>>> g.sh(&qu
On Tue, 16 Jun 2020 22:06:58 +0100
"Richard W.M. Jones" wrote:
> On Tue, Jun 16, 2020 at 04:34:15PM +0200, Tomáš Golembiovský wrote:
> > On Wed, 10 Jun 2020 11:31:33 +0100
> > "Richard W.M. Jones" wrote:
> >
> > > I finally got acc
>3.9G 24K 3.9G 1%
> /run/secrets/kubernetes.io/serviceaccount
>
>
> --
> Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
> Read my programming and virtualization blog: http:/
On Tue, Apr 07, 2020 at 04:31:57PM +0200, Pino Toscano wrote:
> On Tuesday, 7 April 2020 14:59:11 CEST Tomáš Golembiovský wrote:
> > On Tue, Apr 07, 2020 at 02:33:20PM +0200, Pino Toscano wrote:
> > > On Tuesday, 7 April 2020 14:18:47 CEST Richard W.M. Jones wrote:
> >
On Tue, Apr 07, 2020 at 02:33:20PM +0200, Pino Toscano wrote:
> On Tuesday, 7 April 2020 14:18:47 CEST Richard W.M. Jones wrote:
> > On Tue, Apr 07, 2020 at 01:25:02PM +0200, Pino Toscano wrote:
> > > The important thing is still that that you need to have space for the
> > > temporary files
; I think(?) this hunk was not intended?
>
Yes, that's a mistake. Sorry for that.
Tomas
--
Tomáš Golembiovský
___
Libguestfs mailing list
Libguestfs@redhat.com
https://www.redhat.com/mailman/listinfo/libguestfs
, e.g. introducing waiting mechanism), the delay as
it is defined works in most cases. And it dramaticaly improves the
situations -- originaly I experienced more than 90% failure rate.
Signed-off-by: Tomáš Golembiovský
---
common | 2 +-
v2v/convert_windows.ml | 17
On Thu, Mar 05, 2020 at 08:49:04AM +, Richard W.M. Jones wrote:
> On Tue, Mar 03, 2020 at 03:45:49PM +0100, Tomáš Golembiovský wrote:
> > Instead of running firstboot script during early boot schedule a task
> > delayed for 2 minutes.
> >
> > During the first boot
On Tue, Mar 03, 2020 at 01:37:24PM +, Daniel P. Berrangé wrote:
> On Tue, Mar 03, 2020 at 02:27:46PM +0100, Tomáš Golembiovský wrote:
> > On Mon, Mar 02, 2020 at 11:35:29AM +, Daniel P. Berrangé wrote:
> > > On Mon, Mar 02, 2020 at 12:26:00PM +0100, Tomáš
, e.g. introducing waiting mechanism), the delay as
it is defined works in most cases. And it dramaticaly improves the
situations -- originaly I experienced more than 90% failure rate.
Signed-off-by: Tomáš Golembiovský
---
common | 2 +-
v2v/convert_windows.ml | 12
2
terminates any running firstboot scripts thus killing the installation
of qemu-ga MSI.
Signed-off-by: Tomáš Golembiovský
---
common | 2 +-
v2v/convert_windows.ml | 12
2 files changed, 5 insertions(+), 9 deletions(-)
diff --git a/common b/common
index ea10827b
On Mon, Mar 02, 2020 at 11:35:29AM +, Daniel P. Berrangé wrote:
> On Mon, Mar 02, 2020 at 12:26:00PM +0100, Tomáš Golembiovský wrote:
> > Instead of running firstboot script during early boot schedule a task
> > delayed for 1-2 minute.
>
> IIUC, you picked 119 seco
terminates any running firstboot scritps thus killing the installation
of qemu-ga MSI.
Signed-off-by: Tomáš Golembiovský
---
v2v/convert_windows.ml | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/v2v/convert_windows.ml b/v2v/convert_windows.ml
index 0fda1d4e
l possibly send a similar patch
for RHEV-APT installation later.
Tomáš Golembiovský (1):
windows: delay installation of qemu-ga MSI
v2v/convert_windows.ml | 12
1 file changed, 4 insertions(+), 8 deletions(-)
--
2.25.0
___
Libguest
> > I have really no clue about this.
> >
> > What is "~dpnx0"?
>
> I wanted to documented that in a comment at first. But then I decided
> against that as it seemed that as it seemed such patterns are used in
> multiple places in the code (ergo everyone knows).
>
> Looking now I see two
On Tue, 11 Feb 2020 14:36:24 +
"Richard W.M. Jones" wrote:
> On Thu, Nov 21, 2019 at 12:04:18PM +0100, Tomáš Golembiovský wrote:
> > Instead of running firstboot scripts during early boot schedule a task
> > delayed for 1-2 minute.
> >
> > During the
This, together with the changes to common repo are fixes to the installation
qemu-ga MSI.
There is still an issue that I did not figure yet how to fix. On Windows 10 it
fails to register the QEMU-GA service.
Tomáš Golembiovský (2):
windows: fix detection of qemu-ga installer on RHV
windows
- match log file with script name
- restart manually only after successfull install, this also helps
debugging because we can log the installer return code
Signed-off-by: Tomáš Golembiovský
---
v2v/convert_windows.ml | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git
The detection was incorrectly matching only 32-bit installer on all
architectures.
Signed-off-by: Tomáš Golembiovský
---
v2v/windows_virtio.ml | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/v2v/windows_virtio.ml b/v2v/windows_virtio.ml
index 5ec7664b..f8863a6a 100644
On Mon, Jan 27, 2020 at 04:59:55PM +0100, Pino Toscano wrote:
> On Thursday, 21 November 2019 12:11:00 CET Tomáš Golembiovský wrote:
> > This, together with the changes to common repo are fixes to the installation
> > qemu-ga MSI.
>
> I pushed patch #1 because it is OK for me
On Mon, Jan 27, 2020 at 05:01:57PM +0100, Pino Toscano wrote:
> On Thursday, 21 November 2019 12:11:01 CET Tomáš Golembiovský wrote:
> > The detection was incorrectly matching only 32-bit installer on all
> > architectures.
> >
> > Signed-off-by: Tomáš Gol
On Mon, Jan 27, 2020 at 01:46:03PM +0100, Pino Toscano wrote:
> On Monday, 27 January 2020 12:37:38 CET Tomáš Golembiovský wrote:
> > On Mon, Jan 27, 2020 at 12:17:42PM +0100, Pino Toscano wrote:
> > > On Monday, 27 January 2020 10:39:34 CET Tomáš Golembiovský wrote:
> >
On Mon, Jan 27, 2020 at 12:17:42PM +0100, Pino Toscano wrote:
> On Monday, 27 January 2020 10:39:34 CET Tomáš Golembiovský wrote:
> > Signed-off-by: Tomáš Golembiovský
> > ---
> > podwrapper.pl.in | 2 ++
> > 1 file changed, 2 insertions(+)
> >
&g
Signed-off-by: Tomáš Golembiovský
---
cfg.mk | 1 +
1 file changed, 1 insertion(+)
diff --git a/cfg.mk b/cfg.mk
index a303ee72..4bd2d006 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -132,6 +132,7 @@ ifeq (0,$(MAKELEVEL))
# b653eda3ac4864de205419d9f41eec267cb89eeb
_submodule_hash = sed 's
Signed-off-by: Tomáš Golembiovský
---
podwrapper.pl.in | 2 ++
1 file changed, 2 insertions(+)
diff --git a/podwrapper.pl.in b/podwrapper.pl.in
index f12a173f..1e4aa149 100755
--- a/podwrapper.pl.in
+++ b/podwrapper.pl.in
@@ -689,6 +689,8 @@ sub find_file
my $use_path = shift;
local
Building virt-v2v out-of-tree does not work and requires several small fixes
here and there.
Tomáš Golembiovský (3):
build: perform gnulib check from source directory
build: run ocaml-link.sh from build directory
docs: don't perform lookup on absolute paths
cfg.mk | 1
ocaml-link.sh is generated file. It means that for out-of-tree builds it
is located in a build directory which is different from source tree dir.
Signed-off-by: Tomáš Golembiovský
---
v2v/Makefile.am | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/v2v
Signed-off-by: Tomáš Golembiovský
---
v2v/vCenter.ml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/v2v/vCenter.ml b/v2v/vCenter.ml
index 89c5579b..d9bf12c1 100644
--- a/v2v/vCenter.ml
+++ b/v2v/vCenter.ml
@@ -79,7 +79,7 @@ let rec map_source ?bandwidth ?password_file dcPath
The tests assume probe_filter returns true if the filter is available
(and not the other way around).
Signed-off-by: Tomáš Golembiovský
---
v2v/nbdkit.ml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/v2v/nbdkit.ml b/v2v/nbdkit.ml
index 77d2a506..00122bec 100644
--- a/v2v
There was no source directory for EL8 guest agent (only EL6 and EL7).
RHBZ#1791802
Signed-off-by: Tomáš Golembiovský
---
v2v/windows_virtio.ml | 1 +
1 file changed, 1 insertion(+)
diff --git a/v2v/windows_virtio.ml b/v2v/windows_virtio.ml
index 5ec7664b..86bc8c0a 100644
--- a/v2v
There was no source directory for EL8 guest agent (only EL6 and EL7).
RHBZ#1791802
Signed-off-by: Tomáš Golembiovský
---
v2v/windows_virtio.ml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/v2v/windows_virtio.ml b/v2v/windows_virtio.ml
index 5ec7664b..6ddc488a 100644
On Wed, 8 Jan 2020 21:05:55 +0800
"谢威" <249016...@qq.com> wrote:
> Hi,Tomas:
>
>
> here is the test info: Thanks for your
> kind help .
The test tool finished OK. Did you try to run you virt-copy-in command
again?
Tomas
>
>
>
bguestfs: trace: get_backend_setting = NULL (error)
> libguestfs: build appliance
> libguestfs: trace: get_cachedir
> libguestfs: trace: get_cachedir = "/var/tmp"
> libguestfs: begin building supermin appliance
> libguestfs: run supermin
> libguestfs: command: run: /usr/bin
guestfs: command: run: rm
> libguestfs: command: run: \ -rf /tmp/libguestfsVov1Hm
> teev@teev-HA:~$ ^C
> teev@teev-HA:~$ export libguestfs_debug=1
> teev@teev-HA:~$ export libguestfs_trace=1
> teev@teev-HA:~$ sudo virt-builder debian-9 --output
> /var/lib/libvirt/images
Traceback (most recent call last):
> File "", line 1, in
> TypeError: test() takes 1 positional argument but 2 were given
>
Check the attached script for some examples. Hopefully that will help
you get a better grasp.
Tomas
--
Tomáš Golembiovský
#!/usr/bin/env pyt
The detection was incorrectly matching only 32-bit installer on all
architectures.
Signed-off-by: Tomáš Golembiovský
---
v2v/windows_virtio.ml | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/v2v/windows_virtio.ml b/v2v/windows_virtio.ml
index 5ec7664b..f47d28e0 100644
- match log file with script name
- restart manually only after successfull install, this also helps
debugging because we can log the installer return code
Signed-off-by: Tomáš Golembiovský
---
v2v/convert_windows.ml | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git
This, together with the changes to common repo are fixes to the installation
qemu-ga MSI.
There is still an issue that I did not figure yet how to fix. On Windows 10 it
fails to register the QEMU-GA service.
Tomáš Golembiovský (2):
windows: fix detection of qemu-ga installer on RHV
windows
:
Failed to connect to server. Error: 0x8007045B
Signed-off-by: Tomáš Golembiovský
---
mlcustomize/firstboot.ml | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/mlcustomize/firstboot.ml b/mlcustomize/firstboot.ml
index c3ebfd9..b4ca181 100644
--- a/mlcustomize
Signed-off-by: Tomáš Golembiovský
---
mlcustomize/firstboot.ml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mlcustomize/firstboot.ml b/mlcustomize/firstboot.ml
index a8f4ef7..c3ebfd9 100644
--- a/mlcustomize/firstboot.ml
+++ b/mlcustomize/firstboot.ml
@@ -307,7 +307,7
versions.
The change can also be problem for those who really wish to perform an action
early in the boot... if there are such users.
Tomáš Golembiovský (2):
firstboot: use absolute path to rhsrvany
firstboot: schedule firstboot as delayed task
mlcustomize/firstboot.ml | 12 ++--
1
t;
> If this is a Xen guest, and you only have Xen domU kernels
> installed, try installing a fullvirt kernel (only for
> supermin use, you shouldn't boot the Xen guest with it).
> libguestfs: error: /usr/bin/supermin exited with error status 1, see debug
> messages above
> libgues
Use firstboot script to install MSI with QEMU-GA from virtio-win ISO or
oVirt/RHV guest tools ISO.
Signed-off-by: Tomáš Golembiovský
---
v2v/convert_windows.ml | 19 +++
v2v/windows_virtio.ml | 27 +++
v2v/windows_virtio.mli | 4
3 files changed
On Thu, 4 Jul 2019 15:52:20 +0100
"Richard W.M. Jones" wrote:
> Thanks: Steven Rosenberg
> ---
> v2v/windows_virtio.ml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
LGTM
--
Tomáš Golembiovský
___
Libguestf
ithout needing to install any
> software inside the virtual machine. Supports Linux and Windows.
> http://people.redhat.com/~rjones/virt-df/
>
> ___
> Libguestfs mailing list
> Libguestfs@redhat.com
> https://www.redhat.com/mailman/listinfo/libgu
mmon/mltools/tools_utils.ml | 16 +++
> lib/guestfs.pod| 19 +
> 4 files changed, 87 insertions(+), 1 deletion(-)
ACK
--
Tomáš Golembiovský
___
Libguestfs mailing list
Libguestfs@redhat.com
https://www.redhat.com/mailman/listinfo/libguestfs
On Tue, 26 Mar 2019 18:02:39 +0100
Pino Toscano wrote:
> This series slightly improves the way qemu-ga is installed from the
> RHV Tools ISO, simplifying the feedback to the user.
>
> Patch #3 sort of conflicts with patch #2 of a related series by
> Tomáš Golembiovský:
> http
On Mon, 25 Feb 2019 17:22:49 +0100
Pino Toscano wrote:
> This series adds a new output mode for virt-v2v, called -o json.
> It produces local files, just like -o local, although the metadata
> produced is a JSON file with data that v2v collected in the conversion
> process. This can be useful
Store log from MSI installer. Log file will be located in firstboot
scripts-done directory with name rhev-apt.log. The path has to be
double-quoted to handle spaces in path name properly.
Hopefully this can help resolve RHBZ#1584678 someday.
Signed-off-by: Tomáš Golembiovský
---
v2v
First patch just fixes installing guest tools from directory that was broken.
Second patch revamps how virt-v2v chooses from which directory install guest
tools on Linux. Details in commit message.
v2:
- included comments from Pino and Rich
- added test
Tomáš Golembiovský (3):
v2v: fix path
Signed-off-by: Tomáš Golembiovský
---
v2v/Makefile.am | 1 +
v2v/test-v2v-copy-guest-tools.sh | 87
2 files changed, 88 insertions(+)
create mode 100755 v2v/test-v2v-copy-guest-tools.sh
diff --git a/v2v/Makefile.am b/v2v/Makefile.am
index
backward compatibility and are
aliased to new names as described below. When both new and old name are
present on file system the new name takes precedence.
fc28 -> fedora
el6 -> rhel6
el7 -> rhel7
lp151 -> suse
Signed-off-by: Tomáš Golembiovský
---
v2v/w
The debug message was slightly changed too to better match the similar
message for ISO case. It refers to the root directory instead of the
specific subdirectory inside guest tools.
Signed-off-by: Tomáš Golembiovský
---
v2v/windows_virtio.ml | 7 ---
1 file changed, 4 insertions(+), 3
On Wed, 06 Feb 2019 17:02:57 +0100
Pino Toscano wrote:
> On Wednesday, 6 February 2019 14:11:41 CET Tomáš Golembiovský wrote:
> > > > + * Note that the call may succeed whithout copying any file at all.
> > > > This may
> > > > + * happen when the source s
files then the call
itself succeeds (because some directory was found) but no files were
copied.
Let me know if you have tips on how to phrase that better.
Tomas
--
Tomáš Golembiovský
___
Libguestfs mailing list
Libguestfs@redhat.com
htt
On Mon, 28 Jan 2019 17:39:23 +
"Richard W.M. Jones" wrote:
> On Sat, Jan 26, 2019 at 01:19:59PM +0100, Tomáš Golembiovský wrote:
> > Allow multiple alternative directory names for distributions (or
> > distribution familiy) when installing Linux guest tools pack
On Mon, 28 Jan 2019 17:24:15 +
"Richard W.M. Jones" wrote:
> On Sat, Jan 26, 2019 at 01:19:58PM +0100, Tomáš Golembiovský wrote:
> > The debug message was slightly changed too to better match the similar
> > message for ISO case. It refers to the root directory in
On Sat, 26 Jan 2019 19:42:15 +0100
Sandro Bonazzola wrote:
> Il giorno sab 26 gen 2019, 13:20 Tomáš Golembiovský
> ha scritto:
>
> > Allow multiple alternative directory names for distributions (or
> > distribution familiy) when installing Linux guest tools packages
First patch just fixes installing guest tools from directory that was broken.
Second patch revamps how virt-v2v chooses from which directory install guest
tools on Linux. Details in commit message.
Tomáš Golembiovský (2):
v2v: fix path to source when copying files from guest tools directory
backward compatibility and are
aliased to new names as described below. When both new and old name are
present on file system the new name takes precedence.
fc28 -> fedora
el6 -> rhel6
el7 -> rhel7
lp151 -> suse
Signed-off-by: Tomáš Golembiovský
---
v2v/w
The debug message was slightly changed too to better match the similar
message for ISO case. It refers to the root directory instead of the
specific subdirectory inside guest tools.
Signed-off-by: Tomáš Golembiovský
---
v2v/windows_virtio.ml | 6 +++---
1 file changed, 3 insertions(+), 3
On Tue, 8 Jan 2019 14:11:26 +
"Richard W.M. Jones" wrote:
> They can contain passwords or tokens if for example the
> ‘-oo os-password’ option is used.
>
> Thanks: Tomáš Golembiovský, Brett Thurber.
> ---
> v2v/output_openstack.ml | 12
> 1 f
On Tue, 4 Dec 2018 23:50:42 +0200
Nikolay Ivanets wrote:
> вт, 4 груд. 2018, 23:46 Tomáš Golembiovský користувач tgole...@redhat.com
> пише:
>
> > Regular virtio-win ISO does not have them and maybe never will.
> >
>
> May I ask why?
Well there's this philosophic
It should not be error to use virtio-win ISO that does not have Linux
packages of QEMU Guest Agent. Only oVirt/RHV guest tools ISO has such
packages now. Regular virtio-win ISO does not have them and maybe never
will.
Signed-off-by: Tomáš Golembiovský
---
v2v/windows_virtio.ml | 88
On Tue, 20 Nov 2018 10:25:10 +
"Richard W.M. Jones" wrote:
> Previously we allowed arbitrary flags to be passed through to the
> underlying openstack CLI command, provided they have the format
> ‘--key=value’. We want to pass the ‘--insecure’ flag through, but
> that doesn't have the
Changed the function to be more generic and renamed.
The only change in behavior is in produced debug messages.
Signed-off-by: Tomáš Golembiovský
---
v2v/windows_virtio.ml | 46 +++
1 file changed, 29 insertions(+), 17 deletions(-)
diff --git a/v2v
On Wed, 7 Nov 2018 15:43:00 +
"Richard W.M. Jones" wrote:
> On Wed, Nov 07, 2018 at 12:53:18PM +0100, Tomáš Golembiovský wrote:
> > Changed the function to be more generic and renamed.
> > The only change in behavior is in produced debug messages.
> >
> &
Signed-off-by: Tomáš Golembiovský
---
v2v/convert_linux.ml | 2 ++
v2v/windows_virtio.ml | 32
v2v/windows_virtio.mli | 4
3 files changed, 38 insertions(+)
diff --git a/v2v/convert_linux.ml b/v2v/convert_linux.ml
index e8c64ac1b..a1bafe91a 100644
Some paths in the function are evaluated in libguestfs environment.
Previous commit copied the invalid construction. This is now fixed.
Signed-off-by: Tomáš Golembiovský
---
v2v/windows_virtio.ml | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/v2v/windows_virtio.ml b
(simulate the install).
And attempting to install the package will leave it half-installed (dpkg
cannot roll-back).
Tomáš Golembiovský (3):
v2v: refactor copy_drivers() in Windows_virtio
v2v: fix path construction in Windows_virtio.copy_files()
v2v: linux: install QEMU-GA (RHBZ#161966
On Tue, 13 Nov 2018 13:41:39 +0100
Tomáš Golembiovský wrote:
> changes in v4:
> - fix call to install_local
v3 was same as v2 because I forgot to commit the changes.
The difference between v2 and v4 is just one line in the
Linux.install_local call.
Tomas
>
> changes in v
Install packages from local files without touching network.
Signed-off-by: Tomáš Golembiovský
---
v2v/linux.ml | 14 ++
v2v/linux.mli | 3 +++
2 files changed, 17 insertions(+)
diff --git a/v2v/linux.ml b/v2v/linux.ml
index 177724e39..966170cdd 100644
--- a/v2v/linux.ml
+++ b/v2v
Changed the function to be more generic and renamed.
The only change in behavior is in produced debug messages.
Signed-off-by: Tomáš Golembiovský
---
v2v/windows_virtio.ml | 48 ---
1 file changed, 31 insertions(+), 17 deletions(-)
diff --git a/v2v
unnecesary work
- support for Debian is missing
I don't know how to install the package only when all it's dependencies are
already installed. dpkg cannot be used to check that (simulate the install).
And attempting to install the package will leave it half-installed (dpkg
cannot roll-back).
Signed-off-by: Tomáš Golembiovský
---
v2v/convert_linux.ml | 2 ++
v2v/windows_virtio.ml | 30 ++
v2v/windows_virtio.mli | 4
3 files changed, 36 insertions(+)
diff --git a/v2v/convert_linux.ml b/v2v/convert_linux.ml
index e8c64ac1b..a1bafe91a 100644
On Wed, 7 Nov 2018 17:32:56 +0100
Tomáš Golembiovský wrote:
> On Wed, 7 Nov 2018 15:31:56 +
> "Richard W.M. Jones" wrote:
>
> > On Wed, Nov 07, 2018 at 12:53:17PM +0100, Tomáš Golembiovský wrote:
> > > changes in v3:
> > > - fix call
On Wed, 7 Nov 2018 15:46:49 +
"Richard W.M. Jones" wrote:
> On Wed, Nov 07, 2018 at 12:53:20PM +0100, Tomáš Golembiovský wrote:
> > Signed-off-by: Tomáš Golembiovský
> > ---
> > v2v/convert_linux.ml | 2 ++
> > v2v/windows_virtio.ml | 30 ++
On Wed, 7 Nov 2018 15:31:56 +
"Richard W.M. Jones" wrote:
> On Wed, Nov 07, 2018 at 12:53:17PM +0100, Tomáš Golembiovský wrote:
> > changes in v3:
> > - fix call to install_local
> >
> > changes in v2:
> > - moved copy_driver
On Wed, 07 Nov 2018 13:32:45 +0100
Pino Toscano wrote:
> On Wednesday, 7 November 2018 12:53:17 CET Tomáš Golembiovský wrote:
> > - support for Debian is missing
> > I don't know how to install the package only when all it's dependencies
> > are
> > already instal
Changed the function to be more generic and renamed.
The only change in behavior is in produced debug messages.
Signed-off-by: Tomáš Golembiovský
---
v2v/windows_virtio.ml | 48 ---
1 file changed, 31 insertions(+), 17 deletions(-)
diff --git a/v2v
Changed the function to be more generic and renamed.
The only change in behavior is in produced debug messages.
Signed-off-by: Tomáš Golembiovský
---
v2v/windows_virtio.ml | 48 ---
1 file changed, 31 insertions(+), 17 deletions(-)
diff --git a/v2v
Install packages from local files without touching network.
Signed-off-by: Tomáš Golembiovský
---
v2v/linux.ml | 14 ++
v2v/linux.mli | 3 +++
2 files changed, 17 insertions(+)
diff --git a/v2v/linux.ml b/v2v/linux.ml
index 177724e39..966170cdd 100644
--- a/v2v/linux.ml
+++ b/v2v
Signed-off-by: Tomáš Golembiovský
---
v2v/convert_linux.ml | 2 ++
v2v/windows_virtio.ml | 30 ++
v2v/windows_virtio.mli | 4
3 files changed, 36 insertions(+)
diff --git a/v2v/convert_linux.ml b/v2v/convert_linux.ml
index e8c64ac1b..a1bafe91a 100644
Signed-off-by: Tomáš Golembiovský
---
v2v/convert_linux.ml | 2 ++
v2v/windows_virtio.ml | 30 ++
v2v/windows_virtio.mli | 4
3 files changed, 36 insertions(+)
diff --git a/v2v/convert_linux.ml b/v2v/convert_linux.ml
index e8c64ac1b..a1bafe91a 100644
is missing
I don't know how to install the package only when all it's dependencies are
already installed. dpkg cannot be used to check that (simulate the install).
And attempting to install the package will leave it half-installed (dpkg
cannot roll-back).
Tomáš Golembiovský (3):
v2v: refactor copy_
Install packages from local files without touching network.
Signed-off-by: Tomáš Golembiovský
---
v2v/linux.ml | 14 ++
v2v/linux.mli | 3 +++
2 files changed, 17 insertions(+)
diff --git a/v2v/linux.ml b/v2v/linux.ml
index 177724e39..966170cdd 100644
--- a/v2v/linux.ml
+++ b/v2v
On Tue, 6 Nov 2018 11:32:38 +
"Richard W.M. Jones" wrote:
> On Tue, Nov 06, 2018 at 11:44:14AM +0100, Tomáš Golembiovský wrote:
> > Install packages from local files without touching network.
>
> In fact, not limited to local files, but is limited to guests which
Changed the function to be more generic and renamed to copy_files.
The only change in behavior is in produced debug messages.
Signed-off-by: Tomáš Golembiovský
---
v2v/windows_virtio.ml | 52 ++-
1 file changed, 32 insertions(+), 20 deletions(-)
diff
And attempting to install the package will leave it half-installed (dpkg
cannot roll-back).
Tomáš Golembiovský (3):
v2v: refactor copy_drivers() in Windows_virtio
v2v: linux: install packages
v2v: linux: install QEMU-GA
v2v/convert_linux.ml | 2 ++
v2v/linux.ml | 19 +++
Install packages from local files without touching network.
Signed-off-by: Tomáš Golembiovský
---
v2v/linux.ml | 19 +++
v2v/linux.mli | 3 +++
2 files changed, 22 insertions(+)
diff --git a/v2v/linux.ml b/v2v/linux.ml
index 177724e39..6a5cae512 100644
--- a/v2v/linux.ml
Signed-off-by: Tomáš Golembiovský
---
v2v/convert_linux.ml | 2 ++
v2v/windows_virtio.ml | 30 ++
v2v/windows_virtio.mli | 5 +
3 files changed, 37 insertions(+)
diff --git a/v2v/convert_linux.ml b/v2v/convert_linux.ml
index e8c64ac1b..a1bafe91a 100644
1 - 100 of 262 matches
Mail list logo