Re: [Libguestfs] [PATCH] curl: Fix verification of CURLOPT_TLS13_CIPHERS

2022-11-10 Thread Orzel, MichalX
And what about checking curl version (LIBCURL_VERSION_MAJOR, LIBCURL_VERSION_MINOR) instead? That option was introduced in version 7.61, and I see that You're using 7.21. Please verify the second version if it would do its job. Best regards, Michał Orzeł -Original Message- From:

Re: [Libguestfs] [PATCH] curl: Fix verification of CURLOPT_TLS13_CIPHERS

2022-11-08 Thread Richard W.M. Jones
On Tue, Nov 08, 2022 at 12:56:13PM +0100, Michal Orzel wrote: > The code checking for CURLOPT_TLS13_CIPHERS option did not work > properly, because of incorrect assumption that this symbol was a > preprocessor macro. It is in fact element of enum type, which > resulted with #ifdef directive

[Libguestfs] [PATCH] curl: Fix verification of CURLOPT_TLS13_CIPHERS

2022-11-08 Thread Michal Orzel
The code checking for CURLOPT_TLS13_CIPHERS option did not work properly, because of incorrect assumption that this symbol was a preprocessor macro. It is in fact element of enum type, which resulted with #ifdef directive working improperly. Change replaces compile-time verification with run-time,