Re: [Libguestfs] [PATCH] daemon: Fix type signature of mount_vfs (RHBZ#1564983).

2018-04-09 Thread Pino Toscano
On Monday, 9 April 2018 09:54:51 CEST Richard W.M. Jones wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1564983 > > Because Mount.mount_vfs was declared with the wrong type signature it > could never be called correctly from outside the daemon. LGTM. > The root cause of this problem is

[Libguestfs] [PATCH] daemon: Fix type signature of mount_vfs (RHBZ#1564983).

2018-04-09 Thread Richard W.M. Jones
Reported-by: Yongkui Guo. Fixes commit 82bbd9c8a503661528289589976697d08cb41090. --- daemon/inspect_fs.ml | 6 ++ daemon/mount.ml | 18 +- daemon/mount.mli | 2 +- 3 files changed, 12 insertions(+), 14 deletions(-) diff --git a/daemon/inspect_fs.ml

[Libguestfs] [PATCH] daemon: Fix type signature of mount_vfs (RHBZ#1564983).

2018-04-09 Thread Richard W.M. Jones
https://bugzilla.redhat.com/show_bug.cgi?id=1564983 Because Mount.mount_vfs was declared with the wrong type signature it could never be called correctly from outside the daemon. The root cause of this problem is that the generator doesn't generate the type signatures automatically (which it