Re: [Libguestfs] [PATCH] daemon: Move the useful 'is_zero' function into common code.

2017-04-19 Thread Richard W.M. Jones
On Wed, Apr 19, 2017 at 03:40:49PM +0100, Daniel P. Berrange wrote: > On Wed, Apr 19, 2017 at 09:35:16AM -0500, Eric Blake wrote: > > On 04/19/2017 09:17 AM, Richard W.M. Jones wrote: > > > This is largely a simple refactoring, but it combines another > > > definition of this function from

Re: [Libguestfs] [PATCH] daemon: Move the useful 'is_zero' function into common code.

2017-04-19 Thread Daniel P. Berrange
On Wed, Apr 19, 2017 at 09:35:16AM -0500, Eric Blake wrote: > On 04/19/2017 09:17 AM, Richard W.M. Jones wrote: > > This is largely a simple refactoring, but it combines another > > definition of this function from virt-builder which had a slightly > > different prototype. > > --- > > > +/*

Re: [Libguestfs] [PATCH] daemon: Move the useful 'is_zero' function into common code.

2017-04-19 Thread Eric Blake
On 04/19/2017 09:17 AM, Richard W.M. Jones wrote: > This is largely a simple refactoring, but it combines another > definition of this function from virt-builder which had a slightly > different prototype. > --- > +/* Return true iff the buffer is all zero bytes. > + * > + * Note that gcc is

[Libguestfs] [PATCH] daemon: Move the useful 'is_zero' function into common code.

2017-04-19 Thread Richard W.M. Jones
This is largely a simple refactoring, but it combines another definition of this function from virt-builder which had a slightly different prototype. --- builder/pxzcat-c.c | 20 +--- daemon/daemon.h| 18 -- lib/guestfs-internal-all.h | 18