Re: [Libguestfs] [PATCH] daemon: inspect_fs_windows: Handle parted errors

2020-06-30 Thread Sam Eiderman
Yea, I noticed that commit, but since it was used in gpt too regardless of that commit, I decided not to mention this regression. I also noticed that list_filesystems() still works, this is probably due to filtering of devices (daemon/listfs.ml): "let devices = List.filter

[Libguestfs] [PATCH] daemon: inspect_fs_windows: Handle parted errors

2020-06-30 Thread Sam Eiderman
By creating an empty disk and using it as the first disk of the vm (i.e. /dev/sda, /dev/sdb{1,2} contains the windows fses) we change the iteration order of the disks. This causes inspect_os() to fail since Parted returns a Unix_error if the device does not contain any partitions - fix this by

Re: [Libguestfs] [PATCH] daemon: inspect_fs_windows: Handle parted errors

2020-06-30 Thread Pino Toscano
On Tuesday, 30 June 2020 10:33:40 CEST Sam Eiderman wrote: > By creating an empty disk and using it as the first disk of the vm (i.e. > /dev/sda, /dev/sdb{1,2} contains the windows fses) we change the > iteration order of the disks. > This causes inspect_os() to fail since Parted returns a