Re: [Libguestfs] [PATCH] v2v: ovf: add firmware and machine type element

2018-10-10 Thread Tomáš Golembiovský
On Thu, 19 Jul 2018 16:24:57 +0200 Pino Toscano wrote: > On Thursday, 19 July 2018 15:51:04 CEST Tomáš Golembiovský wrote: > > Add oVirt specific elemnt to OVF. It represents the combination of > > machine type (i440fx/q35) and firmware (BIOS/UEFI). > > Other than adding a new element in the

Re: [Libguestfs] [PATCH] v2v: ovf: add firmware and machine type element

2018-10-04 Thread Richard W.M. Jones
On Thu, Jul 19, 2018 at 04:24:57PM +0200, Pino Toscano wrote: > On Thursday, 19 July 2018 15:51:04 CEST Tomáš Golembiovský wrote: > > Add oVirt specific elemnt to OVF. It represents the combination of > > machine type (i440fx/q35) and firmware (BIOS/UEFI). > > Other than adding a new element in

Re: [Libguestfs] [PATCH] v2v: ovf: add firmware and machine type element

2018-10-04 Thread Richard W.M. Jones
On Thu, Jul 19, 2018 at 03:51:04PM +0200, Tomáš Golembiovský wrote: > Add oVirt specific elemnt to OVF. It represents the combination of > machine type (i440fx/q35) and firmware (BIOS/UEFI). > > Signed-off-by: Tomáš Golembiovský > --- > v2v/create_ovf.ml| 20

Re: [Libguestfs] [PATCH] v2v: ovf: add firmware and machine type element

2018-07-19 Thread Richard W.M. Jones
On Thu, Jul 19, 2018 at 03:51:04PM +0200, Tomáš Golembiovský wrote: > +let get_ovirt_biostype guestcaps target_firmware = > + let uefi_firmware = > +match target_firmware with > +| TargetBIOS -> None > +| TargetUEFI -> Some (find_uefi_firmware guestcaps.gcaps_arch) in > + let

Re: [Libguestfs] [PATCH] v2v: ovf: add firmware and machine type element

2018-07-19 Thread Pino Toscano
On Thursday, 19 July 2018 15:51:04 CEST Tomáš Golembiovský wrote: > Add oVirt specific elemnt to OVF. It represents the combination of > machine type (i440fx/q35) and firmware (BIOS/UEFI). Other than adding a new element in the OVF, this also enables the conversion of UEFI guests to oVirt. It is

[Libguestfs] [PATCH] v2v: ovf: add firmware and machine type element

2018-07-19 Thread Tomáš Golembiovský
Add oVirt specific elemnt to OVF. It represents the combination of machine type (i440fx/q35) and firmware (BIOS/UEFI). Signed-off-by: Tomáš Golembiovský --- v2v/create_ovf.ml| 20 +++- v2v/create_ovf.mli | 2 +- v2v/output_rhv.ml