On Tue, 6 Nov 2018 11:32:38 +
"Richard W.M. Jones" wrote:
> On Tue, Nov 06, 2018 at 11:44:14AM +0100, Tomáš Golembiovský wrote:
> > Install packages from local files without touching network.
>
> In fact, not limited to local files, but is limited to guests which
> use ‘yum’. So I think
On Wed, Nov 07, 2018 at 11:24:48AM +0100, Tomáš Golembiovský wrote:
> I used the same style as remove(). I will inline the code as I prefer
> that.
This is a stylistic point, so whichever style is easier to read,
more consistent, etc.
Rich.
--
Richard Jones, Virtualization Group, Red Hat
On Tue, Nov 06, 2018 at 06:13:40PM +0100, Pino Toscano wrote:
> On Tuesday, 6 November 2018 11:44:14 CET Tomáš Golembiovský wrote:
> > Install packages from local files without touching network.
> >
> > Signed-off-by: Tomáš Golembiovský
> > ---
>
> In this case, better name it
On Tuesday, 6 November 2018 11:44:14 CET Tomáš Golembiovský wrote:
> Install packages from local files without touching network.
>
> Signed-off-by: Tomáš Golembiovský
> ---
In this case, better name it local_install/install_local (or something
along these lines) to make it more clear it is not
On Tue, Nov 06, 2018 at 11:44:14AM +0100, Tomáš Golembiovský wrote:
> Install packages from local files without touching network.
In fact, not limited to local files, but is limited to guests which
use ‘yum’. So I think the function needs a better name unless you're
planning to combine it with
Install packages from local files without touching network.
Signed-off-by: Tomáš Golembiovský
---
v2v/linux.ml | 19 +++
v2v/linux.mli | 3 +++
2 files changed, 22 insertions(+)
diff --git a/v2v/linux.ml b/v2v/linux.ml
index 177724e39..6a5cae512 100644
--- a/v2v/linux.ml
+++
