Re: [Libguestfs] [PATCH 3/3] daemon/yara: fix undefined behavior due to Yara 4.0 API changes

2021-10-12 Thread Richard W.M. Jones
On Tue, Oct 12, 2021 at 10:14:53PM +0200, Laszlo Ersek wrote: > On 10/12/21 17:27, Richard W.M. Jones wrote: > > On Tue, Oct 12, 2021 at 09:16:10AM -0500, Eric Blake wrote: > >> On Tue, Oct 12, 2021 at 12:36:27AM +0200, Laszlo Ersek wrote: > >>> The prototype of yara_rules_callback() is: > >>> >

Re: [Libguestfs] [PATCH 3/3] daemon/yara: fix undefined behavior due to Yara 4.0 API changes

2021-10-12 Thread Laszlo Ersek
On 10/12/21 17:27, Richard W.M. Jones wrote: > On Tue, Oct 12, 2021 at 09:16:10AM -0500, Eric Blake wrote: >> On Tue, Oct 12, 2021 at 12:36:27AM +0200, Laszlo Ersek wrote: >>> The prototype of yara_rules_callback() is: >>> static int yara_rules_callback (int code, void *message, void

Re: [Libguestfs] [PATCH 3/3] daemon/yara: fix undefined behavior due to Yara 4.0 API changes

2021-10-12 Thread Laszlo Ersek
On 10/12/21 17:27, Richard W.M. Jones wrote: > On Tue, Oct 12, 2021 at 09:16:10AM -0500, Eric Blake wrote: >> On Tue, Oct 12, 2021 at 12:36:27AM +0200, Laszlo Ersek wrote: >>> The prototype of yara_rules_callback() is: >>> static int yara_rules_callback (int code, void *message, void

Re: [Libguestfs] [PATCH 3/3] daemon/yara: fix undefined behavior due to Yara 4.0 API changes

2021-10-12 Thread Laszlo Ersek
On 10/12/21 12:04, Richard W.M. Jones wrote: > > Thanks - ACK series. Thanks! Merged as commit range 63c9cd933af7..e597fc5317e0. > It may be that the bad help string ("error" instead of "werror") is > present in other projects since I just copied the configure.ac when > splitting libguestfs up.

Re: [Libguestfs] [PATCH 3/3] daemon/yara: fix undefined behavior due to Yara 4.0 API changes

2021-10-12 Thread Richard W.M. Jones
On Tue, Oct 12, 2021 at 09:16:10AM -0500, Eric Blake wrote: > On Tue, Oct 12, 2021 at 12:36:27AM +0200, Laszlo Ersek wrote: > > The prototype of yara_rules_callback() is: > > > > > static int > > > yara_rules_callback (int code, void *message, void *data) > > > > however, in Yara commit

Re: [Libguestfs] [PATCH 3/3] daemon/yara: fix undefined behavior due to Yara 4.0 API changes

2021-10-12 Thread Laszlo Ersek
On 10/12/21 00:36, Laszlo Ersek wrote: > Currently, the Yara test case ("yara/test-yara-scan.sh") fails, with the > following obscure error message: > >>> yara-scan /text.txt >> libguestfs: error: deserialise_yara_detection_list: > > Namely, the Yara rule match list serialization /

Re: [Libguestfs] [PATCH 3/3] daemon/yara: fix undefined behavior due to Yara 4.0 API changes

2021-10-12 Thread Eric Blake
On Tue, Oct 12, 2021 at 12:36:27AM +0200, Laszlo Ersek wrote: > The prototype of yara_rules_callback() is: > > > static int > > yara_rules_callback (int code, void *message, void *data) > > however, in Yara commit 2b121b166d25 ("Track string matches using > YR_SCAN_CONTEXT.", 2020-02-27), which

Re: [Libguestfs] [PATCH 3/3] daemon/yara: fix undefined behavior due to Yara 4.0 API changes

2021-10-12 Thread Richard W.M. Jones
Thanks - ACK series. It may be that the bad help string ("error" instead of "werror") is present in other projects since I just copied the configure.ac when splitting libguestfs up. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and

[Libguestfs] [PATCH 3/3] daemon/yara: fix undefined behavior due to Yara 4.0 API changes

2021-10-11 Thread Laszlo Ersek
Currently, the Yara test case ("yara/test-yara-scan.sh") fails, with the following obscure error message: > > yara-scan /text.txt > libguestfs: error: deserialise_yara_detection_list: Namely, the Yara rule match list serialization / de-serialization, between the daemon and the library, is