Re: [Libguestfs] [PATCH libguestfs 2/2] lib: Return correct osinfo field for Windows 11

2022-12-02 Thread Eric Blake
On Fri, Dec 02, 2022 at 09:59:57AM +, Richard W.M. Jones wrote: > > > > In addition, please replace sscanf() with strtol(). The behavior of the > > former is undefined when the subject sequence forms a valid decimal > > string, but the numeric value does not fit into an "int". And, this is >

Re: [Libguestfs] [PATCH libguestfs 2/2] lib: Return correct osinfo field for Windows 11

2022-12-02 Thread Richard W.M. Jones
On Fri, Dec 02, 2022 at 10:11:32AM +0100, Laszlo Ersek wrote: > On 12/01/22 12:20, Richard W.M. Jones wrote: > > On Thu, Dec 01, 2022 at 10:34:09AM +, Richard W.M. Jones wrote: > >> For Windows Client, we can only distinguish between Windows 10 and > >> Windows 11 using the build ID. The

Re: [Libguestfs] [PATCH libguestfs 2/2] lib: Return correct osinfo field for Windows 11

2022-12-02 Thread Laszlo Ersek
On 12/01/22 12:20, Richard W.M. Jones wrote: > On Thu, Dec 01, 2022 at 10:34:09AM +, Richard W.M. Jones wrote: >> For Windows Client, we can only distinguish between Windows 10 and >> Windows 11 using the build ID. The product name in both cases is >> "Windows 10 ", apparently intentionally.

Re: [Libguestfs] [PATCH libguestfs 2/2] lib: Return correct osinfo field for Windows 11

2022-12-01 Thread Richard W.M. Jones
On Thu, Dec 01, 2022 at 10:34:09AM +, Richard W.M. Jones wrote: > For Windows Client, we can only distinguish between Windows 10 and > Windows 11 using the build ID. The product name in both cases is > "Windows 10 ", apparently intentionally. > > References: >

[Libguestfs] [PATCH libguestfs 2/2] lib: Return correct osinfo field for Windows 11

2022-12-01 Thread Richard W.M. Jones
For Windows Client, we can only distinguish between Windows 10 and Windows 11 using the build ID. The product name in both cases is "Windows 10 ", apparently intentionally. References: https://learn.microsoft.com/en-us/answers/questions/586619/windows-11-build-ver-is-still-10022000194.html