Re: [Libguestfs] [PATCH libnbd] ocaml: Implement sockaddr type

2022-11-04 Thread Richard W.M. Jones
On Fri, Nov 04, 2022 at 08:22:59AM +0100, Laszlo Ersek wrote: > On 11/03/22 16:16, Richard W.M. Jones wrote: > > On Thu, Nov 03, 2022 at 04:03:42PM +0100, Laszlo Ersek wrote: > >> On 11/02/22 22:10, Richard W.M. Jones wrote: > >>> +open Unix > >>> +open Printf > >>> + > >>> +let () = > >>> + let

Re: [Libguestfs] [PATCH libnbd] ocaml: Implement sockaddr type

2022-11-04 Thread Laszlo Ersek
On 11/03/22 16:16, Richard W.M. Jones wrote: > On Thu, Nov 03, 2022 at 04:03:42PM +0100, Laszlo Ersek wrote: >> On 11/02/22 22:10, Richard W.M. Jones wrote: >>> +open Unix >>> +open Printf >>> + >>> +let () = >>> + let nbd = NBD.create () in >>> + >>> + (* Unlike other tests, we're going to run

Re: [Libguestfs] [PATCH libnbd] ocaml: Implement sockaddr type

2022-11-03 Thread Richard W.M. Jones
On Thu, Nov 03, 2022 at 04:03:42PM +0100, Laszlo Ersek wrote: > On 11/02/22 22:10, Richard W.M. Jones wrote: > > +open Unix > > +open Printf > > + > > +let () = > > + let nbd = NBD.create () in > > + > > + (* Unlike other tests, we're going to run nbdkit as a subprocess > > + * by hand and

Re: [Libguestfs] [PATCH libnbd] ocaml: Implement sockaddr type

2022-11-03 Thread Laszlo Ersek
On 11/02/22 22:10, Richard W.M. Jones wrote: > Convert Unix.sockaddr to struct sockaddr. OCaml provides a function > to do this ('get_sockaddr' - not namespaced!) This function was > present at least as far back as RHEL 7 (OCaml 4.05). > > This also adds a simple test. > --- >

Re: [Libguestfs] [PATCH libnbd] ocaml: Implement sockaddr type

2022-11-02 Thread Richard W.M. Jones
On Wed, Nov 02, 2022 at 09:10:02PM +, Richard W.M. Jones wrote: > Convert Unix.sockaddr to struct sockaddr. OCaml provides a function > to do this ('get_sockaddr' - not namespaced!) This function was > present at least as far back as RHEL 7 (OCaml 4.05). The namespacing has actually been

[Libguestfs] [PATCH libnbd] ocaml: Implement sockaddr type

2022-11-02 Thread Richard W.M. Jones
Convert Unix.sockaddr to struct sockaddr. OCaml provides a function to do this ('get_sockaddr' - not namespaced!) This function was present at least as far back as RHEL 7 (OCaml 4.05). This also adds a simple test. --- generator/OCaml.ml | 8 ++-- ocaml/helpers.c

[Libguestfs] [PATCH libnbd] ocaml: Implement sockaddr type

2022-11-02 Thread Richard W.M. Jones
This is pushed already, commit 50500aade9. ___ Libguestfs mailing list Libguestfs@redhat.com https://listman.redhat.com/mailman/listinfo/libguestfs