Re: [Libguestfs] [PATCH libnbd 2/2] ocaml: Simplify the sockaddr test

2022-11-04 Thread Eric Blake
On Fri, Nov 04, 2022 at 12:45:32PM +, Richard W.M. Jones wrote: > The sockaddr test added in commit 50500aade9 ("ocaml: Implement > sockaddr type") was quite complicated because it had to run nbdkit as > a subprocess, manage the socket, check for a PID file etc. > > The simpler way of doing

[Libguestfs] [PATCH libnbd 2/2] ocaml: Simplify the sockaddr test

2022-11-04 Thread Richard W.M. Jones
The sockaddr test added in commit 50500aade9 ("ocaml: Implement sockaddr type") was quite complicated because it had to run nbdkit as a subprocess, manage the socket, check for a PID file etc. The simpler way of doing this is to make it work like the Python test (python/test-aio-connect-unix.sh)